From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 8/9] x86/rtc: replace paravirt_enabled()
 check with subarch check
Date: Mon, 22 Feb 2016 09:34:26 -0500
Message-ID: <56CB1C72.2000603@oracle.com>
References: <1455887316-9223-1-git-send-email-mcgrof@kernel.org>
	<1455887316-9223-9-git-send-email-mcgrof@kernel.org>
	<56C71704.9080404@suse.com> <20160219144841.GP25240@wotan.suse.de>
	<20160222060756.GB25240@wotan.suse.de> <20160222102743.GB17895@pd.tnic>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20160222102743.GB17895@pd.tnic>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Borislav Petkov <bp@alien8.de>, "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, x86@kernel.org, luto@amacapital.net, david.vrabel@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 02/22/2016 05:27 AM, Borislav Petkov wrote:
> On Mon, Feb 22, 2016 at 07:07:56AM +0100, Luis R. Rodriguez wrote:
>> diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h
>> index 1ae89a2721d6..fe0d579b63e3 100644
>> --- a/arch/x86/include/asm/x86_init.h
>> +++ b/arch/x86/include/asm/x86_init.h
>> @@ -84,11 +84,14 @@ struct x86_init_paging {
>>    *				boot cpu
>>    * @timer_init:			initialize the platform timer (default PIT/HPET)
>>    * @wallclock_init:		init the wallclock device
>> + * @no_cmos_rtc:		set when platform has no CMOS real-time clock
>> + * 				present
>>    */
>>   struct x86_init_timers {
>>   	void (*setup_percpu_clockev)(void);
>>   	void (*timer_init)(void);
>>   	void (*wallclock_init)(void);
>> +	bool no_cmos_rtc;
> I'd add
>
> 	u64 flags;
>
> to x86_init_ops and then set X86_PLATFORM_NO_RTC or so in there. The
> reason being, others could use that flags field too, for other stuff and
> define more bits.

Maybe timer_flags or platform_flags (or something else) to be a little 
more cscope-friendly?

-boris