From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ross Lagerwall <ross.lagerwall@citrix.com>
Subject: Re: [PATCH v3 19/23] xsplice,
 symbols: Implement symbol name resolution on address. (v2)
Date: Mon, 22 Feb 2016 14:57:46 +0000
Message-ID: <56CB21EA.50307@citrix.com>
References: <1455300361-13092-1-git-send-email-konrad.wilk@oracle.com>
	<1455300361-13092-20-git-send-email-konrad.wilk@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1455300361-13092-20-git-send-email-konrad.wilk@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, konrad@kernel.org, mpohlack@amazon.de, sasha.levin@citrix.com, jinsong.liu@alibaba-inc.com, Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 02/12/2016 06:05 PM, Konrad Rzeszutek Wilk wrote:
snip
>   static int load_payload_data(struct payload *payload, uint8_t *raw, ssize_t len)
>   {
>       struct xsplice_elf elf;
> @@ -831,6 +953,10 @@ static int load_payload_data(struct payload *payload, uint8_t *raw, ssize_t len)
>       if ( rc )
>           goto err_payload;
>
> +    rc = build_symbol_table(payload, &elf);
> +    if ( rc )
> +        goto err_payload;
> +
>       rc = find_special_sections(payload, &elf);
>       if ( rc )
>           goto err_payload;
> @@ -1234,6 +1360,31 @@ unsigned long search_module_extables(unsigned long addr)
>   }
>   #endif
>

build_symbol_table() needs to go after find_special_sections() because 
it uses payload->nfuncs which is only calculated in 
find_special_sections(). Why did you reorder it from how I did it?

-- 
Ross Lagerwall