From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Philipson Subject: Re: [PATCH] tools: remove xenpmd Date: Mon, 22 Feb 2016 14:51:57 -0500 Message-ID: <56CB66DD.7060408@gmail.com> References: <1455720074-11321-1-git-send-email-ian.campbell@citrix.com> <20160217170540.GC23247@char.us.oracle.com> <1455790834.6225.16.camel@citrix.com> <22215.19713.301670.428698@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <22215.19713.301670.428698@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Ian Campbell Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 02/19/2016 12:12 PM, Ian Jackson wrote: > Ian Campbell writes ("Re: [Xen-devel] [PATCH] tools: remove xenpmd"): >> On Wed, 2016-02-17 at 12:05 -0500, Konrad Rzeszutek Wilk wrote: >>> On Wed, Feb 17, 2016 at 02:41:14PM +0000, Ian Campbell wrote: >>>> It has four instances of the same CID 1198719 (strncpy(..., 32) into a >>>> 32-byte buffer). >>>> >>>> However ever since it was checked in in 2008 it has contained a >>>> /tmp instead of the real ones in /proc. I therefore conclude that it >>>> has not ever been used in its current form in the last 8 years and >>>> might as well therefore be deleted. The code remains in the git >>>> history should anyone one to reanimate it. >>>> >>>> Searching online shows no references to the use of this tool. >>>> >>>> Signed-off-by: Ian Campbell >>> >>> Acked-by: Konrad Rzeszutek Wilk >>> >>> .. Can I commit this in now :-) >> >> I think formally it probably needs an Ack from Wei or Ian? > > I think it probably does, and: > > Acked-by: Ian Jackson > > But: > >> I usually give this sort of thing (removals etc) a little longer than >> normal to give more of a chance for objections, although the counter to >> that is that once this is committed it could just as easily be reverted the >> next day as in 6 months time if someone turns up with a good reason it >> shouldn't have been nuked. > > Deleting it right away seems a bit rude. Maybe someone is using it > with the #define sorted out. So if nothing intervenes I guess we > should commit this late next week ? > > Ian. I was around when this was first created. It requires bits in QEMU to make it work which I don't think were ever upstreamed. It is also tied to one of the ACPI SSDTs. If you are removing it you may need to look into that module too: tools/firmware/hvmloader/acpi/ssdt_pm.asl I am not weighing in one whether or not to remove it, just giving some supplemental info... > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > -- Ross Philipson