xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>,
	bp@alien8.de, hpa@zytor.com, tglx@linutronix.de,
	mingo@redhat.com, rusty@rustcorp.com.au
Cc: xen-devel@lists.xensource.com, x86@kernel.org,
	linux-kernel@vger.kernel.org, luto@amacapital.net,
	lguest@lists.ozlabs.org, david.vrabel@citrix.com,
	boris.ostrovsky@oracle.com
Subject: Re: [Xen-devel] [PATCH v3 10/11] x86/rtc: replace paravirt rtc check with x86 specific solution
Date: Tue, 23 Feb 2016 11:57:16 +0000	[thread overview]
Message-ID: <56CC491C.8080505@citrix.com> (raw)
In-Reply-To: <1456212255-23959-11-git-send-email-mcgrof@kernel.org>

On 23/02/16 07:24, Luis R. Rodriguez wrote:
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
[...]
> @@ -1526,8 +1525,6 @@ asmlinkage __visible void __init xen_start_kernel(void)
>  
>  	/* Install Xen paravirt ops */
>  	pv_info = xen_info;
> -	if (xen_initial_domain())
> -		pv_info.features |= PV_SUPPORTED_RTC;
>  	pv_init_ops = xen_init_ops;
>  	if (!xen_pvh_domain()) {
>  		pv_cpu_ops = xen_cpu_ops;
> diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
> index a0a4e554c6f1..fbfcb01015f0 100644
> --- a/arch/x86/xen/time.c
> +++ b/arch/x86/xen/time.c
> @@ -446,8 +446,10 @@ void __init xen_init_time_ops(void)
>  	x86_platform.calibrate_tsc = xen_tsc_khz;
>  	x86_platform.get_wallclock = xen_get_wallclock;
>  	/* Dom0 uses the native method to set the hardware RTC. */
> -	if (!xen_initial_domain())
> +	if (!xen_initial_domain()) {
> +		x86_init.platform_flags |= X86_PLATFORM_NO_RTC;
>  		x86_platform.set_wallclock = xen_set_wallclock;
> +	}
>  }

Is this an early enough point to set this flag?

David

  reply	other threads:[~2016-02-23 11:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23  7:24 [PATCH v3 00/11] x86/init: replace paravirt_enabled() were possible Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 01/11] x86/boot: enumerate documentation for the x86 hardware_subarch Luis R. Rodriguez
2016-02-23  8:51   ` Ingo Molnar
2016-02-23 10:34     ` Luis R. Rodriguez
2016-02-23 20:41       ` Luis R. Rodriguez
2016-02-24  8:32         ` Ingo Molnar
2016-02-24 16:40           ` Andy Lutomirski
2016-02-25  1:18             ` Luis R. Rodriguez
2016-02-25  1:29               ` Andy Lutomirski
     [not found]             ` <CALCETrW=dia7QCDhJVF8rnaKGDx_NNYVZqUNZSs9R87_o=h6NQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-25  8:10               ` Ingo Molnar
2016-03-02  0:43           ` Luis R. Rodriguez
2016-03-02 19:40             ` Luis R. Rodriguez
2016-04-07 20:59           ` Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 02/11] tools/lguest: make lguest launcher use X86_SUBARCH_LGUEST explicitly Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 03/11] x86/xen: use X86_SUBARCH_XEN for PV guest boots Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 04/11] x86/init: make ebda depend on PC subarch Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 05/11] tools/lguest: force disable tboot and apm Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 06/11] apm32: remove paravirt_enabled() use Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 07/11] x86/tboot: remove paravirt_enabled() Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 08/11] x86/cpu/intel: replace paravirt_enabled() for f00f work around Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 09/11] x86/boot: add BIT() to boot/bitops.h Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 10/11] x86/rtc: replace paravirt rtc check with x86 specific solution Luis R. Rodriguez
2016-02-23 11:57   ` David Vrabel [this message]
2016-02-23 18:10     ` [Xen-devel] " Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 11/11] pnpbios: replace paravirt_enabled() check with subarch checks Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CC491C.8080505@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=lguest@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mcgrof@kernel.org \
    --cc=mingo@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).