From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: New Defects reported by Coverity Scan for XenProject
Date: Thu, 25 Feb 2016 10:06:45 +0000
Message-ID: <56CED235.7000506@citrix.com>
References: <56ce8ad13abd2_bd9abd33094410@ss1435.mail>
 <1456394431.6225.182.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1456394431.6225.182.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Ian Campbell <ian.campbell@citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Harmandeep Kaur <write.harmandeep@gmail.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wei.liu2@citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

T24gMjUvMDIvMTYgMTA6MDAsIElhbiBDYW1wYmVsbCB3cm90ZToKPiAKPiBPbiBXZWQsIDIwMTYt
MDItMjQgYXQgMjE6MDIgLTA4MDAsIHNjYW4tYWRtaW5AY292ZXJpdHkuY29tIHdyb3RlOgo+PiBI
aSwKPj4KPj4gUGxlYXNlIGZpbmQgdGhlIGxhdGVzdCByZXBvcnQgb24gbmV3IGRlZmVjdChzKSBp
bnRyb2R1Y2VkIHRvIFhlblByb2plY3QgZm91bmQgd2l0aCBDb3Zlcml0eSBTY2FuLgo+Pgo+PiAy
IG5ldyBkZWZlY3QocykgaW50cm9kdWNlZCB0byBYZW5Qcm9qZWN0IGZvdW5kIHdpdGggQ292ZXJp
dHkgU2Nhbi4KPj4gMTIgZGVmZWN0KHMpLCByZXBvcnRlZCBieSBDb3Zlcml0eSBTY2FuIGVhcmxp
ZXIsIHdlcmUgbWFya2VkIGZpeGVkIGluIHRoZSByZWNlbnQgYnVpbGQgYW5hbHl6ZWQgYnkgQ292
ZXJpdHkgU2Nhbi4KPj4KPj4gTmV3IGRlZmVjdChzKSBSZXBvcnRlZC1ieTogQ292ZXJpdHkgU2Nh
bgo+PiBTaG93aW5nIDIgb2YgMiBkZWZlY3QocykKPj4KPj4KPj4gKiogQ0lEIDEzNTQyNDQ6ICBO
dWxsIHBvaW50ZXIgZGVyZWZlcmVuY2VzICAoRk9SV0FSRF9OVUxMKQo+PiAvdG9vbHMvbGlieGMv
eGNfdGJ1Zi5jOiA3MiBpbiB4Y190YnVmX2dldF9zaXplKCkKPj4KPj4KPj4gX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gKioqIENJRCAxMzU0MjQ0OiAg
TnVsbCBwb2ludGVyIGRlcmVmZXJlbmNlcyAgKEZPUldBUkRfTlVMTCkKPj4gL3Rvb2xzL2xpYnhj
L3hjX3RidWYuYzogNzIgaW4geGNfdGJ1Zl9nZXRfc2l6ZSgpCj4+IDY2ICAgICAgICAgICAgIHJl
dHVybiByYzsKPj4gNjcgICAgIAo+PiA2OCAgICAgICAgIHRfaW5mbyA9IHhjX21hcF9mb3JlaWdu
X3JhbmdlKHhjaCwgRE9NSURfWEVOLAo+PiA2OSAgICAgICAgICAgICAgICAgICAgICAgICBzeXNj
dGwudS50YnVmX29wLnNpemUsIFBST1RfUkVBRCB8IFBST1RfV1JJVEUsCj4+IDcwICAgICAgICAg
ICAgICAgICAgICAgICAgIHN5c2N0bC51LnRidWZfb3AuYnVmZmVyX21mbik7Cj4+IDcxICAgICAK
Pj4+Pj4gICAgIENJRCAxMzU0MjQ0OiAgTnVsbCBwb2ludGVyIGRlcmVmZXJlbmNlcyAgKEZPUldB
UkRfTlVMTCkKPj4+Pj4gICAgIENvbXBhcmluZyAidF9pbmZvIiB0byBudWxsIGltcGxpZXMgdGhh
dCAidF9pbmZvIiBtaWdodCBiZSBudWxsLgo+PiA3MiAgICAgICAgIGlmICggdF9pbmZvID09IE5V
TEwgfHwgdF9pbmZvLT50YnVmX3NpemUgPT0gMCApCj4+IDczICAgICAgICAgICAgIHJjID0gLTE7
Cj4+IDc0ICAgICAgICAgZWxzZQo+PiA3NSAgICAgCSpzaXplID0gdF9pbmZvLT50YnVmX3NpemU7
Cj4+IDc2ICAgICAKPj4gNzcgICAgICAgICB4ZW5mb3JlaWdubWVtb3J5X3VubWFwKHhjaC0+Zm1l
bSwgdF9pbmZvLCBzeXNjdGwudS50YnVmX29wLnNpemUpOwo+IAo+IFRoaXMgaXMgY29tcGxhaW5p
bmcgYWJvdXQgdGhlIGV2ZW50dWFsIG11bm1hcCh0X2luZm8pID0+IG11bm1hcChOVUxMKSB3aGlj
aAo+IGlzIGJlaGluZCB4ZW5mb3JlaWdubWVtb3J5X3VubWFwKCkuCj4gCj4gTG9va3MgbGlrZSBp
dCB3YXMgbmV3bHkgYWRkZWQgYnkgdGhlIGZpeCB0byBDSUQgMTM1MTIyOCBpbiA3YzQ3OTg4M2Iw
NGEKPiAoImxpYnhjOiBmaXggbGVhayBvZiB0X2luZm8gaW4geGNfdGJ1Zl9nZXRfc2l6ZSgpIiku
Cj4geGVuZm9yZWlnbm1lbW9yeV91bm1hcCgpIHNob3VsZCBiZWhhdmUgbGlrZSBtdW5tYXAgV1JU
IHRvbGxlcmFuY2Ugb2YgTlVMTCwKPiBJJ20gbm90IDEwMCUgc3VyZSB3aGF0IHRoYXQgYmVoYXZp
b3VyIGlzIHNpbmNlIDAgaXMgYSB2YWxpZCBhZGRyZXNzLgo+IHhlbmZvcmVpZ25tZW1vcnkuaCBu
byBkb3VidCB3YW50cyB1cGRhdGluZyB3aXRoIHRoZSBkZXNpcmVkIHNlbWFudGljcyBhbmQKPiBl
aXRoZXIgdGhpcyBjb2RlIG9mIHRoZSBpbXBsZW1lbnRhdGlvbiBhZGp1c3RpbmcgdG8gbWF0Y2gu
Cj4gCj4gV2hpbGUgaGVyZSBJIG5vdGljZSB0aGF0IHVzaW5nIHhjX21hcF8qKCkgdG8gY3JlYXRl
IHRoZSBtYXBwaW5nIGFuZAo+IHhlbmZvcmVpZ25tZW1vcnlfdW5tYXAoKSB0byBkZXN0cm95IGl0
IGlzIGEgYml0IG9kZCBzaW5jZSB0aGV5IGFyZSBzdHJpY3RseQo+IHR3byBzZXBhcmF0ZSBBUElz
LCBldmVuIGlmIG9uZSBoYXBwZW5zIHRvIGJlIGltcGxlbWVudGVkIGluIHRlcm1zIG9mIHRoZQo+
IG90aGVyLiBCZWluZyBsaWJ4YyBpbnRlcm5hbCB0aGlzIGNvZGUgaXMgYXQgbGliZXJ0eSB0byB1
c2UgeGNfbWFwXyogYnV0Cj4gc2hvdWxkIHRoZW4gdXNlIHBsYWluIG11bm1hcCB0byB1bmRvIGl0
LCBvciBpdCB3b3VsZCBhbHNvIGJlIHJlYXNvbmFibGUgdG8KPiBwb3J0IHRoaXMgY29kZSBmdWxs
eSB0byB0aGUgeGVuZm9yZWlnbm1lbW9yeSBpbnRlcmZhY2UuCj4gCj4+Cj4+ICoqIENJRCAxMzU0
MjQzOiAgQ29udHJvbCBmbG93IGlzc3VlcyAgKERFQURDT0RFKQo+PiAvdG9vbHMveGVudHJhY2Uv
eGVuYWx5emUuYzogNDE0OCBpbiBjcjNfZHVtcF9saXN0KCkKPj4KPj4KPj4gX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gKioqIENJRCAxMzU0MjQzOiAg
Q29udHJvbCBmbG93IGlzc3VlcyAgKERFQURDT0RFKQo+PiAvdG9vbHMveGVudHJhY2UveGVuYWx5
emUuYzogNDE0OCBpbiBjcjNfZHVtcF9saXN0KCkKPj4gNDE0MiAgICAgCj4+IDQxNDMgICAgICAg
ICAvKiBDb3VudCB0aGUgbnVtYmVyIG9mIGVsZW1lbnRzICovCj4+IDQxNDQgICAgICAgICBmb3Io
cD1oZWFkOyBwOyBwPXAtPm5leHQpCj4+IDQxNDUgICAgICAgICAgICAgTisrOwo+PiA0MTQ2ICAg
ICAKPj4gNDE0NyAgICAgICAgIGlmKCFOKQo+Pj4+PiAgICAgQ0lEIDEzNTQyNDM6ICBDb250cm9s
IGZsb3cgaXNzdWVzICAoREVBRENPREUpCj4+Pj4+ICAgICBFeGVjdXRpb24gY2Fubm90IHJlYWNo
IHRoaXMgc3RhdGVtZW50OiAicmV0dXJuOyIuCj4gCj4gSGVyZSBpdCBoYXMgb2JzZXJ2ZWQgdGhh
dCBkdWUgdG8gdGhlIChhYm92ZSwganVzdCBvdXQgb2YgdGhlIGNvbnRleHQgZ2l2ZW4KPiBoZXJl
KSAiaWYgKCFoZWFkKSByZXR1cm4iIHRoYXQgdGhlIGZvciBsb29wIG11c3QgcnVuIGF0IGxlYXN0
IG9uY2UsIHNvIE4KPiBjYW5ub3QgYmUgMC4KPiAKPiBNeSBndWVzcyBpcyB0aGF0IHRoaXMgaXMg
YSBwcmV4aXN0aW5nIGlzc3VlIHdoaWNoIHdhcyBleHBvc2VkIHRvIGNvdmVyaXRpZXMKPiBiZWFk
eSBleWUgc29tZWhvdyBieSAyOGFiOWYzZDBlN2MgKCJ0b29scy94ZW5hbHl6ZTogRml4IGJ1aWxk
IHdpdGggY2xhbmciKS4KPiBPciBtYXliZSB0aGlzIHdhcyBwcmV2aW91cyBtYXJrZWQgZGVsaWJl
cmF0ZSBidXQgdGhlIGNoYW5nZSBoYXMgY2F1c2VkCj4gY292ZXJpdHkgdG8gdGhpbmsgdGhpcyBp
cyBhIGRpZmZlcmVudCBpbnN0YW5jZSBvZiB0aGUgc2FtZSB0aGluZywgZWl0aGVyd2F5Cj4gSSBk
b24ndCB0aGluayB0aGUgaXNzdWUgaXRzZWxmIGlzIG5ldy4KPiAKPiBGV0lXIGhhdmluZyBib3Ro
IGlmICghaGVhZCkgcmV0dXJuIGFuZCBpZiAoIU4pIHJldHVybiBsb29rcyByZWR1bmRhbnQgdG8K
PiBtZSwgdGhlIG90aGVyIHR3byBzaW1pbGFyIGxvb2tpbmcgaW5zdGFuY2VzIChmcm9tIGdyZXBw
aW5nIGZvciBOKyspIGhhdmUKPiBvbmx5IHRoZSBsYXR0ZXIgY2hlY2suCgpZZXMsIHRoZXkncmUg
Y2VydGFpbmx5IHJlZHVuZGFudCwgYW5kIEkgZGVmaW5pdGVseSBwcmVmZXIgdGhlIGxhdHRlcgpj
aGVjayByYXRoZXIgdGhhbiB0aGUgZm9ybWVyLiAgSSdsbCBzZW5kIGEgcGF0Y2guCgogLUdlb3Jn
ZQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1k
ZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhl
bi5vcmcveGVuLWRldmVsCg==