From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: shannon.zhao@linaro.org, xen-devel@lists.xen.org,
stefano.stabellini@citrix.com, ian.campbell@citrix.com,
peter.huangpeng@huawei.com
Subject: Re: [PATCH v5 08/22] arm/acpi: Parse MADT to map logical cpu to MPIDR and get cpu_possible_map
Date: Fri, 26 Feb 2016 18:18:55 +0800 [thread overview]
Message-ID: <56D0268F.7040700@huawei.com> (raw)
In-Reply-To: <56D02DB502000078000D6913@prv-mh.provo.novell.com>
On 2016/2/26 17:49, Jan Beulich wrote:
>>>> On 26.02.16 at 07:22, <zhaoshenglong@huawei.com> wrote:
>> > --- a/xen/include/xen/acpi.h
>> > +++ b/xen/include/xen/acpi.h
>> > @@ -39,6 +39,10 @@
>> > #define ACPI_MADT_GET_POLARITY(inti) ACPI_MADT_GET_(POLARITY, inti)
>> > #define ACPI_MADT_GET_TRIGGER(inti) ACPI_MADT_GET_(TRIGGER, inti)
>> >
>> > +#define BAD_MADT_ENTRY(entry, end) ( \
>> > + (!(entry)) || (unsigned long)(entry) + sizeof(*(entry)) > (end) || \
>> > + ((struct acpi_subtable_header *)(entry))->length < sizeof(*(entry)))
> Would it be too much to ask for you to eliminate the bogus cast
> here, in favor of properly using (entry)->header.length? Afaics
> this should be fine for all users of the macro.
Oh, sorry, will update this.
Thanks,
--
Shannon
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-26 10:18 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 6:22 [PATCH v5 00/22] Add ACPI support for Xen itself on ARM64 Shannon Zhao
2016-02-26 6:22 ` [PATCH v5 01/22] arm/acpi: Emulate io ports for arm Shannon Zhao
2016-02-26 12:00 ` Stefano Stabellini
2016-02-26 6:22 ` [PATCH v5 02/22] arm/acpi: Add arm specific acpi header file Shannon Zhao
2016-02-26 6:22 ` [PATCH v5 03/22] arm/acpi: Add __acpi_map_table function for ARM Shannon Zhao
2016-02-26 14:12 ` Stefano Stabellini
2016-02-26 16:29 ` Jan Beulich
2016-02-26 16:30 ` Stefano Stabellini
2016-02-27 6:29 ` [PATCH v6 " Shannon Zhao
2016-02-29 10:54 ` Stefano Stabellini
2016-02-29 11:38 ` Jan Beulich
2016-02-29 11:43 ` Stefano Stabellini
2016-02-29 11:53 ` Jan Beulich
2016-02-29 11:56 ` Stefano Stabellini
2016-02-29 12:05 ` Jan Beulich
2016-02-29 20:29 ` [PATCH v7 " Shannon Zhao
2016-03-01 10:08 ` Jan Beulich
2016-02-26 6:22 ` [PATCH v5 04/22] arm/acpi: Add basic ACPI initialization Shannon Zhao
2016-02-26 13:39 ` Stefano Stabellini
2016-02-26 6:22 ` [PATCH v5 05/22] arm/acpi: Move end_boot_allocator after acpi_boot_table_init Shannon Zhao
2016-02-26 12:08 ` Stefano Stabellini
2016-02-26 6:22 ` [PATCH v5 06/22] arm/acpi: Parse FADT table and get PSCI flags Shannon Zhao
2016-02-26 12:10 ` Stefano Stabellini
2016-02-26 6:22 ` [PATCH v5 07/22] ACPI / table: Print GIC information when MADT is parsed Shannon Zhao
2016-02-26 9:39 ` Jan Beulich
2016-02-26 6:22 ` [PATCH v5 08/22] arm/acpi: Parse MADT to map logical cpu to MPIDR and get cpu_possible_map Shannon Zhao
2016-02-26 9:49 ` Jan Beulich
2016-02-26 10:18 ` Shannon Zhao [this message]
2016-02-26 12:18 ` Stefano Stabellini
2016-02-27 6:33 ` [PATCH v6 " Shannon Zhao
2016-02-29 12:38 ` Jan Beulich
2016-02-26 6:22 ` [PATCH v5 09/22] arm/acpi: Add ACPI support for SMP initialization Shannon Zhao
2016-02-26 6:22 ` [PATCH v5 10/22] acpi/table: Introduce acpi_table_get_entry_madt to get specified entry Shannon Zhao
2016-02-26 9:59 ` Jan Beulich
2016-02-27 6:37 ` [PATCH v6 " Shannon Zhao
2016-02-29 12:39 ` Jan Beulich
2016-02-26 6:22 ` [PATCH v5 11/22] arm: Introduce a generic way to use a device from acpi Shannon Zhao
2016-02-26 6:22 ` [PATCH v5 12/22] arm/irq: Drop the DT prefix of the irq line type Shannon Zhao
2016-02-26 6:22 ` [PATCH v5 13/22] arm/gic-v2: Add ACPI boot support for GICv2 Shannon Zhao
2016-02-26 6:22 ` [PATCH v5 14/22] arm/gic-v3: Add ACPI boot support for GICv3 Shannon Zhao
2016-02-26 6:22 ` [PATCH v5 15/22] arm/gic: Add ACPI support for GIC preinit Shannon Zhao
2016-02-26 6:22 ` [PATCH v5 16/22] arm/irq: Add helper function for setting interrupt type Shannon Zhao
2016-02-26 6:22 ` [PATCH v5 17/22] arm/acpi: Parse GTDT to initialize timer Shannon Zhao
2016-02-26 6:22 ` [PATCH v5 18/22] arm/acpi: Add a new ACPI initialized function for UART Shannon Zhao
2016-02-26 13:46 ` Stefano Stabellini
2016-02-26 6:22 ` [PATCH v5 19/22] ACPICA: Headers: Add support for CSRT and DBG2 ACPI tables Shannon Zhao
2016-02-26 6:22 ` [PATCH v5 20/22] arm/acpi: Initialize serial port from ACPI SPCR table Shannon Zhao
2016-02-26 10:04 ` Jan Beulich
2016-02-26 10:20 ` Shannon Zhao
2016-02-26 11:10 ` Shannon Zhao
2016-02-26 12:32 ` Jan Beulich
2016-02-26 6:22 ` [PATCH v5 21/22] arm/fdt: Export device_tree_for_each_node Shannon Zhao
2016-02-26 6:23 ` [PATCH v5 22/22] arm/acpi: Add acpi parameter to enable/disable acpi Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D0268F.7040700@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=peter.huangpeng@huawei.com \
--cc=shannon.zhao@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).