From: Juergen Gross <jgross@suse.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Cc: george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
dgdegra@tycho.nsa.gov, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: add hypercall option to temporarily pin a vcpu
Date: Fri, 26 Feb 2016 12:43:07 +0100 [thread overview]
Message-ID: <56D03A4B.70403@suse.com> (raw)
In-Reply-To: <1456485632.2959.154.camel@citrix.com>
On 26/02/16 12:20, Dario Faggioli wrote:
> On Fri, 2016-02-26 at 12:14 +0100, Juergen Gross wrote:
>> On 26/02/16 11:39, Jan Beulich wrote:
>>>> @@ -679,6 +691,8 @@ int cpu_disable_scheduler(unsigned int cpu)
>>>> v->affinity_broken = 1;
>>>> }
>>>>
>>>> + printk(XENLOG_DEBUG "Breaking affinity for
>>>> %pv\n", v);
>>> Wouldn't it be even better to make this the "else" to the
>>> preceding if(), since in the suspend case this is otherwise going
>>> to be printed for every vCPU not currently running on pCPU0?
>> Yes, I'll change it.
>>
> On this, can (either of) you elaborate a bit more? I don't think I'm
> following...
In the suspend case the affinity will be broken only temporarily, so
there is no need to print the debug message.
juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-26 11:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 16:50 [PATCH] xen: add hypercall option to temporarily pin a vcpu Juergen Gross
2016-02-26 10:39 ` Jan Beulich
[not found] ` <56D0395702000078000D69A6@suse.com>
2016-02-26 11:14 ` Juergen Gross
2016-02-26 11:20 ` Dario Faggioli
2016-02-26 11:43 ` Juergen Gross [this message]
2016-02-26 12:39 ` Jan Beulich
2016-02-26 13:07 ` Dario Faggioli
2016-02-26 13:32 ` Jan Beulich
2016-02-26 13:39 ` Dario Faggioli
[not found] ` <56D0559C02000078000D6AFE@suse.com>
2016-02-26 12:49 ` Juergen Gross
2016-02-26 13:34 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D03A4B.70403@suse.com \
--to=jgross@suse.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).