From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Subject: Re: [PATCH v2 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi Date: Fri, 26 Feb 2016 15:03:49 +0100 Message-ID: <56D05B45.2050001@gmail.com> References: <1456382355-24614-2-git-send-email-fu.wei@linaro.org> <1456382355-24614-5-git-send-email-fu.wei@linaro.org> <56CF3B24.6030605@gmail.com> Reply-To: The development of GNU GRUB Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9148881312696405768==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org Sender: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org To: Fu Wei , Andrei Borzenkov Cc: The development of GNU GRUB , "xen-devel@lists.xensource.com" , Ian Campbell , Jon Masters , Julien Grall , Leif Lindholm , Linaro UEFI Mailman List List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============9148881312696405768== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PhsgC2RBUWwEP6JDmKb3PTphEQ2uofTnR" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PhsgC2RBUWwEP6JDmKb3PTphEQ2uofTnR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26.02.2016 12:15, Fu Wei wrote: > Hi Andrei, >=20 > On 26 February 2016 at 18:50, Andrei Borzenkov wr= ote: >> On Fri, Feb 26, 2016 at 8:59 AM, Fu Wei wrote: >>>>>>> +@subsection xen_module >>>>>>> >>>>>>> -@deffn Command xen_linux file [arguments] >>>>>>> -Load a dom0 kernel image for xen hypervisor at the booting proce= ss of xen. >>>>>>> +@deffn Command xen_module [--nounzip] file [arguments] >>>>>>> +Load a module for xen hypervisor at the booting process of xen. >>>>>>> The rest of the line is passed verbatim as the module command lin= e. >>>>>>> +Each module will be identified by the order in which the modules= are added. >>>>>>> +The 1st module: dom0 kernel image >>>>>>> +The 2nd module: dom0 ramdisk >>>>>>> +All subsequent modules: UNKNOW >>>>>>> @end deffn >>>>>> >>>>>> Hmm ... from previous discussion I gathered that Xen can detect mo= dule >>>>>> type. What if there is no initrd for dom0? How can subsequent modu= les be >>>>> >>>>> Now , Xen detect module type by the order. (at least on ARM64). >>>>> I think i386 is using Multiboot(2) protocol, so maybe this order is= >>>>> nothing to do with i386. >>>>> >>>> >>>> Then we have obvious problem with your XSM patch (http://savannah.gn= u.org/bugs/?43420) - XSM may land as the first module. That's actually so= mething to solve on Xen side I think. It's just that so far we had just k= ernel and initrd, so that was non issue. >>> >>> Oh, did you mean Wei Liu's patch? >>> >>> I guess XSM may land as the third module (or the module after linux >>> kernel, if you don't have initrd) >>> >>> Yes, agree. (That's actually something to solve on Xen side) >>> >>> I guess xen can get xsm from a special initrd. so for now there is no= t >>> big problem on xsm. >>> >>> Please correct me if I misunderstand something. :-) >>> >>> Thanks! >>> >>> Back to this patch, is that OK for you, or any suggestion? Thanks ! >>> >> >> Yes, as this is dedicated Xen loader we should document this mandatory= >> order - first module must be kernel image, second module must be >> initrd. I do not think we need to mention possibility to load more >> than two modules until there is clear understanding how it can be done= >> without initrd. >=20 > Great thanks for your review, I have updated and sent the v3 patchset, > Hope I understood your suggestion correctly, Please check. :-) >=20 Your patches look fine. Let's wait for Andrei's opinion but I'm leaning to commit them >=20 >=20 --PhsgC2RBUWwEP6JDmKb3PTphEQ2uofTnR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlbQW0sACgkQmBXlbbo5nOv+NQEAo9uD3FAOq/I5cqSfRZYP7v5r FLKFJUzOMJ/SUrsHJ5UA/18nf1URczMsCqKWTSTu/yizCvI4670KDDVmTv1XTdlS =0ckn -----END PGP SIGNATURE----- --PhsgC2RBUWwEP6JDmKb3PTphEQ2uofTnR-- --===============9148881312696405768== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel --===============9148881312696405768==--