From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xen.org
Subject: Re: staging: libxl compile error in libxl__domain_save
Date: Sun, 28 Feb 2016 15:55:24 +0000 [thread overview]
Message-ID: <56D3186C.9070505@citrix.com> (raw)
In-Reply-To: <20160228154753.GA2179@citrix.com>
On 28/02/16 15:47, Wei Liu wrote:
> On Sun, Feb 28, 2016 at 10:39:17AM +0100, Olaf Hering wrote:
>> On Sat, Feb 27, Olaf Hering wrote:
>>
>>> -O2 -Wall
>>> -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
>> I think the cause is the lack of a "maintainer mode", which should
>> enable realworld CFLAGS. Either a new configure knob gets added (and
>> used!) or the existing EXTRA_CFLAGS_* have to be used by commiters. See
>> "grep EXTRA_CFLAGS INSTALL".
>>
> If the current set of compiler flags is not good enough, we should
> improve it. I'm afraid having a third set of maintainer mode flags that
> nobody else uses is going to cause us more headache.
We should be using system-provided CFLAGS/LDFLAGS for all userspace,
appending our own local ones as appropriate. Anything else is (as
demonstrated here) utterly fragile.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-28 15:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 8:14 staging: libxl compile error in libxl__domain_save Olaf Hering
2016-02-27 12:35 ` Andrew Cooper
2016-02-27 14:44 ` Wei Liu
2016-02-27 15:25 ` Olaf Hering
2016-02-28 9:39 ` Olaf Hering
2016-02-28 15:47 ` Wei Liu
2016-02-28 15:55 ` Andrew Cooper [this message]
2016-02-29 6:54 ` Olaf Hering
2016-02-29 9:59 ` Andrew Cooper
2016-02-29 10:32 ` Olaf Hering
2016-02-27 13:47 ` Wei Liu
2016-02-27 14:18 ` Wei Liu
2016-02-28 2:01 ` Doug Goldstein
2016-02-28 14:10 ` Andrew Cooper
2016-02-28 20:20 ` Doug Goldstein
2016-02-28 21:06 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D3186C.9070505@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=olaf@aepfle.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).