From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Olaf Hering <olaf@aepfle.de>, Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: staging: libxl compile error in libxl__domain_save
Date: Mon, 29 Feb 2016 09:59:11 +0000 [thread overview]
Message-ID: <56D4166F.8080907@citrix.com> (raw)
In-Reply-To: <20160229065441.GA5732@aepfle.de>
On 29/02/16 06:54, Olaf Hering wrote:
> On Sun, Feb 28, Wei Liu wrote:
>
>> If the current set of compiler flags is not good enough, we should
>> improve it. I'm afraid having a third set of maintainer mode flags that
>> nobody else uses is going to cause us more headache.
> There is nothing wrong with the CFLAGS. They are perfect for developers.
> But the commiters hopefully do some sort of compile test before doing a
> push. And this compile test must include -O2 to enable enough
> diagnostic to catch developer errors.
gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing
-std=gnu99 -Wall
-Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable
-Wno-unused-local-typedefs -O0 -g3
-D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF
.libxl_dom_save.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -O2
-Wall
-D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
-fasynchronous-unwind-tables -g -Werror -Wno-format-zero-length
-Wmissing-declarations -Wno-declaration-after-statement
-Wformat-nonliteral -I.
-fPIC -pthread
This set of options is very messy. We have both an -O1, an -O0 and an
-O2, as well as three different -g's
Frankly, at no point ever should -O0 be used, even for debugging. -Og
if available or -O1 if not.
In this case, the -O2, being latest, should take priority. However, it
would be useful to identify which flags are coming from where, and see
if we usefully reduce them.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-29 9:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 8:14 staging: libxl compile error in libxl__domain_save Olaf Hering
2016-02-27 12:35 ` Andrew Cooper
2016-02-27 14:44 ` Wei Liu
2016-02-27 15:25 ` Olaf Hering
2016-02-28 9:39 ` Olaf Hering
2016-02-28 15:47 ` Wei Liu
2016-02-28 15:55 ` Andrew Cooper
2016-02-29 6:54 ` Olaf Hering
2016-02-29 9:59 ` Andrew Cooper [this message]
2016-02-29 10:32 ` Olaf Hering
2016-02-27 13:47 ` Wei Liu
2016-02-27 14:18 ` Wei Liu
2016-02-28 2:01 ` Doug Goldstein
2016-02-28 14:10 ` Andrew Cooper
2016-02-28 20:20 ` Doug Goldstein
2016-02-28 21:06 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D4166F.8080907@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=olaf@aepfle.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).