From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v4] xen: credit1: avoid boosting vCPUs being "just" migrated Date: Mon, 29 Feb 2016 14:34:33 +0000 Message-ID: <56D456F9.2040707@citrix.com> References: <20160224174239.13376.58865.stgit@Solace.station> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1aaOuF-0003Zt-7v for xen-devel@lists.xenproject.org; Mon, 29 Feb 2016 14:34:39 +0000 In-Reply-To: <20160224174239.13376.58865.stgit@Solace.station> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Dario Faggioli , xen-devel@lists.xenproject.org Cc: George Dunlap , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gMjQvMDIvMTYgMTc6NDIsIERhcmlvIEZhZ2dpb2xpIHdyb3RlOgo+IE1vdmluZyBhIHZDUFUg dG8gYSBkaWZmZXJlbnQgcENQVSBtZWFucyBvZmZsaW5pbmcgaXQgYW5kCj4gdGhlbiB3YWtpbmcg aXQgdXAsIG9uIHRoZSBuZXcgcENQVS4gQ3JlZGl0MSBncmFudHMgQk9PU1QKPiBwcmlvcml0eSB0 byB2Q1BVcyB0aGF0IHdha2VzIHVwLCB3aXRoIHRoZSBhaW0gb2YgaW1wcm92aW5nCj4gSS9PIGxh dGVuY3kuIFRoZSBuZXQgZWZmZWN0IG9mIHRoaXMgYWxsIGlzIHRoYXQgdkNQVXMgZ2V0Cj4gYm9v c3RlZCB3aGVuIG1pZ3JhdGluZywgd2hpY2ggc2hvdWxkbid0IGhhcHBlbi4KPiAKPiBGb3IgaW5z dGFuY2UsIHRoaXMgY2F1c2VzIHNjaGVkdWxpbmcgYW5vbWFsaWVzIGFuZCwKPiBwb3RlbnRpYWxs eSwgcGVyZm9ybWFuY2UgcHJvYmxlbXMsIGFzIHJlcG9ydGVkIGhlcmU6Cj4gICBodHRwOi8vbGlz dHMueGVuLm9yZy9hcmNoaXZlcy9odG1sL3hlbi1kZXZlbC8yMDE1LTEwL21zZzAyODUxLmh0bWwK PiAKPiBUaGlzIHBhdGNoIGZpeGVzIHRoaXMgYnkgbm90aW5nIGRvd24gKGJ5IG1lYW5zIG9mIGEg ZmxhZykKPiB0aGUgZmFjdCB0aGF0IHRoZSB2Q1BVIGlzIGFib3V0IHRvIHVuZGVyZ28gYSBtaWdy YXRpb24uCj4gVGhpcyB3YXkgd2UgY2FuIHRlbGwsIGxhdGVyLCBkdXJpbmcgYSB3YWtldXAsIHdo ZXRoZXIgdGhlCj4gdkNQVSBpcyBtaWdyYXRpbmcgb3IgdW5ibG9ja2luZywgYW5kIGRlY2lkZSB3 aGV0aGVyIG9yCj4gbm90IHRvIGFwcGx5IHRoZSBib29zdGluZy4KPiAKPiBOb3RlIHRoYXQgaXQg aXMgaW1wb3J0YW50IHRoYXQgYXRvbWljLXNhZmUgYml0IG9wZXJhdGlvbnMKPiBhcmUgdXNlZCB3 aGVuIG1hbmlwdWxhdGluZyB2Q1BVcycgZmxhZ3MuIFRha2UgdGhlIGNoYW5jZQo+IGFuZCBhZGQg YSBjb21tZW50IGFib3V0IHRoaXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogRGFyaW8gRmFnZ2lvbGkg PGRhcmlvLmZhZ2dpb2xpQGNpdHJpeC5jb20+CgpSZXZpZXdlZC1ieTogR2VvcmdlIER1bmxhcCA8 Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPgoKVGhhbmtzLCBzb3JyeSBmb3IgdGhlIGRlbGF5LiA6 LSkKCj4gLS0tCj4gQ2M6IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAZXUuY2l0cml4LmNv bT4KPiBDYzogSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPgo+IC0tLQo+IENoYW5nZXMg ZnJvbSB2MzoKPiAgKiB1c2UgYSBsb2NhbCBib29sZWFuIHZhcmlhYmxlIHRvIHRyYWNrIGlmIHRo ZSB2Y3B1IGlzIG1pZ3JhdGluZywKPiAgICB0byBtYWtlIHRoZSBjb2RlIGNsZWFyZXIgYW5kIGVh c2llciB0byByZWFkLCBhcyBzdWdnZXN0ZWQgZHVyaW5nCj4gICAgcmV2aWV3Lgo+IAo+IENoYW5n ZXMgZnJvbSB2MjoKPiAgKiB0ZXN0X2FuZF9jbGVhcigpIGlzIG5lY2Vzc2FyeSB3aGVuIGFjY2Vz c2luZyBzdmMtPmZsYWdzOwo+ICAqIGFkZGVkIGEgY29tbWVudCBhYm91dCBzdWNoIG5lZWQgYXQg dGhlIHRvcCwgd2hlcmUgdGhlIGZsYWdzCj4gICAgYXJlIGRlZmluZWQuCj4gCj4gQ2hhbmdlcyBm cm9tIHYxOgo+ICAqIHJld3JpdHRlbiwgZm9sbG93aW5nIHN1Z2dlc3Rpb24gZ290IGR1cmluZyBy ZXZpZXc6IHRoZXJlCj4gICAgYXJlIG5vIHdha2V1cCBmbGFncyBhbnkgbG9uZ2VyLCBhbmQgYWxs IGlzIGRvbmUgaW4gc2NoZWRfY3JlZGl0LmMKPiAgICBieSBzZXR0aW5nIGEgZmxhZyBpbiBjc2No ZWRfY3B1X3BpY2soKSBhbmQgdGVzdGluZyAoYW5kCj4gICAgY2xlYXRpbmcpIGl0IGluIGNzY2hl ZF92Y3B1X3dha2UoKS4KPiAtLS0KPiAgeGVuL2NvbW1vbi9zY2hlZF9jcmVkaXQuYyB8ICAgMjgg KysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0 aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9zY2hl ZF9jcmVkaXQuYyBiL3hlbi9jb21tb24vc2NoZWRfY3JlZGl0LmMKPiBpbmRleCAwYWY1ZjY5Li4z MDU4ODlhIDEwMDY0NAo+IC0tLSBhL3hlbi9jb21tb24vc2NoZWRfY3JlZGl0LmMKPiArKysgYi94 ZW4vY29tbW9uL3NjaGVkX2NyZWRpdC5jCj4gQEAgLTYzLDkgKzYzLDE0IEBACj4gIAo+ICAvKgo+ ICAgKiBGbGFncwo+ICsgKgo+ICsgKiBOb3RlIHRoYXQgc3ZjLT5mbGFncyAod2hlcmUgdGhlc2Ug ZmxhZ3MgbGl2ZSkgaXMgcHJvdGVjdGVkIGJ5IGFuCj4gKyAqIGluY29uc2lzdGVudCBzZXQgb2Yg bG9ja3MuIFRoZXJlZm9yZSBhdG9taWMtc2FmZSBiaXQgb3BlcmF0aW9ucyBtdXN0Cj4gKyAqIGJl IHVzZWQgZm9yIGFjY2Vzc2luZyBpdC4KPiAgICovCj4gICNkZWZpbmUgQ1NDSEVEX0ZMQUdfVkNQ VV9QQVJLRUQgICAgMHgwICAvKiBWQ1BVIG92ZXIgY2FwcGVkIGNyZWRpdHMgKi8KPiAgI2RlZmlu ZSBDU0NIRURfRkxBR19WQ1BVX1lJRUxEICAgICAweDEgIC8qIFZDUFUgeWllbGRpbmcgKi8KPiAr I2RlZmluZSBDU0NIRURfRkxBR19WQ1BVX01JR1JBVElORyAweDIgIC8qIFZDUFUgbWF5IGhhdmUg bW92ZWQgdG8gYSBuZXcgcGNwdSAqLwo+ICAKPiAgCj4gIC8qCj4gQEAgLTc4Niw2ICs3OTEsMTYg QEAgX2NzY2hlZF9jcHVfcGljayhjb25zdCBzdHJ1Y3Qgc2NoZWR1bGVyICpvcHMsIHN0cnVjdCB2 Y3B1ICp2YywgYm9vbF90IGNvbW1pdCkKPiAgc3RhdGljIGludAo+ICBjc2NoZWRfY3B1X3BpY2so Y29uc3Qgc3RydWN0IHNjaGVkdWxlciAqb3BzLCBzdHJ1Y3QgdmNwdSAqdmMpCj4gIHsKPiArICAg IHN0cnVjdCBjc2NoZWRfdmNwdSAqc3ZjID0gQ1NDSEVEX1ZDUFUodmMpOwo+ICsKPiArICAgIC8q Cj4gKyAgICAgKiBXZSBoYXZlIGJlZW4gY2FsbGVkIGJ5IHZjcHVfbWlncmF0ZSgpIChpbiBzY2hl ZHVsZS5jKSwgYXMgcGFydAo+ICsgICAgICogb2YgdGhlIHByb2Nlc3Mgb2Ygc2VlaW5nIGlmIHZj IGNhbiBiZSBtaWdyYXRlZCB0byBhbm90aGVyIHBjcHUuCj4gKyAgICAgKiBXZSBtYWtlIGEgbm90 ZSBhYm91dCB0aGlzIGluIHN2Yy0+ZmxhZ3Mgc28gdGhhdCBsYXRlciwgaW4KPiArICAgICAqIGNz Y2hlZF92Y3B1X3dha2UoKSAoc3RpbGwgY2FsbGVkIGZyb20gdmNwdV9taWdyYXRlKCkpIHdlIHdv bid0Cj4gKyAgICAgKiBnZXQgYm9vc3RlZCwgd2hpY2ggd2UgZG9uJ3QgZGVzZXJ2ZSBhcyB3ZSBh cmUgIm9ubHkiIG1pZ3JhdGluZy4KPiArICAgICAqLwo+ICsgICAgc2V0X2JpdChDU0NIRURfRkxB R19WQ1BVX01JR1JBVElORywgJnN2Yy0+ZmxhZ3MpOwo+ICAgICAgcmV0dXJuIF9jc2NoZWRfY3B1 X3BpY2sob3BzLCB2YywgMSk7Cj4gIH0KPiAgCj4gQEAgLTk4NSw2ICsxMDAwLDcgQEAgc3RhdGlj IHZvaWQKPiAgY3NjaGVkX3ZjcHVfd2FrZShjb25zdCBzdHJ1Y3Qgc2NoZWR1bGVyICpvcHMsIHN0 cnVjdCB2Y3B1ICp2YykKPiAgewo+ICAgICAgc3RydWN0IGNzY2hlZF92Y3B1ICogY29uc3Qgc3Zj ID0gQ1NDSEVEX1ZDUFUodmMpOwo+ICsgICAgYm9vbF90IG1pZ3JhdGluZzsKPiAgCj4gICAgICBC VUdfT04oIGlzX2lkbGVfdmNwdSh2YykgKTsKPiAgCj4gQEAgLTEwMjAsMTEgKzEwMzYsMTUgQEAg Y3NjaGVkX3ZjcHVfd2FrZShjb25zdCBzdHJ1Y3Qgc2NoZWR1bGVyICpvcHMsIHN0cnVjdCB2Y3B1 ICp2YykKPiAgICAgICAqIG1vcmUgQ1BVIHJlc291cmNlIGludGVuc2l2ZSBWQ1BVcyB3aXRob3V0 IGltcGFjdGluZyBvdmVyYWxsIAo+ICAgICAgICogc3lzdGVtIGZhaXJuZXNzLgo+ICAgICAgICoK PiAtICAgICAqIFRoZSBvbmUgZXhjZXB0aW9uIGlzIGZvciBWQ1BVcyBvZiBjYXBwZWQgZG9tYWlu cyB1bnBhdXNpbmcKPiAtICAgICAqIGFmdGVyIGVhcm5pbmcgY3JlZGl0cyB0aGV5IGhhZCBvdmVy c3BlbnQuIFdlIGRvbid0IGJvb3N0Cj4gLSAgICAgKiB0aG9zZS4KPiArICAgICAqIFRoZXJlIGFy ZSB0d28gY2FzZXMsIHdoZW4gd2UgZG9uJ3Qgd2FudCB0byBib29zdDoKPiArICAgICAqICAtIFZD UFVzIHRoYXQgYXJlIHdha2luZyB1cCBhZnRlciBhIG1pZ3JhdGlvbiwgcmF0aGVyIHRoYW4KPiAr ICAgICAqICAgIGFmdGVyIGhhdmluZyBibG9jazsKPiArICAgICAqICAtIFZDUFVzIG9mIGNhcHBl ZCBkb21haW5zIHVucGF1c2luZyBhZnRlciBlYXJuaW5nIGNyZWRpdHMKPiArICAgICAqICAgIHRo ZXkgaGFkIG92ZXJzcGVudC4KPiAgICAgICAqLwo+IC0gICAgaWYgKCBzdmMtPnByaSA9PSBDU0NI RURfUFJJX1RTX1VOREVSICYmCj4gKyAgICBtaWdyYXRpbmcgPSB0ZXN0X2FuZF9jbGVhcl9iaXQo Q1NDSEVEX0ZMQUdfVkNQVV9NSUdSQVRJTkcsICZzdmMtPmZsYWdzKTsKPiArCj4gKyAgICBpZiAo ICFtaWdyYXRpbmcgJiYgc3ZjLT5wcmkgPT0gQ1NDSEVEX1BSSV9UU19VTkRFUiAmJgo+ICAgICAg ICAgICAhdGVzdF9iaXQoQ1NDSEVEX0ZMQUdfVkNQVV9QQVJLRUQsICZzdmMtPmZsYWdzKSApCj4g ICAgICB7Cj4gICAgICAgICAgVFJBQ0VfMkQoVFJDX0NTQ0hFRF9CT09TVF9TVEFSVCwgdmMtPmRv bWFpbi0+ZG9tYWluX2lkLCB2Yy0+dmNwdV9pZCk7Cj4gCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2 ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK