xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Bob Liu <bob.liu@oracle.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: jgross@suse.com, xen-devel@lists.xen.org,
	paul.durrant@citrix.com, jbeulich@suse.com, roger.pau@citrix.com
Subject: Re: [RFC PATCH] xen-block: introduces extra request to pass-through SCSI commands
Date: Tue, 01 Mar 2016 07:45:25 +0800	[thread overview]
Message-ID: <56D4D815.8070102@oracle.com> (raw)
In-Reply-To: <22228.29144.86070.673596@mariner.uk.xensource.com>


On 03/01/2016 12:29 AM, Ian Jackson wrote:
> Ian Jackson writes ("Re: [RFC PATCH] xen-block: introduces extra request to pass-through SCSI commands"):
>> [stuff suggesting use of PVSCSI instead]
> 
> For the avoidance of doubt:
> 
> 1. Thanks very much for bringing this proposal to us at the concept
> stage.  It is much easier to discuss these matters in a constructive
> way before a lot of effort has been put into an implementation.
> 
> 2. I should explain the downsides which I see in your proposal:
> 
> - Your suggestion has bad security properties: previously, the PV
>   block protocol would present only a very simple and narrow
>   interface.  Your SCSI CDB passthrough proposal means that guests
>   would be able to activate features in SCSI targets which would be
>   unexpected and unintended by the host administrator.  Such features
>   would perhaps even be unknown to the host administrator.
> 
>   This could be mitigated by making this feature configurable, of
>   course, defaulting to off, along with clear documentation.  But it's
>   not a desirable property.
> 
> - For similar reasons it will often be difficult to use such a feature
>   safely.  Guest software in particular might expect that it can
>   safely use whatever features it can see, and do all sorts of
>   exciting things.
> 
> - It involves duplicating multiplexing logic which already exists in
>   PVSCSI.
> 

One thing I'm still not sure about PVSCSI is do we have the same security issue since LIO can interface to any block device.
E.g when using a partition /dev/sda1 as the PVSCSI-backend, but the PVSCSI-frontend may send SCSI operates on LUN bases (the whole disk).

P.S. Thanks to all of you, it helps a lot!

-- 
Regards,
-Bob

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-02-29 23:45 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29  3:37 [RFC PATCH] xen-block: introduces extra request to pass-through SCSI commands Bob Liu
2016-02-29  8:12 ` Juergen Gross
2016-02-29 15:05   ` Konrad Rzeszutek Wilk
2016-02-29 15:34     ` Juergen Gross
2016-02-29  9:13 ` Paul Durrant
2016-02-29 14:55   ` Konrad Rzeszutek Wilk
2016-02-29 15:28     ` Paul Durrant
2016-02-29 15:35       ` Roger Pau Monné
2016-02-29 16:48         ` Konrad Rzeszutek Wilk
2016-02-29 16:56           ` Paul Durrant
2016-02-29 16:14 ` Ian Jackson
2016-02-29 16:29   ` Ian Jackson
2016-02-29 23:45     ` Bob Liu [this message]
2016-02-29 23:45     ` Bob Liu
2016-03-01 18:08       ` Ian Jackson
2016-03-02  7:39         ` Juergen Gross
2016-03-02  7:57           ` Bob Liu
2016-03-02 11:40             ` Ian Jackson
2016-03-02 11:46               ` Paul Durrant
2016-03-02 12:00                 ` Juergen Gross
2016-03-02 12:28               ` Bob Liu
2016-03-02 14:44                 ` Ian Jackson
     [not found]                   ` <20160302172257.GC27821@char.us.oracle.com>
2016-03-03 11:54                     ` Paul Durrant
2016-03-03 12:03                       ` Ian Jackson
2016-03-03 12:25                         ` Juergen Gross
2016-03-03 14:07                           ` Konrad Rzeszutek Wilk
2016-03-03 14:19                             ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D4D815.8070102@oracle.com \
    --to=bob.liu@oracle.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=paul.durrant@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).