From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Pohlack Subject: Re: [PATCH v3 21/23] xsplice: Add support for shadow variables Date: Mon, 7 Mar 2016 08:40:47 +0100 Message-ID: <56DD307F.9090609@amazon.com> References: <1455300361-13092-1-git-send-email-konrad.wilk@oracle.com> <1455300361-13092-22-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1acpni-0004pj-CX for xen-devel@lists.xenproject.org; Mon, 07 Mar 2016 07:41:58 +0000 In-Reply-To: <1455300361-13092-22-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, konrad@kernel.org, mpohlack@amazon.de, ross.lagerwall@citrix.com, sasha.levin@citrix.com, jinsong.liu@alibaba-inc.com, Ian Campbell , Ian Jackson , Jan Beulich , Keir Fraser , Tim Deegan , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gMTIuMDIuMjAxNiAxOTowNSwgS29ucmFkIFJ6ZXN6dXRlayBXaWxrIHdyb3RlOgo+IEZyb206 IFJvc3MgTGFnZXJ3YWxsIDxyb3NzLmxhZ2Vyd2FsbEBjaXRyaXguY29tPgo+IAo+IFNoYWRvdyB2 YXJpYWJsZXMgYXJlIGEgcGllY2Ugb2YgaW5mcmFzdHJ1Y3R1cmUgdG8gYmUgdXNlZCBieSB4c3Bs aWNlCj4gbW9kdWxlcy4gVGhleSBhcmUgdXNlZCB0byBhdHRhY2ggYSBuZXcgcGllY2Ugb2YgZGF0 YSB0byBhbiBleGlzdGluZwo+IHN0cnVjdHVyZSBpbiBtZW1vcnkuCj4gCj4gU2lnbmVkLW9mZi1i eTogUm9zcyBMYWdlcndhbGwgPHJvc3MubGFnZXJ3YWxsQGNpdHJpeC5jb20+Cj4gLS0tCj4gIHhl bi9jb21tb24vTWFrZWZpbGUgICAgICAgICAgICAgfCAgIDEgKwo+ICB4ZW4vY29tbW9uL3hzcGxp Y2Vfc2hhZG93LmMgICAgIHwgMTA1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysKPiAgeGVuL2luY2x1ZGUveGVuL3hzcGxpY2VfcGF0Y2guaCB8ICAzOSArKysrKysrKysr KysrKysKPiAgMyBmaWxlcyBjaGFuZ2VkLCAxNDUgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9k ZSAxMDA2NDQgeGVuL2NvbW1vbi94c3BsaWNlX3NoYWRvdy5jCj4gIGNyZWF0ZSBtb2RlIDEwMDY0 NCB4ZW4vaW5jbHVkZS94ZW4veHNwbGljZV9wYXRjaC5oCj4gCj4gZGlmZiAtLWdpdCBhL3hlbi9j b21tb24vTWFrZWZpbGUgYi94ZW4vY29tbW9uL01ha2VmaWxlCj4gaW5kZXggYThjZWFmZi4uZjRk NTRhZCAxMDA2NDQKPiAtLS0gYS94ZW4vY29tbW9uL01ha2VmaWxlCj4gKysrIGIveGVuL2NvbW1v bi9NYWtlZmlsZQo+IEBAIC03NSwzICs3NSw0IEBAIHN1YmRpci0kKENPTkZJR19IQVNfREVWSUNF X1RSRUUpICs9IGxpYmZkdAo+ICAKPiAgb2JqLSQoQ09ORklHX1hTUExJQ0UpICs9IHhzcGxpY2Uu bwo+ICBvYmotJChDT05GSUdfWFNQTElDRSkgKz0geHNwbGljZV9lbGYubwo+ICtvYmotJChDT05G SUdfWFNQTElDRSkgKz0geHNwbGljZV9zaGFkb3cubwo+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9u L3hzcGxpY2Vfc2hhZG93LmMgYi94ZW4vY29tbW9uL3hzcGxpY2Vfc2hhZG93LmMKPiBuZXcgZmls ZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAuLjYxOWNkZWUKPiAtLS0gL2Rldi9udWxsCj4g KysrIGIveGVuL2NvbW1vbi94c3BsaWNlX3NoYWRvdy5jCj4gQEAgLTAsMCArMSwxMDUgQEAKPiAr I2luY2x1ZGUgPHhlbi9pbml0Lmg+Cj4gKyNpbmNsdWRlIDx4ZW4va2VybmVsLmg+Cj4gKyNpbmNs dWRlIDx4ZW4vbGliLmg+Cj4gKyNpbmNsdWRlIDx4ZW4vbGlzdC5oPgo+ICsjaW5jbHVkZSA8eGVu L3NwaW5sb2NrLmg+Cj4gKyNpbmNsdWRlIDx4ZW4veHNwbGljZV9wYXRjaC5oPgo+ICsKPiArI2Rl ZmluZSBTSEFET1dfU0xPVFMgMjU2CgpVc2luZyBzb21ldGhpbmcgdmVyeSByb3VuZCBoZXJlIHdp bGwgZ2l2ZSB5b3UgbG90J3Mgb2YgaGFzaCBjb2xsaXNpb25zCmF0IHRoZSBwcmljZSBvZiBhIHZl cnkgZmFzdCBoYXNoIGNvbXB1dGF0aW9uIGFzIGNvbXBpbGVycywgbGlua2VycywgYW5kCm1lbW9y eSBhbGxvY2F0b3JzIHRlbmQgdG8gYWxpZ24gc3RhcnRpbmcgYWRkcmVzc2VzLiAgSSB3b3VsZCBz dWdnZXN0IHRvCnVzZSBhIHNtYWxsIHByaW1lIGhlcmUsIGUuZy4sIDI1NyBvciAyNTEsIHRvIGhh dmUgYSBmaXJzdCBhcHByb3hpbWF0aW9uCm9mIGEgc2ltcGxlIGhhc2ggZnVuY3Rpb24uCgpPciB1 c2UgZXhpc3RpbmcgaGFzaCBpbmZyYXN0cnVjdHVyZSAoc2VlIGJlbG93KS4KCj4gK3N0cnVjdCBo bGlzdF9oZWFkIHNoYWRvd190YmxbU0hBRE9XX1NMT1RTXTsKPiArc3RhdGljIERFRklORV9TUElO TE9DSyhzaGFkb3dfbG9jayk7Cj4gKwo+ICtzdHJ1Y3Qgc2hhZG93X3ZhciB7Cj4gKyAgICBzdHJ1 Y3QgaGxpc3Rfbm9kZSBsaXN0OyAgICAgICAgIC8qIExpbmtlZCB0byAnc2hhZG93X3RibCcgKi8K PiArICAgIHZvaWQgKmRhdGE7Cj4gKyAgICBjb25zdCB2b2lkICpvYmo7Cj4gKyAgICBjaGFyIHZh clsxNl07Cj4gK307Cj4gKwo+ICt2b2lkICp4c3BsaWNlX3NoYWRvd19hbGxvYyhjb25zdCB2b2lk ICpvYmosIGNvbnN0IGNoYXIgKnZhciwgc2l6ZV90IHNpemUpCj4gK3sKPiArICAgIHN0cnVjdCBz aGFkb3dfdmFyICpzaGFkb3c7Cj4gKyAgICB1bnNpZ25lZCBpbnQgc2xvdDsKPiArCj4gKyAgICBz aGFkb3cgPSB4bWFsbG9jKHN0cnVjdCBzaGFkb3dfdmFyKTsKPiArICAgIGlmICggIXNoYWRvdyAp Cj4gKyAgICAgICAgcmV0dXJuIE5VTEw7Cj4gKwo+ICsgICAgc2hhZG93LT5vYmogPSBvYmo7Cj4g KyAgICBzdHJsY3B5KHNoYWRvdy0+dmFyLCB2YXIsIHNpemVvZiBzaGFkb3ctPnZhcik7Cj4gKyAg ICBzaGFkb3ctPmRhdGEgPSB4bWFsbG9jX2J5dGVzKHNpemUpOwo+ICsgICAgaWYgKCAhc2hhZG93 LT5kYXRhICkKPiArICAgIHsKPiArICAgICAgICB4ZnJlZShzaGFkb3cpOwo+ICsgICAgICAgIHJl dHVybiBOVUxMOwo+ICsgICAgfQo+ICsKPiArICAgIHNsb3QgPSAodW5zaWduZWQgbG9uZylvYmog JSBTSEFET1dfU0xPVFM7CgpoYXNoLmggaGFzIGFuIGVhcmxpZXIgaW1wb3J0IGZyb20gTGludXgg YW5kIHByb3ZpZGVzIGhhc2hfbG9uZygpLiAgVGhhdApsb29rcyBsaWtlIGl0IHdvdWxkIG5vdCBz dWZmZXIgZnJvbSBkaXJlY3QgaGFzaCBjb2xsaXNpb25zLgoKKGFsc28gZm9yIGFsbCBvdGhlciBv Y2N1cnJlbmNlcyBvZiAib2JqICUgU0hBRE9XX1NMT1RTIiBiZWxvdykKCj4gKyAgICBzcGluX2xv Y2soJnNoYWRvd19sb2NrKTsKPiArICAgIGhsaXN0X2FkZF9oZWFkKCZzaGFkb3ctPmxpc3QsICZz aGFkb3dfdGJsW3Nsb3RdKTsKPiArICAgIHNwaW5fdW5sb2NrKCZzaGFkb3dfbG9jayk7Cj4gKwo+ ICsgICAgcmV0dXJuIHNoYWRvdy0+ZGF0YTsKPiArfQo+ICsKPiArdm9pZCB4c3BsaWNlX3NoYWRv d19mcmVlKGNvbnN0IHZvaWQgKm9iaiwgY29uc3QgY2hhciAqdmFyKQo+ICt7Cj4gKyAgICBzdHJ1 Y3Qgc2hhZG93X3ZhciAqZW50cnksICpzaGFkb3cgPSBOVUxMOwo+ICsgICAgdW5zaWduZWQgaW50 IHNsb3Q7Cj4gKyAgICBzdHJ1Y3QgaGxpc3Rfbm9kZSAqbmV4dDsKPiArCj4gKyAgICBzbG90ID0g KHVuc2lnbmVkIGxvbmcpb2JqICUgU0hBRE9XX1NMT1RTOwo+ICsKPiArICAgIHNwaW5fbG9jaygm c2hhZG93X2xvY2spOwo+ICsgICAgaGxpc3RfZm9yX2VhY2hfZW50cnkoZW50cnksIG5leHQsICZz aGFkb3dfdGJsW3Nsb3RdLCBsaXN0KQo+ICsgICAgewo+ICsgICAgICAgIGlmICggZW50cnktPm9i aiA9PSBvYmogJiYKPiArICAgICAgICAgICAgICFzdHJjbXAoZW50cnktPnZhciwgdmFyKSApCj4g KyAgICAgICAgewo+ICsgICAgICAgICAgICBzaGFkb3cgPSBlbnRyeTsKPiArICAgICAgICAgICAg YnJlYWs7Cj4gKyAgICAgICAgfQo+ICsgICAgfQo+ICsgICAgaWYgKHNoYWRvdykKPiArICAgIHsK PiArICAgICAgICBobGlzdF9kZWwoJnNoYWRvdy0+bGlzdCk7Cj4gKyAgICAgICAgeGZyZWUoc2hh ZG93LT5kYXRhKTsKPiArICAgICAgICB4ZnJlZShzaGFkb3cpOwo+ICsgICAgfQo+ICsgICAgc3Bp bl91bmxvY2soJnNoYWRvd19sb2NrKTsKPiArfQo+ICsKPiArdm9pZCAqeHNwbGljZV9zaGFkb3df Z2V0KGNvbnN0IHZvaWQgKm9iaiwgY29uc3QgY2hhciAqdmFyKQo+ICt7Cj4gKyAgICBzdHJ1Y3Qg c2hhZG93X3ZhciAqZW50cnk7Cj4gKyAgICB1bnNpZ25lZCBpbnQgc2xvdDsKPiArICAgIHN0cnVj dCBobGlzdF9ub2RlICpuZXh0Owo+ICsgICAgdm9pZCAqcmV0ID0gTlVMTDsKPiArCj4gKyAgICBz bG90ID0gKHVuc2lnbmVkIGxvbmcpb2JqICUgU0hBRE9XX1NMT1RTOwo+ICsKPiArICAgIHNwaW5f bG9jaygmc2hhZG93X2xvY2spOwo+ICsgICAgaGxpc3RfZm9yX2VhY2hfZW50cnkoZW50cnksIG5l eHQsICZzaGFkb3dfdGJsW3Nsb3RdLCBsaXN0KQo+ICsgICAgewo+ICsgICAgICAgIGlmICggZW50 cnktPm9iaiA9PSBvYmogJiYKPiArICAgICAgICAgICAgICFzdHJjbXAoZW50cnktPnZhciwgdmFy KSApCj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICByZXQgPSBlbnRyeS0+ZGF0YTsKPiArICAg ICAgICAgICAgYnJlYWs7Cj4gKyAgICAgICAgfQo+ICsgICAgfQo+ICsKPiArICAgIHNwaW5fdW5s b2NrKCZzaGFkb3dfbG9jayk7Cj4gKyAgICByZXR1cm4gcmV0Owo+ICt9Cj4gKwo+ICtzdGF0aWMg aW50IF9faW5pdCB4c3BsaWNlX3NoYWRvd19pbml0KHZvaWQpCj4gK3sKPiArICAgIGludCBpOwo+ ICsKPiArICAgIGZvciAoIGkgPSAwOyBpIDwgU0hBRE9XX1NMT1RTOyBpKysgKQo+ICsgICAgICAg IElOSVRfSExJU1RfSEVBRCgmc2hhZG93X3RibFtpXSk7Cj4gKwo+ICsgICAgcmV0dXJuIDA7Cj4g K30KPiArX19pbml0Y2FsbCh4c3BsaWNlX3NoYWRvd19pbml0KTsKPiBkaWZmIC0tZ2l0IGEveGVu L2luY2x1ZGUveGVuL3hzcGxpY2VfcGF0Y2guaCBiL3hlbi9pbmNsdWRlL3hlbi94c3BsaWNlX3Bh dGNoLmgKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAuLmUzZjM0NGIKPiAt LS0gL2Rldi9udWxsCj4gKysrIGIveGVuL2luY2x1ZGUveGVuL3hzcGxpY2VfcGF0Y2guaAo+IEBA IC0wLDAgKzEsMzkgQEAKPiArI2lmbmRlZiBfX1hFTl9YU1BMSUNFX1BBVENIX0hfXwo+ICsjZGVm aW5lIF9fWEVOX1hTUExJQ0VfUEFUQ0hfSF9fCj4gKwo+ICsvKgo+ICsgKiBUaGUgZm9sbG93aW5n IGRlZmluaXRpb25zIGFyZSB0byBiZSB1c2VkIGluIHBhdGNoZXMuIFRoZXkgYXJlIHRha2VuCj4g KyAqIGZyb20ga3BhdGNoLgo+ICsgKi8KPiArCj4gKy8qCj4gKyAqIHhzcGxpY2Ugc2hhZG93IHZh cmlhYmxlcwo+ICsgKgo+ICsgKiBUaGVzZSBmdW5jdGlvbnMgY2FuIGJlIHVzZWQgdG8gYWRkIG5l dyAic2hhZG93IiBmaWVsZHMgdG8gZXhpc3RpbmcgZGF0YQo+ICsgKiBzdHJ1Y3R1cmVzLiAgRm9y IGV4YW1wbGUsIHRvIGFsbG9jYXRlIGEgIm5ld3BpZCIgdmFyaWFibGUgYXNzb2NpYXRlZCB3aXRo IGFuCj4gKyAqIGluc3RhbmNlIG9mIHRhc2tfc3RydWN0LCBhbmQgYXNzaWduIGl0IGEgdmFsdWUg b2YgMTAwMDoKPiArICoKPiArICogc3RydWN0IHRhc2tfc3RydWN0ICp0c2sgPSBjdXJyZW50Owo+ ICsgKiBpbnQgKm5ld3BpZDsKPiArICogbmV3cGlkID0geHNwbGljZV9zaGFkb3dfYWxsb2ModHNr LCAibmV3cGlkIiwgc2l6ZW9mKGludCkpOwo+ICsgKiBpZiAobmV3cGlkKQo+ICsgKiAJKm5ld3Bp ZCA9IDEwMDA7Cj4gKyAqCj4gKyAqIFRvIHJldHJpZXZlIGEgcG9pbnRlciB0byB0aGUgdmFyaWFi bGU6Cj4gKyAqCj4gKyAqIHN0cnVjdCB0YXNrX3N0cnVjdCAqdHNrID0gY3VycmVudDsKPiArICog aW50ICpuZXdwaWQ7Cj4gKyAqIG5ld3BpZCA9IHhzcGxpY2Vfc2hhZG93X2dldCh0c2ssICJuZXdw aWQiKTsKPiArICogaWYgKG5ld3BpZCkKPiArICogCXByaW50aygidGFzayBuZXdwaWQgPSAlZFxu IiwgKm5ld3BpZCk7IC8vIHByaW50cyAidGFzayBuZXdwaWQgPSAxMDAwIgo+ICsgKgo+ICsgKiBU byBmcmVlIGl0Ogo+ICsgKgo+ICsgKiB4c3BsaWNlX3NoYWRvd19mcmVlKHRzaywgIm5ld3BpZCIp Owo+ICsgKi8KPiArCj4gK3ZvaWQgKnhzcGxpY2Vfc2hhZG93X2FsbG9jKGNvbnN0IHZvaWQgKm9i aiwgY29uc3QgY2hhciAqdmFyLCBzaXplX3Qgc2l6ZSk7Cj4gK3ZvaWQgeHNwbGljZV9zaGFkb3df ZnJlZShjb25zdCB2b2lkICpvYmosIGNvbnN0IGNoYXIgKnZhcik7Cj4gK3ZvaWQgKnhzcGxpY2Vf c2hhZG93X2dldChjb25zdCB2b2lkICpvYmosIGNvbnN0IGNoYXIgKnZhcik7Cj4gKwo+ICsjZW5k aWYgLyogX19YRU5fWFNQTElDRV9QQVRDSF9IX18gKi8KPiAKCkFtYXpvbiBEZXZlbG9wbWVudCBD ZW50ZXIgR2VybWFueSBHbWJICktyYXVzZW5zdHIuIDM4CjEwMTE3IEJlcmxpbgpHZXNjaGFlZnRz ZnVlaHJlcjogRHIuIFJhbGYgSGVyYnJpY2gsIENocmlzdGlhbiBTY2hsYWVnZXIKVXN0LUlEOiBE RTI4OTIzNzg3OQpFaW5nZXRyYWdlbiBhbSBBbXRzZ2VyaWNodCBDaGFybG90dGVuYnVyZyBIUkIg MTQ5MTczIEIKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9s aXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=