xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, David Vrabel <david.vrabel@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCHv1] CA-201372: x86: don't flush the whole cache when changing cachability
Date: Wed, 9 Mar 2016 18:46:23 +0000	[thread overview]
Message-ID: <56E06F7F.4000200@citrix.com> (raw)
In-Reply-To: <56E04E1002000078000DAE65@prv-mh.provo.novell.com>

On 09/03/16 15:23, Jan Beulich wrote:
> 
> And there's a second issue here: map_pages_to_xen() updates
> the idle page tables, only part of which is actually in use on a
> huge machine in the context of a PV guest, so the above is also
> risking a #PF on a guest address for the CLFLUSH. Setting the
> new flag only when the virtual address the mapping of which
> gets changed is within
> [DIRECTMAP_VIRT_START, HYPERVISOR_VIRT_END) would
> seem an acceptable assumption: We know we're never changing
> the VFN <-> PFN relationship inside the 1:1 mapping.

Andrew suggested [DIRECTMAP_VIRT_START, DIRECTMAP_VIRT_END) which makes
more sense to me.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-03-09 18:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08 18:44 [PATCHv1] CA-201372: x86: don't flush the whole cache when changing cachability David Vrabel
2016-03-09 13:32 ` David Vrabel
2016-03-09 14:01 ` Jan Beulich
2016-03-09 14:36   ` David Vrabel
2016-03-09 14:52     ` Jan Beulich
2016-03-09 15:23       ` Jan Beulich
2016-03-09 18:46         ` David Vrabel [this message]
2016-03-10  7:43           ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E06F7F.4000200@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).