From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: julien.grall@arm.com, sstabellini@kernel.org,
xen-devel@lists.xen.org, peter.huangpeng@huawei.com,
shannon.zhao@linaro.org
Subject: Re: [PATCH] xen/arm: make the error log printk ratelimited
Date: Thu, 31 Mar 2016 17:21:40 +0800 [thread overview]
Message-ID: <56FCEC24.2060205@huawei.com> (raw)
In-Reply-To: <56FD063802000078000E1A58@prv-mh.provo.novell.com>
On 2016/3/31 17:12, Jan Beulich wrote:
>>>> On 31.03.16 at 11:05, <zhaoshenglong@huawei.com> wrote:
>> > --- a/xen/arch/arm/p2m.c
>> > +++ b/xen/arch/arm/p2m.c
>> > @@ -1284,8 +1284,9 @@ int map_dev_mmio_region(struct domain *d,
>> > res = map_mmio_regions(d, start_gfn, nr, mfn);
>> > if ( res < 0 )
>> > {
>> > - printk(XENLOG_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
>> > - start_gfn, start_gfn + nr - 1, d->domain_id);
>> > + if ( printk_ratelimit() )
>> > + printk(XENLOG_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
>> > + start_gfn, start_gfn + nr - 1, d->domain_id);
>> > return res;
>> > }
> I think this would better simply use XENLOG_G_ERR.
Ok, will update.
Thanks,
--
Shannon
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-03-31 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 9:05 [PATCH] xen/arm: make the error log printk ratelimited Shannon Zhao
2016-03-31 9:12 ` Jan Beulich
2016-03-31 9:21 ` Shannon Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FCEC24.2060205@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=peter.huangpeng@huawei.com \
--cc=shannon.zhao@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).