From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Philipson Subject: Re: [PATCH] blktap2: Invalid logic detecting unaligned buffers in vhd_write_block Date: Wed, 6 Apr 2016 12:51:23 -0400 Message-ID: <57053E8B.4070001@gmail.com> References: <56EB2B73.3060905@gmail.com> <20160325161106.GB21910@citrix.com> <56F56895.6040006@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: Wei Liu , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org T24gMDMvMjkvMjAxNiAwNzoyNiBBTSwgR2VvcmdlIER1bmxhcCB3cm90ZToKPiBPbiBGcmksIE1h ciAyNSwgMjAxNiBhdCA0OjM0IFBNLCBSb3NzIFBoaWxpcHNvbgo+IDxyb3NzLnBoaWxpcHNvbkBn bWFpbC5jb20+IHdyb3RlOgo+PiBPbiAwMy8yNS8yMDE2IDEyOjExIFBNLCBXZWkgTGl1IHdyb3Rl Ogo+Pj4gT24gVGh1LCBNYXIgMTcsIDIwMTYgYXQgMDY6MTA6NTlQTSAtMDQwMCwgUm9zcyBQaGls aXBzb24gd3JvdGU6Cj4+Pj4gSXQgc2VlbXMgdGhlIGxvZ2ljIGlzIG1lYW50IHRvIGRldGVjdCBz ZWN0b3IgdW5hbGlnbmVkIGJ1ZmZlcnMgZm9yIGJsb2NrCj4+Pj4gd3JpdGVzLiBUaGUgTk9UaW5n IG9mIHRoZSBsb2dpYyBpbnN0ZWFkIG1hc2tzIG9mZiBhbnkgdW5hbGlnbmVkIGJpdHMgYW5kCj4+ Pj4gYWxzbyB3b3VsZCBjYXVzZSB0aGUgZnVuY3Rpb24gdG8gYWx3YXlzIGZhaWwuIEl0IHNlZW1z IHRoZSBmdW5jdGlvbiBpcyBub3QKPj4+PiB1c2VkIGluIGFueSBvZiB0aGUgdG9vbHMgc28gdGhh dCBpcyBwcm9iYWJseSB3aHkgdGhlIHByb2JsZW0gaXMgbm90IHNlZW4uCj4+Pj4gSW4gdGhlIHZo ZF9yZWFkX2Jsb2NrIGZ1bmN0aW9uIGl0IGlzIGNvcnJlY3QuCj4+Pj4KPj4+PiBTaWduZWQtb2Zm LWJ5OiBSb3NzIFBoaWxpcHNvbiA8cm9zcy5waGlsaXBzb25AYWluZm9zZWMuY29tPgo+Pj4KPj4+ IFRoaXMgc2VlbXMgdG8gZmFsbCB1bmRlciB0b29scyB1bWJyZWxsYS4gSSd2ZSBsb29rIGF0IGJs a3RhcDIgY29kZSwKPj4+IHRoZSByZWFzb25pbmcgaXMgY29udmluY2luZyB0byBtZSBzbzoKPj4+ Cj4+PiAgIEFja2VkLWJ5OiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPgo+Pj4KPj4+IEJ1 dCBJJ3ZlIG5ldmVyIHVzZWQgYmxrdGFwMiBhbmQgd2UgZG9uJ3Qgbm9ybWFsbHkgdGVzdCBpdCBz byBJIHdvdWxkCj4+PiBhbHNvIHdhaXQgYSBiaXQgbG9uZ2VyIHRvIHNlZSBpZiBhbnlib2R5IG9i amVjdHMgdG8gdGhpcyBjaGFuZ2UuCj4+Pgo+Pj4gT09JIGlmIG5vIGNvZGUgd2FzIHVzaW5nIHRo aXMsIGhvdyBkaWQgeW91IGRpc2NvdmVyIHRoaXMgcHJvYmxlbT8KPj4KPj4gV2UgaGF2ZSBhbiBv bGQgZm9yayBvZiBibGt0YXAyIGZyb20gd2F5IGJhY2sgd2hlbi4gSSB3YXMgd29ya2luZyB0byBl eHRyYWN0IG91cgo+PiBjaGFuZ2VzIGFuZCB0dXJuIHRoZW0gaW50byBwYXRjaGVzIHNvIHdlIGNv dWxkIHJlYmFzZSBvbiB1cHN0cmVhbSBibGt0YXAyLgo+PiBTb21lb25lIGxvbmcgYWdvIGZvdW5k IHRoYXQgLSBJIGhhdmUgbm8gaWRlYSBob3cgYnV0IGl0IHdhcyBhIHZhbGlkIGZpeCBzbyBJCj4+ IHVwc3RyZWFtZWQgaXQuCj4+Cj4+IFRoZXJlIGFyZSBhIG51bWJlciBvZiBvdGhlciBvbmVzIHRo YXQgd2VyZSBmb3VuZCB0aGF0IGFyZSBzdGlsbCBpbiB1cHN0cmVhbQo+PiBibGt0YXAyIC0gSSBw bGFuIHRvIHNlbmQgdGhlbSB0b28uCj4gCj4gUm9zcywKPiAKPiBJbnN0ZWFkIG9mIGNyb3NzLXBv cnRpbmcgZml4ZXMgZnJvbSBYZW5TZXJ2ZXIncyBibGt0YXAzIHRvIHRoZQo+IGJpdHJvdHRpbmcg YmxrdGFwMiwgd291bGQgeW91IGNvbnNpZGVyIHRha2luZyB1cCBteSB3b3JrIG9uIHJlcGxhY2lu Zwo+IGJsa3RhcDIgd2l0aCBidWlsZGluZyBibGt0YXAzIGFzIGFuIGV4dGVybmFsIHByb2plY3Q/ CgpHZW9yZ2UsIGEgZmV3IHF1ZXN0aW9ucyBiZWxvdyB0byBnZXQgc3RhcnRlZC4uLgoKPiAKPiBU aGUgYmFzaWMgc2hhcGUgb2YgdGhpbmdzIHRoYXQgbmVlZCB0byBoYXBwZW4gZm9yIHRoYXQgYXJl Ogo+IAo+IDEuIEFsbG93IHFlbXUgdG8gcHJvdmlkZSBlbXVsYXRlZCBkZXZpY2VzIGZvciBkaXNr cyB3aGljaCB1c2UgaG90cGx1Zwo+IHNjcmlwdHMgKGp1c3QgY2hlY2tlZCBpbiBsYXN0IHdlZWsp Cj4gCj4gMi4gRG8gdGhlIHR3ZWFrcyBuZWNlc3NhcnkgdG8gYWxsb3cgYmxrdGFwMyB0byBiZSBi dWlsdCBhcyBhbgo+IGluZGVwZW5kZW50IHByb2plY3QgKG91dHNpZGUgdGhlIFhlblNlcnZlciBi dWlsZCBzeXN0ZW0pCgpJIGFtIG5vdCBzdXJlIHdoZXJlIHRoZSBsYXRlc3QgYW5kIGdyZWF0ZXN0 IGJsa3RhcDMgd29yayBjYW4gYmUgZm91bmQuIEkgaGF2ZQpmb3VuZCBzb21lIG9sZCByZXBvcyB0 aGF0IGhhdmUgYWN0aXZpdHkgdXAgdW50aWwgdGhlIHdvcmsgc3RvcHBlZCBvbiB0aGF0CnByb2pl Y3QgaW4gMjAxMy4gQ2FuIHlvdSBnaXZlIG1lIHNvbWUgcG9pbnRlcnMgb24gdGhpcz8KCkFsc28g aXQgc2VlbXMgdGhlIG92ZXJhbGwgaWRlYSBpcyB0byBub3QgaGF2ZSBibGt0YXAzIChvciBhbnkg YmxrdGFwKSBsaXZlIGluCnRoZSBYZW4gdHJlZSBidXQgcmF0aGVyIGJlIGV4dGVybmFsLiBXaGVy ZSB3b3VsZCBibGt0YXAzIGxpdmU/Cgo+IAo+IDMuIFN3aXRjaCBsaWJ4bCB0byB1c2UgdGhlIGFs cmVhZHktaW4tdHJlZSBibG9jay10YXAgc2NyaXB0ICh3aGljaAo+IGNhbGxzIHRhcGN0bCkgcmF0 aGVyIHRoYW4gbGlua2luZyBhZ2FpbnN0IHRoZSBibGt0YXAgbGlicmFyeS4KCkkgYmVsaWV2ZSBJ IGZvdW5kIHRoaXMgd29yazoKCmh0dHA6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9hcmNoaXZlcy9o dG1sL3hlbi1kZXZlbC8yMDE1LTA3L21zZzAwODA1Lmh0bWwKCkl0IGxvb2tzIGxpa2UgNCBvZiB0 aGUgc2V0IG1hZGUgaXQgaW4gYW5kIHBhdGNoZXMgMyAmIDUgc3RpbGwgbmVlZCB3b3JrPyBJIGNh bgpyZS1iYXNlIHRoZW0uCgo+IAo+IDQuIEFkZCBhIGJsa3RhcCB0YXJnZXQgdG8gcmFpc2luLgo+ IAo+ICMxIGlzIGRvbmUgYW5kIHdhcyBqdXN0IGNoZWNrZWQgaW4gbGFzdCB3ZWVrLiAgIzIgc2hv dWxkbid0IGJlIGEKPiB0ZXJyaWJseSBsYXJnZSBhbW91bnQgb2Ygd29yay4gIEZvciAjMywgSSd2 ZSBwb3N0ZWQgcGF0Y2hlcyBhbHJlYWR5LAo+IGFuZCBJIGNhbiBwcm9iYWJseSBkbyBhIHF1aWNr IHJlYmFzZSBmb3IgeW91IHRvIHBpY2sgdXAgaWYgeW91IHdhbnRlZC4KPiAjNCBzaG91bGRuJ3Qg YmUgdG9vIGhhcmQgb25jZSB5b3UgaGF2ZSBhbiBvdXQtb2YtdHJlZSBidWlsZCB3b3JraW5nOyBJ Cj4gY2FuIGhlbHAgd2l0aCB0aGF0IGFzIHdlbGwuCj4gCj4gSWYgd2UgdGhlbiBhZGQgdGVzdHMg Zm9yIHVwc3RyZWFtIGJsa3RhcCB0byBvc3N0ZXN0LCB0aGVuIHdlJ2xsIGNhdGNoCj4gYW55IGJy ZWFrYWdlcywgYW5kIGF1dG9tYXRpY2FsbHkgZ2V0IHVwZGF0ZXM7IGFuZCB3ZSBjYW4gZGVsZXRl IHRoZQo+IGJpdHJvdHRpbmcgYmxrdGFwMiBvdXQgb2YgdGhlIHRyZWUuCj4gCj4gV2hhdCBkbyB5 b3UgdGhpbms/Cj4gCj4gIC1HZW9yZ2UKPiAKCgotLSAKUm9zcyBQaGlsaXBzb24KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5n IGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRl dmVsCg==