xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Chong Li <lichong659@gmail.com>, xen-devel@lists.xen.org
Cc: Chong Li <chong.li@wustl.edu>,
	wei.liu2@citrix.com, george.dunlap@eu.citrix.com,
	dario.faggioli@citrix.com, ian.jackson@eu.citrix.com,
	mengxu@cis.upenn.edu, dgolomb@seas.upenn.edu
Subject: Re: [PATCH v1] libxc: fix uninitialized variable when changing rtds scheduling parameters
Date: Wed, 6 Apr 2016 21:35:50 +0100	[thread overview]
Message-ID: <57057326.4060500@citrix.com> (raw)
In-Reply-To: <1459974638-7102-1-git-send-email-lichong659@gmail.com>

On 06/04/16 21:30, Chong Li wrote:
> Commit 046c2b503a89d21b41e4d555a9f75d02af00dbc6 introduces a build
> failure: in some cases (e.g., num_vcpus <=0),
> xc_sched_rtds_vcpu_get/set returns an uninitialized variable.
>
> Fix it.
>
> Signed-off-by: Chong Li <chong.li@wustl.edu>
>
> ---
> CC: <dario.faggioli@citrix.com>
> CC: <george.dunlap@eu.citrix.com>
> CC: <dgolomb@seas.upenn.edu>
> CC: <mengxu@cis.upenn.edu>
> CC: <wei.liu2@citrix.com>
> CC: <ian.jackson@eu.citrix.com>
> CC: <lichong659@gmail.com>

LGTM.

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-06 20:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 20:30 [PATCH v1] libxc: fix uninitialized variable when changing rtds scheduling parameters Chong Li
2016-04-06 20:35 ` Andrew Cooper [this message]
2016-04-06 21:50   ` Dario Faggioli
2016-04-07 10:36   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57057326.4060500@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=chong.li@wustl.edu \
    --cc=dario.faggioli@citrix.com \
    --cc=dgolomb@seas.upenn.edu \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=lichong659@gmail.com \
    --cc=mengxu@cis.upenn.edu \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).