xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, shannon.zhao@linaro.org
Subject: Re: [for-4.7 5/5] xen/arm: acpi: Print more error messages in acpi_map_gic_cpu_interface
Date: Thu, 7 Apr 2016 20:22:07 +0800	[thread overview]
Message-ID: <570650EF.6010903@huawei.com> (raw)
In-Reply-To: <1460026796-10899-6-git-send-email-julien.grall@arm.com>



On 2016/4/7 18:59, Julien Grall wrote:
> It's helpful to spot any error without having to modify the hypervisor
> code.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
>  xen/arch/arm/acpi/boot.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c
> index 602ab39..23285f7 100644
> --- a/xen/arch/arm/acpi/boot.c
> +++ b/xen/arch/arm/acpi/boot.c
> @@ -63,7 +63,10 @@ acpi_map_gic_cpu_interface(struct acpi_madt_generic_interrupt *processor)
>  
>      total_cpus++;
>      if ( !enabled )
> +    {
> +        printk("Skipping disabled CPU entry with 0x%"PRIx64" MPIDR\n", mpidr);
>          return;
> +    }
>  
>      if ( enabled_cpus >=  NR_CPUS )
>      {
> @@ -101,7 +104,11 @@ acpi_map_gic_cpu_interface(struct acpi_madt_generic_interrupt *processor)
>      }
>  
>      if ( !acpi_psci_present() )
> +    {
> +        printk("PSCI not present, skipping CPU MPIDR 0x%"PRIx64"\n",
> +               mpidr);
>          return;
> +    }
>  
>      if ( (rc = arch_cpu_init(enabled_cpus, NULL)) < 0 )
>      {
> 

-- 
Shannon


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-07 12:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 10:59 [for-4.7 0/5] xen/arm: acpi: Bunch of fixes to use ACPI with SMP and PL011 Julien Grall
2016-04-07 10:59 ` [for-4.7 1/5] drivers/pl011: ACPI: The interrupt should always be high level triggered Julien Grall
2016-04-07 12:30   ` Shannon Zhao
2016-04-07 13:41     ` Julien Grall
2016-04-07 13:57       ` Shannon Zhao
2016-04-07 13:59         ` Julien Grall
2016-04-07 10:59 ` [for-4.7 2/5] xen/arm: acpi: The boot CPU does not always match the first entry in the MADT Julien Grall
2016-04-07 12:49   ` Shannon Zhao
2016-04-10 20:16   ` Stefano Stabellini
2016-04-07 10:59 ` [for-4.7 3/5] xen/arm: acpi: Fix SMP support when booting with ACPI Julien Grall
2016-04-07 12:20   ` Shannon Zhao
2016-04-10 20:18   ` Stefano Stabellini
2016-04-07 10:59 ` [for-4.7 4/5] xen/arm: acpi: Remove uncessary check in acpi_map_gic_cpu_interface Julien Grall
2016-04-07 12:23   ` Shannon Zhao
2016-04-10 20:19   ` Stefano Stabellini
2016-04-07 10:59 ` [for-4.7 5/5] xen/arm: acpi: Print more error messages " Julien Grall
2016-04-07 12:22   ` Shannon Zhao [this message]
2016-04-10 20:21   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570650EF.6010903@huawei.com \
    --to=zhaoshenglong@huawei.com \
    --cc=julien.grall@arm.com \
    --cc=shannon.zhao@linaro.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).