From: Bob Liu <bob.liu@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: jgross@suse.com, Ian.Jackson@citrix.com, Paul.Durrant@citrix.com,
roger.pau@citrix.com, xen-devel@lists.xen.org
Subject: Re: [RFC PATCH v2] Data integrity extension(DIX) support for xen-block
Date: Wed, 20 Apr 2016 20:08:30 +0800 [thread overview]
Message-ID: <5717713E.2020703@oracle.com> (raw)
In-Reply-To: <571744D4.7080406@citrix.com>
On 04/20/2016 04:59 PM, David Vrabel wrote:
> On 20/04/16 08:26, Bob Liu wrote:
>>
>> /*
>> + * Recognized only if "feature-data-integrity" is present in backend xenbus info.
>> + * A request with BLKIF_OP_DIX_FLAG indicates the following request is a special
>> + * request which only contains integrity-metadata segments of current request.
>> + *
>> + * If a backend does not recognize BLKIF_OP_DIX_FLAG, it should *not* create the
>> + * "feature-data-integrity" node!
>> + */
>> +#define BLKIF_OP_DIX_FLAG (0x80)
>
> This looks fine as a mechanism for actually transferring the data but
> you do need to specify:
>
> 1. The format of this DIX data. You may reference external
> specifications for this.
>
Sure!
> 2. A mechanism for reporting which DIX formats the backend supports and
> a way for the frontend to select one (if multiple are selected).
>
The "feature-data-integrity" could be extended to "unsigned int" instead of "bool",
so as to report all DIX formats backend supports.
> 3. The behaviour the frontend can expect from the backend. (e.g., if
> the frontend writes sector S with DIX data D, a read of sector S with
> complete with DIX data D).
>
Sorry, I didn't get the point of this example.
Thank you for your review!
--
Regards,
-Bob
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-20 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 7:26 [RFC PATCH v2] Data integrity extension(DIX) support for xen-block Bob Liu
2016-04-20 8:59 ` David Vrabel
2016-04-20 12:08 ` Bob Liu [this message]
2016-04-20 13:49 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5717713E.2020703@oracle.com \
--to=bob.liu@oracle.com \
--cc=Ian.Jackson@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).