xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Bob Liu <bob.liu@oracle.com>, David Vrabel <david.vrabel@citrix.com>
Cc: jgross@suse.com, Ian.Jackson@citrix.com, Paul.Durrant@citrix.com,
	xen-devel@lists.xen.org, roger.pau@citrix.com
Subject: Re: [RFC PATCH v2] Data integrity extension(DIX) support for xen-block
Date: Wed, 20 Apr 2016 14:49:06 +0100	[thread overview]
Message-ID: <571788D2.1080402@citrix.com> (raw)
In-Reply-To: <5717713E.2020703@oracle.com>

On 20/04/16 13:08, Bob Liu wrote:
> 
> 
> The "feature-data-integrity" could be extended to "unsigned int" instead of "bool",
> so as to report all DIX formats backend supports.

I think it would be preferable to have something string based.  I think
Linux reports the formats using a string encoding.  Perhaps the same
could be used.

>> 3. The behaviour the frontend can expect from the backend.  (e.g., if
>> the frontend writes sector S with DIX data D, a read of sector S with
>> complete with DIX data D).
>>
> 
> Sorry, I didn't get the point of this example.

If not sure what you're not getting.

This is the behaviour of hardware that has this feature, yes?  The block
device provided by blkback must provide the same behaviour, right?  So
this must be specified.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2016-04-20 13:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20  7:26 [RFC PATCH v2] Data integrity extension(DIX) support for xen-block Bob Liu
2016-04-20  8:59 ` David Vrabel
2016-04-20 12:08   ` Bob Liu
2016-04-20 13:49     ` David Vrabel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571788D2.1080402@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=bob.liu@oracle.com \
    --cc=jgross@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).