From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v3 5/7] xl: improve main_tmem_* return codes Date: Thu, 21 Apr 2016 10:43:02 +0100 Message-ID: <5718A0A6.2090501@citrix.com> References: <1461139444-12342-1-git-send-email-paulinaszubarczyk@gmail.com> <1461139444-12342-6-git-send-email-paulinaszubarczyk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1atB9c-0003Do-C5 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2016 09:44:08 +0000 In-Reply-To: <1461139444-12342-6-git-send-email-paulinaszubarczyk@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Paulina Szubarczyk , xen-devel@lists.xenproject.org, roger.pau@citrix.com, George.Dunlap@eu.citrix.com Cc: ian.jackson@eu.citrix.com, dario.faggioli@citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org T24gMjAvMDQvMTYgMDk6MDQsIFBhdWxpbmEgU3p1YmFyY3p5ayB3cm90ZToKPiBGdW5jdGlvbnMg bGlieGxfdG1lbV9mcmVlemUoKSwgbGlieGxfdG1lbV90aGF3KCksIGxpYnhsX3RtZW1fc2V0KCkg YW5kCj4gbGlieGxfdG1lbV9zaGFyZWRfYXV0aCgpIGxvY2F0ZWQgaW4gbGlieGwuYyBmaWxlIHJl dHVybgo+IEVSUk9SX0ZBSUwvRVJST1JfSU5WQUwgb3IgaW50ZXJuYWwgZXJyb3IgY29kZXMgZnJv bSBsaWJ4YyBsaWJyYXJ5Cj4gaW1wcm92ZSBtYWluX3RtZW1fKiByZXR1cm4gY29kZXMgYnkgcmV0 dXJuaW5nIEVYSVRfe1NVQ0NFU1MvRkFJTFVSRX0KPiBhY2NvcmRpbmdseSB0byByZXR1cm4gY29k ZXMgb2YgdGhvc2UgZnVuY3Rpb25zLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhdWxpbmEgU3p1YmFy Y3p5ayA8cGF1bGluYXN6dWJhcmN6eWtAZ21haWwuY29tPgo+IFJldmlld2VkLWJ5OiBLb25yYWQg Unplc3p1dGVrIFdpbGsgPGtvbnJhZC53aWxrQG9yYWNsZS5jb20+Cj4gUmV2aWV3ZWQtYnk6IERh cmlvIEZhZ2dpb2xpIDxkYXJpby5mYWdnaW9saUBjaXRyaXguY29tPgo+IEFja2VkLWJ5OiBSb2dl ciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KClBhdWxpbmEsCgpUaGVzZSBwYXRj aGVzIGFyZSBhbGwgYmFzaWNhbGx5IGluZGVwZW5kZW50LCByaWdodD8KCklmIHlvdSBtb3ZlIGFz IG1hbnkgb2YgdGhlIHBhdGNoZXMgd2hpY2ggaGF2ZSBzdWl0YWJsZSBBY2tlZCAvClJldmlld2Vk LWJ5J3MgdG8gdGhlIGZyb250IG9mIHRoZSBzZXJpZXMgb24gdGhlIG5leHQgaXRlcmF0aW9uLCB0 aGVuIGEKY29tbWl0dGVyIGNhbiBjaGVjayBpbiB0aGUgb25lcyB3aGljaCBhcmUgcmVhZHkgdG8g YmUgY2hlY2tlZCBpbgppbW1lZGlhdGVseSwgYW5kIHN1YnNlcXVlbnQgc2VyaWVzIChpZiBhbnkp IGNhbiBiZSBtdWNoIHNob3J0ZXIuCgpBbHRob3VnaCBhdCB0aGlzIHBvaW50IGl0J3MgbW9yZSBj b21wbGljYXRlZCBiZWNhdXNlIHRoZXkgbm93IGFsc28gbmVlZAphIHJlbGVhc2UgYWNrIHRvIGJl IGNoZWNrZWQgaW4uIDotKQoKIC1HZW9yZ2UKCj4gLS0tCj4gIHRvb2xzL2xpYnhsL3hsX2NtZGlt cGwuYyB8IDUxICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0t LQo+ICAxIGZpbGUgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL3hsX2NtZGltcGwuYyBiL3Rvb2xzL2xpYnhsL3hs X2NtZGltcGwuYwo+IGluZGV4IDZiZWYyMDEuLmQ2NDY5MjcgMTAwNjQ0Cj4gLS0tIGEvdG9vbHMv bGlieGwveGxfY21kaW1wbC5jCj4gKysrIGIvdG9vbHMvbGlieGwveGxfY21kaW1wbC5jCj4gQEAg LTc4MTcsMTEgKzc4MTcsMTEgQEAgaW50IG1haW5fdG1lbV9saXN0KGludCBhcmdjLCBjaGFyICoq YXJndikKPiAgCj4gICAgICBidWYgPSBsaWJ4bF90bWVtX2xpc3QoY3R4LCBkb21pZCwgdXNlX2xv bmcpOwo+ICAgICAgaWYgKGJ1ZiA9PSBOVUxMKQo+IC0gICAgICAgIHJldHVybiAtMTsKPiArICAg ICAgICByZXR1cm4gRVhJVF9GQUlMVVJFOwo+ICAKPiAgICAgIHByaW50ZigiJXNcbiIsIGJ1Zik7 Cj4gICAgICBmcmVlKGJ1Zik7Cj4gLSAgICByZXR1cm4gMDsKPiArICAgIHJldHVybiBFWElUX1NV Q0NFU1M7Cj4gIH0KPiAgCj4gIGludCBtYWluX3RtZW1fZnJlZXplKGludCBhcmdjLCBjaGFyICoq YXJndikKPiBAQCAtNzg0MSw3ICs3ODQxLDcgQEAgaW50IG1haW5fdG1lbV9mcmVlemUoaW50IGFy Z2MsIGNoYXIgKiphcmd2KQo+ICAgICAgaWYgKCFkb20gJiYgYWxsID09IDApIHsKPiAgICAgICAg ICBmcHJpbnRmKHN0ZGVyciwgIllvdSBtdXN0IHNwZWNpZnkgLWEgb3IgYSBkb21haW4gaWQuXG5c biIpOwo+ICAgICAgICAgIGhlbHAoInRtZW0tZnJlZXplIik7Cj4gLSAgICAgICAgcmV0dXJuIDE7 Cj4gKyAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiAgICAgIH0KPiAgCj4gICAgICBpZiAo YWxsKQo+IEBAIC03ODQ5LDggKzc4NDksMTAgQEAgaW50IG1haW5fdG1lbV9mcmVlemUoaW50IGFy Z2MsIGNoYXIgKiphcmd2KQo+ICAgICAgZWxzZQo+ICAgICAgICAgIGRvbWlkID0gZmluZF9kb21h aW4oZG9tKTsKPiAgCj4gLSAgICBsaWJ4bF90bWVtX2ZyZWV6ZShjdHgsIGRvbWlkKTsKPiAtICAg IHJldHVybiAwOwo+ICsgICAgaWYgKGxpYnhsX3RtZW1fZnJlZXplKGN0eCwgZG9taWQpIDwgMCkK PiArICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJFOwo+ICsKPiArICAgIHJldHVybiBFWElUX1NV Q0NFU1M7Cj4gIH0KPiAgCj4gIGludCBtYWluX3RtZW1fdGhhdyhpbnQgYXJnYywgY2hhciAqKmFy Z3YpCj4gQEAgLTc4NzAsNyArNzg3Miw3IEBAIGludCBtYWluX3RtZW1fdGhhdyhpbnQgYXJnYywg Y2hhciAqKmFyZ3YpCj4gICAgICBpZiAoIWRvbSAmJiBhbGwgPT0gMCkgewo+ICAgICAgICAgIGZw cmludGYoc3RkZXJyLCAiWW91IG11c3Qgc3BlY2lmeSAtYSBvciBhIGRvbWFpbiBpZC5cblxuIik7 Cj4gICAgICAgICAgaGVscCgidG1lbS10aGF3Iik7Cj4gLSAgICAgICAgcmV0dXJuIDE7Cj4gKyAg ICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiAgICAgIH0KPiAgCj4gICAgICBpZiAoYWxsKQo+ IEBAIC03ODc4LDggKzc4ODAsMTAgQEAgaW50IG1haW5fdG1lbV90aGF3KGludCBhcmdjLCBjaGFy ICoqYXJndikKPiAgICAgIGVsc2UKPiAgICAgICAgICBkb21pZCA9IGZpbmRfZG9tYWluKGRvbSk7 Cj4gIAo+IC0gICAgbGlieGxfdG1lbV90aGF3KGN0eCwgZG9taWQpOwo+IC0gICAgcmV0dXJuIDA7 Cj4gKyAgICBpZiAobGlieGxfdG1lbV90aGF3KGN0eCwgZG9taWQpIDwgMCkKPiArICAgICAgICBy ZXR1cm4gRVhJVF9GQUlMVVJFOwo+ICsKPiArICAgIHJldHVybiBFWElUX1NVQ0NFU1M7Cj4gIH0K PiAgCj4gIGludCBtYWluX3RtZW1fc2V0KGludCBhcmdjLCBjaGFyICoqYXJndikKPiBAQCAtNzg5 MCw2ICs3ODk0LDcgQEAgaW50IG1haW5fdG1lbV9zZXQoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ ICAgICAgaW50IG9wdF93ID0gMCwgb3B0X2MgPSAwLCBvcHRfcCA9IDA7Cj4gICAgICBpbnQgYWxs ID0gMDsKPiAgICAgIGludCBvcHQ7Cj4gKyAgICBpbnQgcmMgPSAwOwo+ICAKPiAgICAgIFNXSVRD SF9GT1JFQUNIX09QVChvcHQsICJhdzpjOnA6IiwgTlVMTCwgInRtZW0tc2V0IiwgMCkgewo+ICAg ICAgY2FzZSAnYSc6Cj4gQEAgLTc5MTMsNyArNzkxOCw3IEBAIGludCBtYWluX3RtZW1fc2V0KGlu dCBhcmdjLCBjaGFyICoqYXJndikKPiAgICAgIGlmICghZG9tICYmIGFsbCA9PSAwKSB7Cj4gICAg ICAgICAgZnByaW50ZihzdGRlcnIsICJZb3UgbXVzdCBzcGVjaWZ5IC1hIG9yIGEgZG9tYWluIGlk LlxuXG4iKTsKPiAgICAgICAgICBoZWxwKCJ0bWVtLXNldCIpOwo+IC0gICAgICAgIHJldHVybiAx Owo+ICsgICAgICAgIHJldHVybiBFWElUX0ZBSUxVUkU7Cj4gICAgICB9Cj4gIAo+ICAgICAgaWYg KGFsbCkKPiBAQCAtNzkyNCwxNyArNzkyOSwyMCBAQCBpbnQgbWFpbl90bWVtX3NldChpbnQgYXJn YywgY2hhciAqKmFyZ3YpCj4gICAgICBpZiAoIW9wdF93ICYmICFvcHRfYyAmJiAhb3B0X3ApIHsK PiAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIk5vIHNldCB2YWx1ZSBzcGVjaWZpZWQuXG5cbiIp Owo+ICAgICAgICAgIGhlbHAoInRtZW0tc2V0Iik7Cj4gLSAgICAgICAgcmV0dXJuIDE7Cj4gKyAg ICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiAgICAgIH0KPiAgCj4gICAgICBpZiAob3B0X3cp Cj4gLSAgICAgICAgbGlieGxfdG1lbV9zZXQoY3R4LCBkb21pZCwgIndlaWdodCIsIHdlaWdodCk7 Cj4gKyAgICAgICAgcmMgPSBsaWJ4bF90bWVtX3NldChjdHgsIGRvbWlkLCAid2VpZ2h0Iiwgd2Vp Z2h0KTsKPiAgICAgIGlmIChvcHRfYykKPiAtICAgICAgICBsaWJ4bF90bWVtX3NldChjdHgsIGRv bWlkLCAiY2FwIiwgY2FwKTsKPiArICAgICAgICByYyA9IGxpYnhsX3RtZW1fc2V0KGN0eCwgZG9t aWQsICJjYXAiLCBjYXApOwo+ICAgICAgaWYgKG9wdF9wKQo+IC0gICAgICAgIGxpYnhsX3RtZW1f c2V0KGN0eCwgZG9taWQsICJjb21wcmVzcyIsIGNvbXByZXNzKTsKPiArICAgICAgICByYyA9IGxp YnhsX3RtZW1fc2V0KGN0eCwgZG9taWQsICJjb21wcmVzcyIsIGNvbXByZXNzKTsKPiAgCj4gLSAg ICByZXR1cm4gMDsKPiArICAgIGlmIChyYyA8IDApCj4gKyAgICAgICAgcmV0dXJuIEVYSVRfRkFJ TFVSRTsKPiArCj4gKyAgICByZXR1cm4gRVhJVF9TVUNDRVNTOwo+ICB9Cj4gIAo+ICBpbnQgbWFp bl90bWVtX3NoYXJlZF9hdXRoKGludCBhcmdjLCBjaGFyICoqYXJndikKPiBAQCAtNzk2NCw3ICs3 OTcyLDcgQEAgaW50IG1haW5fdG1lbV9zaGFyZWRfYXV0aChpbnQgYXJnYywgY2hhciAqKmFyZ3Yp Cj4gICAgICBpZiAoIWRvbSAmJiBhbGwgPT0gMCkgewo+ICAgICAgICAgIGZwcmludGYoc3RkZXJy LCAiWW91IG11c3Qgc3BlY2lmeSAtYSBvciBhIGRvbWFpbiBpZC5cblxuIik7Cj4gICAgICAgICAg aGVscCgidG1lbS1zaGFyZWQtYXV0aCIpOwo+IC0gICAgICAgIHJldHVybiAxOwo+ICsgICAgICAg IHJldHVybiBFWElUX0ZBSUxVUkU7Cj4gICAgICB9Cj4gIAo+ICAgICAgaWYgKGFsbCkKPiBAQCAt Nzk3NSwxOCArNzk4MywxOSBAQCBpbnQgbWFpbl90bWVtX3NoYXJlZF9hdXRoKGludCBhcmdjLCBj aGFyICoqYXJndikKPiAgICAgIGlmICh1dWlkID09IE5VTEwgfHwgYXV0aGFyZyA9PSBOVUxMKSB7 Cj4gICAgICAgICAgZnByaW50ZihzdGRlcnIsICJObyB1dWlkIG9yIGF1dGggc3BlY2lmaWVkLlxu XG4iKTsKPiAgICAgICAgICBoZWxwKCJ0bWVtLXNoYXJlZC1hdXRoIik7Cj4gLSAgICAgICAgcmV0 dXJuIDE7Cj4gKyAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiAgICAgIH0KPiAgCj4gICAg ICBhdXRoID0gc3RydG9sKGF1dGhhcmcsICZlbmRwdHIsIDEwKTsKPiAgICAgIGlmICgqZW5kcHRy ICE9ICdcMCcpIHsKPiAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIkludmFsaWQgYXV0aCwgdmFs aWQgYXV0aCBhcmUgPDB8MT4uXG5cbiIpOwo+IC0gICAgICAgIHJldHVybiAxOwo+ICsgICAgICAg IHJldHVybiBFWElUX0ZBSUxVUkU7Cj4gICAgICB9Cj4gIAo+IC0gICAgbGlieGxfdG1lbV9zaGFy ZWRfYXV0aChjdHgsIGRvbWlkLCB1dWlkLCBhdXRoKTsKPiArICAgIGlmIChsaWJ4bF90bWVtX3No YXJlZF9hdXRoKGN0eCwgZG9taWQsIHV1aWQsIGF1dGgpIDwgMCkKPiArICAgICAgICByZXR1cm4g RVhJVF9GQUlMVVJFOwo+ICAKPiAtICAgIHJldHVybiAwOwo+ICsgICAgcmV0dXJuIEVYSVRfU1VD Q0VTUzsKPiAgfQo+ICAKPiAgaW50IG1haW5fdG1lbV9mcmVlYWJsZShpbnQgYXJnYywgY2hhciAq KmFyZ3YpCj4gQEAgLTgwMDAsMTAgKzgwMDksMTAgQEAgaW50IG1haW5fdG1lbV9mcmVlYWJsZShp bnQgYXJnYywgY2hhciAqKmFyZ3YpCj4gIAo+ICAgICAgbWIgPSBsaWJ4bF90bWVtX2ZyZWVhYmxl KGN0eCk7Cj4gICAgICBpZiAobWIgPT0gLTEpCj4gLSAgICAgICAgcmV0dXJuIC0xOwo+ICsgICAg ICAgIHJldHVybiBFWElUX0ZBSUxVUkU7Cj4gIAo+ICAgICAgcHJpbnRmKCIlZFxuIiwgbWIpOwo+ IC0gICAgcmV0dXJuIDA7Cj4gKyAgICByZXR1cm4gRVhJVF9TVUNDRVNTOwo+ICB9Cj4gIAo+ICBp bnQgbWFpbl9jcHVwb29sY3JlYXRlKGludCBhcmdjLCBjaGFyICoqYXJndikKPiAKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGlu ZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1k ZXZlbAo=