xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul.durrant@citrix.com>
Subject: Re: [PATCH 3/3] x86/vMSI-X: also snoop REP MOVS
Date: Thu, 28 Apr 2016 11:34:02 +0100	[thread overview]
Message-ID: <5721E71A.6040701@citrix.com> (raw)
In-Reply-To: <5721F90402000078000E6B1B@prv-mh.provo.novell.com>

On 28/04/16 10:50, Jan Beulich wrote:
> ... as at least certain versions of Windows use such to update the
> MSI-X table. However, to not overly complicate the logic for now
> - only EFLAGS.DF=0 is being handled,
> - only updates not crossing MSI-X table entry boundaries are handled.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

IMO, under those circumstances we should domain_crash() and be rather
loud on the console.

Perhaps in a debug build only, but this will be a very unpleasant issue
to debug for whomever finds an OS which falls into of those unhandled
situations.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-28 10:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28  9:35 [PATCH 0/3] x86/vMSI-X: further write snoop improvements Jan Beulich
2016-04-28  9:49 ` [PATCH 1/3] x86/vMSI-X: add further checks to snoop logic Jan Beulich
2016-04-28 10:22   ` Andrew Cooper
2016-04-28 10:44   ` Paul Durrant
2016-04-28  9:49 ` [PATCH 2/3] x86/vMSI-X: also snoop qword writes Jan Beulich
2016-04-28 10:27   ` Andrew Cooper
2016-04-28 10:52   ` Paul Durrant
2016-04-28  9:50 ` [PATCH 3/3] x86/vMSI-X: also snoop REP MOVS Jan Beulich
2016-04-28 10:34   ` Andrew Cooper [this message]
2016-04-28 10:44     ` Jan Beulich
2016-04-28 11:17   ` Paul Durrant
2016-04-28 11:44     ` Jan Beulich
2016-04-28 11:58       ` Paul Durrant
2016-04-28 12:30         ` Jan Beulich
2016-04-28 12:44           ` Paul Durrant
2016-04-28  9:51 ` [PATCH 0/3] x86/vMSI-X: further write snoop improvements Jan Beulich
2016-04-28 10:26   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5721E71A.6040701@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=paul.durrant@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).