From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH for 4.7 4/4] xen: adopt .deinit_pdata and
 improve timer handling
Date: Wed, 4 May 2016 16:51:17 +0100
Message-ID: <572A1A75.5090706@citrix.com>
References: <146231184906.25631.6550047090421454264.stgit@Solace.fritz.box>
 <146231201861.25631.15476137738176988146.stgit@Solace.fritz.box>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=925315fba=George.Dunlap@citrix.com>)
 id 1axz5J-0000Zx-8a
 for xen-devel@lists.xenproject.org; Wed, 04 May 2016 15:51:33 +0000
In-Reply-To: <146231201861.25631.15476137738176988146.stgit@Solace.fritz.box>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xenproject.org
Cc: Tianyang Chen <tiche@seas.upenn.edu>, Wei Liu <wei.liu2@citrix.com>, Meng Xu <mengxu@cis.upenn.edu>
List-Id: xen-devel@lists.xenproject.org

T24gMDMvMDUvMTYgMjI6NDYsIERhcmlvIEZhZ2dpb2xpIHdyb3RlOgo+IFRoZSBzY2hlZHVsaW5n
IGhvb2tzIEFQSSBpcyBub3cgdXNlZCBwcm9wZXJseSwgYW5kIG5vCj4gaW5pdGlhbGl6YXRpb24g
b3IgZGUtaW5pdGlhbGl6YXRpb24gaGFwcGVuIGluCj4gYWxsb2MvZnJlZV9wZGF0YSBhbnkgbG9u
Z2VyLgo+IAo+IEluIGZhY3QsIGp1c3QgbGlrZSBpdCBpcyBmb3IgQ3JlZGl0MiwgdGhlcmUgaXMg
bm8gcmVhbAo+IG5lZWQgZm9yIGltcGxlbWVudGluZyBhbGxvY19wZGF0YSBhbmQgZnJlZV9wZGF0
YS4KPiAKPiBUaGlzIGFsc28gbWFkZSBpdCBwb3NzaWJsZSB0byBpbXByb3ZlIHRoZSByZXBsZW5p
c2htZW50Cj4gdGltZXIgaGFuZGxpbmcgbG9naWMsIHN1Y2ggdGhhdCBub3cgdGhlIHRpbWVyIGlz
IGFsd2F5cwo+IGtlcHQgb24gb25lIG9mIHRoZSBwQ1BVIG9mIHRoZSBzY2hlZHVsZXIgaXQncyBz
ZXJ2aWNpbmcuCj4gQmVmb3JlIHRoaXMgY29tbWl0LCBpbiBmYWN0LCBldmVuIGlmIHRoZSBwQ1BV
IHdoZXJlIHRoZQo+IHRpbWVyIGhhcHBlbmVkIHRvIGJlIGluaXRpYWxpemVkIGF0IGNyZWF0aW9u
IHRpbWUgd2FzCj4gbW92ZWQgdG8gYW5vdGhlciBjcHVwb29sLCB0aGUgdGltZXIgc3RheWVkIHRo
ZXJlLAo+IHBvdGVudGlhbGx5IGluZmVyZmVhcmluZyB3aXRoIHRoZSBuZXcgc2NoZWR1bGVyIG9m
IHRoZQoKKiBpbnRlcmZlcmluZwoKPiBwQ1BVIGl0c2VsZi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBE
YXJpbyBGYWdnaW9saSA8ZGFyaW8uZmFnZ2lvbGlAY2l0cml4LmNvbT4KCkkgZG9uJ3Qga25vdyBt
dWNoIGFib3V0IHRoZSBsb2dpYywgc28gSSdsbCB3YWl0IGZvciBNZW5nIFh1IHRvIHJldmlldyBp
dC4KCiAtR2VvcmdlCgo+IC0tCj4gQ2M6IE1lbmcgWHUgPG1lbmd4dUBjaXMudXBlbm4uZWR1Pgo+
IENjOiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+Cj4gQ2M6IFRpYW55
YW5nIENoZW4gPHRpY2hlQHNlYXMudXBlbm4uZWR1Pgo+IENjOiBXZWkgTGl1IDx3ZWkubGl1MkBj
aXRyaXguY29tPgo+IC0tLQo+ICB4ZW4vY29tbW9uL3NjaGVkX3J0LmMgfCAgIDc0ICsrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5n
ZWQsIDU1IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS94
ZW4vY29tbW9uL3NjaGVkX3J0LmMgYi94ZW4vY29tbW9uL3NjaGVkX3J0LmMKPiBpbmRleCA2NzNm
YzkyLi43ZjhmNDExIDEwMDY0NAo+IC0tLSBhL3hlbi9jb21tb24vc2NoZWRfcnQuYwo+ICsrKyBi
L3hlbi9jb21tb24vc2NoZWRfcnQuYwo+IEBAIC01OTAsNiArNTkwLDEwIEBAIHJ0X2luaXQoc3Ry
dWN0IHNjaGVkdWxlciAqb3BzKQo+ICAgICAgaWYgKCBwcnYgPT0gTlVMTCApCj4gICAgICAgICAg
cmV0dXJuIC1FTk9NRU07Cj4gIAo+ICsgICAgcHJ2LT5yZXBsX3RpbWVyID0geHphbGxvYyhzdHJ1
Y3QgdGltZXIpOwo+ICsgICAgaWYgKCBwcnYtPnJlcGxfdGltZXIgPT0gTlVMTCApCj4gKyAgICAg
ICAgcmV0dXJuIC1FTk9NRU07Cj4gKwo+ICAgICAgc3Bpbl9sb2NrX2luaXQoJnBydi0+bG9jayk7
Cj4gICAgICBJTklUX0xJU1RfSEVBRCgmcHJ2LT5zZG9tKTsKPiAgICAgIElOSVRfTElTVF9IRUFE
KCZwcnYtPnJ1bnEpOwo+IEBAIC02MDAsMTIgKzYwNCw2IEBAIHJ0X2luaXQoc3RydWN0IHNjaGVk
dWxlciAqb3BzKQo+ICAKPiAgICAgIG9wcy0+c2NoZWRfZGF0YSA9IHBydjsKPiAgCj4gLSAgICAv
Kgo+IC0gICAgICogVGhlIHRpbWVyIGluaXRpYWxpemF0aW9uIHdpbGwgaGFwcGVuIGxhdGVyIHdo
ZW4KPiAtICAgICAqIHRoZSBmaXJzdCBwY3B1IGlzIGFkZGVkIHRvIHRoaXMgcG9vbCBpbiBhbGxv
Y19wZGF0YS4KPiAtICAgICAqLwo+IC0gICAgcHJ2LT5yZXBsX3RpbWVyID0gTlVMTDsKPiAtCj4g
ICAgICByZXR1cm4gMDsKPiAgfQo+ICAKPiBAQCAtNjE0LDcgKzYxMiw4IEBAIHJ0X2RlaW5pdChz
dHJ1Y3Qgc2NoZWR1bGVyICpvcHMpCj4gIHsKPiAgICAgIHN0cnVjdCBydF9wcml2YXRlICpwcnYg
PSBydF9wcml2KG9wcyk7Cj4gIAo+IC0gICAga2lsbF90aW1lcihwcnYtPnJlcGxfdGltZXIpOwo+
ICsgICAgQVNTRVJUKHBydi0+cmVwbF90aW1lci0+c3RhdHVzID09IFRJTUVSX1NUQVRVU19pbnZh
bGlkIHx8Cj4gKyAgICAgICAgICAgcHJ2LT5yZXBsX3RpbWVyLT5zdGF0dXMgPT0gVElNRVJfU1RB
VFVTX2tpbGxlZCk7Cj4gICAgICB4ZnJlZShwcnYtPnJlcGxfdGltZXIpOwo+ICAKPiAgICAgIG9w
cy0+c2NoZWRfZGF0YSA9IE5VTEw7Cj4gQEAgLTYzMiw5ICs2MzEsMTkgQEAgcnRfaW5pdF9wZGF0
YShjb25zdCBzdHJ1Y3Qgc2NoZWR1bGVyICpvcHMsIHZvaWQgKnBkYXRhLCBpbnQgY3B1KQo+ICAg
ICAgc3BpbmxvY2tfdCAqb2xkX2xvY2s7Cj4gICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOwo+ICAK
PiAtICAgIC8qIE1vdmUgdGhlIHNjaGVkdWxlciBsb2NrIHRvIG91ciBnbG9iYWwgcnVucXVldWUg
bG9jay4gICovCj4gICAgICBvbGRfbG9jayA9IHBjcHVfc2NoZWR1bGVfbG9ja19pcnFzYXZlKGNw
dSwgJmZsYWdzKTsKPiAgCj4gKyAgICAvKgo+ICsgICAgICogVElNRVJfU1RBVFVTX2ludmFsaWQg
bWVhbnMgd2UgYXJlIHRoZSBmaXJzdCBjcHUgdGhhdCBzZWVzIHRoZSB0aW1lcgo+ICsgICAgICog
YWxsb2NhdGVkIGJ1dCBub3QgaW5pdGlhbGl6ZWQsIGFuZCBzbyBpdCdzIHVwIHRvIHVzIHRvIGlu
aXRpYWxpemUgaXQuCj4gKyAgICAgKi8KPiArICAgIGlmICggcHJ2LT5yZXBsX3RpbWVyLT5zdGF0
dXMgPT0gVElNRVJfU1RBVFVTX2ludmFsaWQgKQo+ICsgICAgewo+ICsgICAgICAgIGluaXRfdGlt
ZXIocHJ2LT5yZXBsX3RpbWVyLCByZXBsX3RpbWVyX2hhbmRsZXIsICh2b2lkKikgb3BzLCBjcHUp
Owo+ICsgICAgICAgIGRwcmludGsoWEVOTE9HX0RFQlVHLCAiUlREUzogdGltZXIgaW5pdGlhbGl6
ZWQgb24gY3B1ICV1XG4iLCBjcHUpOwo+ICsgICAgfQo+ICsKPiArICAgIC8qIE1vdmUgdGhlIHNj
aGVkdWxlciBsb2NrIHRvIG91ciBnbG9iYWwgcnVucXVldWUgbG9jay4gICovCj4gICAgICBwZXJf
Y3B1KHNjaGVkdWxlX2RhdGEsIGNwdSkuc2NoZWR1bGVfbG9jayA9ICZwcnYtPmxvY2s7Cj4gIAo+
ICAgICAgLyogX05vdF8gcGNwdV9zY2hlZHVsZV91bmxvY2soKTogcGVyX2NwdSgpLnNjaGVkdWxl
X2xvY2sgY2hhbmdlZCEgKi8KPiBAQCAtNjU5LDYgKzY2OCwyMCBAQCBydF9zd2l0Y2hfc2NoZWQo
c3RydWN0IHNjaGVkdWxlciAqbmV3X29wcywgdW5zaWduZWQgaW50IGNwdSwKPiAgICAgICAqLwo+
ICAgICAgQVNTRVJUKHBlcl9jcHUoc2NoZWR1bGVfZGF0YSwgY3B1KS5zY2hlZHVsZV9sb2NrICE9
ICZwcnYtPmxvY2spOwo+ICAKPiArICAgIC8qCj4gKyAgICAgKiBJZiB3ZSBhcmUgdGhlIGFic29s
dXRlIGZpcnN0IGNwdSBiZWluZyBzd2l0Y2hlZCB0b3dhcmQgdGhpcwo+ICsgICAgICogc2NoZWR1
bGVyIChpbiB3aGljaCBjYXNlIHdlJ2xsIHNlZSBUSU1FUl9TVEFUVVNfaW52YWxpZCksIG9yIHRo
ZQo+ICsgICAgICogZmlyc3Qgb25lIHRoYXQgaXMgYWRkZWQgYmFjayB0byB0aGUgY3B1cG9vbCB0
aGF0IGhhZCBhbGwgaXRzIGNwdXMKPiArICAgICAqIHJlbW92ZWQgKGluIHdoaWNoIGNhc2Ugd2Un
bGwgc2VlIFRJTUVSX1NUQVRVU19raWxsZWQpLCBpdCdzIG91cgo+ICsgICAgICogam9iIHRvIChy
ZSlpbml0aWFsaXplIHRoZSB0aW1lci4KPiArICAgICAqLwo+ICsgICAgaWYgKCBwcnYtPnJlcGxf
dGltZXItPnN0YXR1cyA9PSBUSU1FUl9TVEFUVVNfaW52YWxpZCB8fAo+ICsgICAgICAgICBwcnYt
PnJlcGxfdGltZXItPnN0YXR1cyA9PSBUSU1FUl9TVEFUVVNfa2lsbGVkICkKPiArICAgIHsKPiAr
ICAgICAgICBpbml0X3RpbWVyKHBydi0+cmVwbF90aW1lciwgcmVwbF90aW1lcl9oYW5kbGVyLCAo
dm9pZCopIG5ld19vcHMsIGNwdSk7Cj4gKyAgICAgICAgZHByaW50ayhYRU5MT0dfREVCVUcsICJS
VERTOiB0aW1lciBpbml0aWFsaXplZCBvbiBjcHUgJXVcbiIsIGNwdSk7Cj4gKyAgICB9Cj4gKwo+
ICAgICAgaWRsZV92Y3B1W2NwdV0tPnNjaGVkX3ByaXYgPSB2ZGF0YTsKPiAgICAgIHBlcl9jcHUo
c2NoZWR1bGVyLCBjcHUpID0gbmV3X29wczsKPiAgICAgIHBlcl9jcHUoc2NoZWR1bGVfZGF0YSwg
Y3B1KS5zY2hlZF9wcml2ID0gTlVMTDsgLyogbm8gcGRhdGEgKi8KPiBAQCAtNjcyLDIzICs2OTUs
MzYgQEAgcnRfc3dpdGNoX3NjaGVkKHN0cnVjdCBzY2hlZHVsZXIgKm5ld19vcHMsIHVuc2lnbmVk
IGludCBjcHUsCj4gICAgICBwZXJfY3B1KHNjaGVkdWxlX2RhdGEsIGNwdSkuc2NoZWR1bGVfbG9j
ayA9ICZwcnYtPmxvY2s7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkICoKPiAtcnRfYWxsb2NfcGRh
dGEoY29uc3Qgc3RydWN0IHNjaGVkdWxlciAqb3BzLCBpbnQgY3B1KQo+ICtzdGF0aWMgdm9pZAo+
ICtydF9kZWluaXRfcGRhdGEoY29uc3Qgc3RydWN0IHNjaGVkdWxlciAqb3BzLCB2b2lkICpwY3B1
LCBpbnQgY3B1KQo+ICB7Cj4gKyAgICB1bnNpZ25lZCBsb25nIGZsYWdzOwo+ICAgICAgc3RydWN0
IHJ0X3ByaXZhdGUgKnBydiA9IHJ0X3ByaXYob3BzKTsKPiAgCj4gLSAgICBpZiAoIHBydi0+cmVw
bF90aW1lciA9PSBOVUxMICkKPiAtICAgIHsKPiAtICAgICAgICAvKiBBbGxvY2F0ZSB0aGUgdGlt
ZXIgb24gdGhlIGZpcnN0IGNwdSBvZiB0aGlzIHBvb2wuICovCj4gLSAgICAgICAgcHJ2LT5yZXBs
X3RpbWVyID0geHphbGxvYyhzdHJ1Y3QgdGltZXIpOwo+ICsgICAgc3Bpbl9sb2NrX2lycXNhdmUo
JnBydi0+bG9jaywgZmxhZ3MpOwo+ICAKPiAtICAgICAgICBpZiAoIHBydi0+cmVwbF90aW1lciA9
PSBOVUxMICkKPiAtICAgICAgICAgICAgcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4gKyAgICBp
ZiAoIHBydi0+cmVwbF90aW1lci0+Y3B1ID09IGNwdSApCj4gKyAgICB7Cj4gKyAgICAgICAgc3Ry
dWN0IGNwdXBvb2wgKmMgPSBwZXJfY3B1KGNwdXBvb2wsIGNwdSk7Cj4gKyAgICAgICAgdW5zaWdu
ZWQgaW50IG5ld19jcHUgPSBjcHVtYXNrX2N5Y2xlKGNwdSwgY3B1cG9vbF9vbmxpbmVfY3B1bWFz
ayhjKSk7Cj4gIAo+IC0gICAgICAgIGluaXRfdGltZXIocHJ2LT5yZXBsX3RpbWVyLCByZXBsX3Rp
bWVyX2hhbmRsZXIsICh2b2lkICopb3BzLCBjcHUpOwo+ICsgICAgICAgIC8qCj4gKyAgICAgICAg
ICogTWFrZSBzdXJlIHRoZSB0aW1lciBydW4gb24gb25lIG9mIHRoZSBjcHVzIHRoYXQgYXJlIHN0
aWxsIGF2YWlsYWJsZQo+ICsgICAgICAgICAqIHRvIHRoaXMgc2NoZWR1bGVyLiBJZiB0aGVyZSBh
cmVuJ3QgYW55IGxlZnQsIGl0IG1lYW5zIGl0J3MgdGhlIHRpbWUKPiArICAgICAgICAgKiB0byBq
dXN0IGtpbGwgaXQuCj4gKyAgICAgICAgICovCj4gKyAgICAgICAgaWYgKCBuZXdfY3B1ID49IG5y
X2NwdV9pZHMgKQo+ICsgICAgICAgIHsKPiArICAgICAgICAgICAga2lsbF90aW1lcihwcnYtPnJl
cGxfdGltZXIpOwo+ICsgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19ERUJVRywgIlJURFM6IHRp
bWVyIGtpbGxlZCBvbiBjcHUgJWRcbiIsIGNwdSk7Cj4gKyAgICAgICAgfQo+ICsgICAgICAgIGVs
c2UKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIG1pZ3JhdGVfdGltZXIocHJ2LT5yZXBsX3Rp
bWVyLCBuZXdfY3B1KTsKPiArICAgICAgICB9Cj4gICAgICB9Cj4gIAo+IC0gICAgcmV0dXJuIE5V
TEw7Cj4gKyAgICBzcGluX3VubG9ja19pcnFyZXN0b3JlKCZwcnYtPmxvY2ssIGZsYWdzKTsKPiAg
fQo+ICAKPiAgc3RhdGljIHZvaWQgKgo+IEBAIC0xNDMzLDkgKzE0NjksOSBAQCBzdGF0aWMgY29u
c3Qgc3RydWN0IHNjaGVkdWxlciBzY2hlZF9ydGRzX2RlZiA9IHsKPiAgICAgIC5kdW1wX3NldHRp
bmdzICA9IHJ0X2R1bXAsCj4gICAgICAuaW5pdCAgICAgICAgICAgPSBydF9pbml0LAo+ICAgICAg
LmRlaW5pdCAgICAgICAgID0gcnRfZGVpbml0LAo+IC0gICAgLmFsbG9jX3BkYXRhICAgID0gcnRf
YWxsb2NfcGRhdGEsCj4gICAgICAuaW5pdF9wZGF0YSAgICAgPSBydF9pbml0X3BkYXRhLAo+ICAg
ICAgLnN3aXRjaF9zY2hlZCAgID0gcnRfc3dpdGNoX3NjaGVkLAo+ICsgICAgLmRlaW5pdF9wZGF0
YSAgID0gcnRfZGVpbml0X3BkYXRhLAo+ICAgICAgLmFsbG9jX2RvbWRhdGEgID0gcnRfYWxsb2Nf
ZG9tZGF0YSwKPiAgICAgIC5mcmVlX2RvbWRhdGEgICA9IHJ0X2ZyZWVfZG9tZGF0YSwKPiAgICAg
IC5pbml0X2RvbWFpbiAgICA9IHJ0X2RvbV9pbml0LAo+IAoKCl9fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRl
dmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==