From: Julien Grall <julien.grall@arm.com>
To: Peng Fan <van.freenix@gmail.com>
Cc: sstabellini@kernel.org, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm: mm: fix nr_second calculation in setup_frametable_mappings
Date: Thu, 12 May 2016 13:07:42 +0100 [thread overview]
Message-ID: <5734720E.7010706@arm.com> (raw)
In-Reply-To: <20160512113034.GA3060@linux-7smt.suse>
On 12/05/16 12:30, Peng Fan wrote:
> Hi Julien,
>
> On Thu, May 12, 2016 at 11:48:30AM +0100, Julien Grall wrote:
>> Hi Peng,
>>
>> On 12/05/16 07:36, Peng Fan wrote:
>>> To ARM64, "frametable_size >> SECOND_SHIFT" means the number
>>> of second level entries, not the number of second level pages.
>>>
>>> "DIV_ROUND_UP(frametable_size >> SECOND_SHIFT, LPAE_ENTRIES)"
>>> is the correct way to calculate the second level pages needed
>>> for frametable mapping.
>>
>> Good catch!
>>
>>> Signed-off-by: Peng Fan <van.freenix@gmail.com>
>>> Cc: Stefano Stabellini <sstabellini@kernel.org>
>>> Cc: Julien Grall <julien.grall@arm.com>
>>> ---
>>> xen/arch/arm/mm.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
>>> index 0a4f845..7c7f8e9 100644
>>> --- a/xen/arch/arm/mm.c
>>> +++ b/xen/arch/arm/mm.c
>>> @@ -767,7 +767,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe)
>>> base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 32<<(20-12));
>>>
>>> #ifdef CONFIG_ARM_64
>>> - nr_second = frametable_size >> SECOND_SHIFT;
>>> + nr_second = DIV_ROUND_UP(frametable_size >> SECOND_SHIFT, LPAE_ENTRIES);
>>
>>
>> I think the following would be clearer:
>>
>> ROUNDUP(frametable_size, FIRST_SIZE) >> FIRST_SHIFT;
>
> Agree.
>
>>
>> This would also benefit a comment to explain that second level of page table
>> are populating.
>
> Do you mean I need to add a comment for the upper code?
Yes.
>
> For the commit log, I would like to change to this:
> "
> To ARM64, "frametable_size >> SECOND_SHIFT" means the number
On ARM64,
s/means/computes/
> of second level entries, not the number of second level pages.
>
> "ROUNDUP(frametable_size, FIRST_SIZE) >> FIRST_SHIFT" which means
s/means/computes/
> the number of the first level entries(the number of second level pages),
missing space after "entries"
> is the correct one that should be used.
> "
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-05-12 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 6:36 [PATCH] xen/arm: mm: fix nr_second calculation in setup_frametable_mappings Peng Fan
2016-05-12 10:48 ` Julien Grall
2016-05-12 11:30 ` Peng Fan
2016-05-12 12:07 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5734720E.7010706@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=van.freenix@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).