Re: [PATCH v4 0/3] usb, xen: add pvUSB backend

[Juergen Gross <jgross@suse.com>]

On 12/05/16 15:52, Gerd Hoffmann wrote:
> On Do, 2016-05-12 at 07:47 +0200, Juergen Gross wrote:
>> This series adds a Xen pvUSB backend driver to qemu. USB devices
>> connected to the host can be passed through to a Xen guest. The
>> devices are specified via Xenstore. Access to the devices is done
>> via host-libusb.c
>>
>> I've tested the backend with various USB devices (memory sticks,
>> keyboard, ...).
> 
> Doesn't pass scripts/checkpatch.pl:

Aargh! Sorry for that. Will send V5 soon.


Juergen

> 
> Applying: xen: write information about supported backends
> === checkpatch complains ===
> WARNING: line over 80 characters
> #14: FILE: hw/xen/xen_backend.c:49:
> +static QTAILQ_HEAD(xs_dirs_head, xs_dirs) xs_cleanup =
> QTAILQ_HEAD_INITIALIZER(xs_cleanup);
> 
> ERROR: space required after that close brace '}'
> #53: FILE: hw/xen/xen_backend.c:109:
> +        }};
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #85: FILE: hw/xen/xen_backend.c:785:
> +    snprintf(path, sizeof (path), "device-model/%u/backends/%s",
> xen_domid,
> 
> total: 1 errors, 2 warnings, 161 lines checked
> 
> cheers,
>   Gerd
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel