From: George Dunlap <george.dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Subject: Re: [PATCH] x86/PoD: skip eager reclaim when possible
Date: Thu, 12 May 2016 15:40:41 +0100 [thread overview]
Message-ID: <573495E9.8020304@citrix.com> (raw)
In-Reply-To: <573201D202000078000EA201@prv-mh.provo.novell.com>
On 10/05/16 14:44, Jan Beulich wrote:
> Reclaiming pages is pointless when the cache can already satisfy all
> outstanding PoD entries, and doing reclaims in that case can be very
> harmful to performance when that memory gets used by the guest, but
> only to store zeroes there.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Sorry for the delay. Just one question...
>
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -1027,7 +1027,6 @@ static void pod_eager_record(struct p2m_
> {
> struct pod_mrp_list *mrp = &p2m->pod.mrp;
>
> - ASSERT(mrp->list[mrp->idx] == INVALID_GFN);
> ASSERT(gfn != INVALID_GFN);
What's this for?
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-12 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 13:44 [PATCH] x86/PoD: skip eager reclaim when possible Jan Beulich
2016-05-10 13:49 ` Jan Beulich
2016-05-10 14:18 ` Wei Liu
2016-05-10 13:50 ` Andrew Cooper
2016-05-10 14:27 ` Jan Beulich
2016-05-12 14:40 ` George Dunlap [this message]
2016-05-12 15:08 ` Jan Beulich
2016-05-12 15:19 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573495E9.8020304@citrix.com \
--to=george.dunlap@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).