Re: [PATCH RFC 13/18] xen: introduce and use 'dom0_rambase_pfn' setting for kernel Dom0

[Julien Grall <julien.grall@arm.com>]

Hi Jan,

On 19/05/16 10:41, Jan Beulich wrote:
>>>> On 18.05.16 at 18:32, <andrii.anisov@globallogic.com> wrote:
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -27,6 +27,9 @@
>>   static unsigned int __initdata opt_dom0_max_vcpus;
>>   integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
>>
>> +static u64 __initdata opt_dom0_rambase_pfn = 0;
>> +integer_param("dom0_rambase_pfn", opt_dom0_rambase_pfn);
>
> Any addition of a command line option needs to be accompanied by
> an entry in the command line doc.
>
>> @@ -248,6 +251,8 @@ static void allocate_memory_11(struct domain *d, struct
>> kernel_info *kinfo)
>>       const unsigned int min_order = get_order_from_bytes(MB(4));
>>       struct page_info *pg;
>>       unsigned int order = get_11_allocation_size(kinfo->unassigned_mem);
>> +    u64 rambase_pfn = opt_dom0_rambase_pfn;
>
> Use of __initdata in a non-__init function.

All the functions within domain_build.c should have the attributes 
__init. However, it has been forgotten for half of them.

I am planning to send a patch to enforce it using the Makefile rules.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel