xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Doug Goldstein <cardoe@cardoe.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v4 1/6] build: convert debug to Kconfig
Date: Mon, 23 May 2016 14:19:56 +0100	[thread overview]
Message-ID: <5743037C.6050201@citrix.com> (raw)
In-Reply-To: <57431AAD02000078000EDD56@prv-mh.provo.novell.com>

On 23/05/16 13:58, Jan Beulich wrote:
>>>> On 22.05.16 at 07:01, <cardoe@cardoe.com> wrote:
>> --- /dev/null
>> +++ b/xen/Kconfig.debug
>> @@ -0,0 +1,13 @@
>> +
>> +menu "Debugging Options"
>> +
>> +config DEBUG
>> +	bool "Developer Checks"
>> +	---help---
>> +	  Enables developer checks such as asserts and extra printks, this
>> +	  option is intended for development purposes only, and not for
>> +	  production use.
> I'm not a native speaker, but it seems to me that either this wants to
> start "Enabling ..." or the first comma wants to become a stop.

The first comma should become a full stop.

Changing Enables to Enabling still results in a particularly odd sentence.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-05-23 13:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-22  5:01 [PATCH v4 0/6] Kconfig debug options Doug Goldstein
2016-05-22  5:01 ` [PATCH v4 1/6] build: convert debug to Kconfig Doug Goldstein
2016-05-22 19:04   ` Doug Goldstein
2016-05-23  8:39     ` Jan Beulich
2016-05-24  2:36       ` Doug Goldstein
2016-05-23 12:58   ` Jan Beulich
2016-05-23 13:19     ` Andrew Cooper [this message]
2016-05-24  2:32       ` Doug Goldstein
2016-05-24  1:03     ` Doug Goldstein
2016-05-24  7:09       ` Jan Beulich
2016-05-22  5:01 ` [PATCH v4 2/6] build: convert crash_debug " Doug Goldstein
2016-05-23 13:22   ` Konrad Rzeszutek Wilk
2016-05-24  2:41     ` Doug Goldstein
2016-05-22  5:01 ` [PATCH v4 3/6] build: convert verbose " Doug Goldstein
2016-05-23 13:19   ` Konrad Rzeszutek Wilk
2016-05-24  2:43     ` Doug Goldstein
2016-05-22  5:01 ` [PATCH v4 4/6] build: convert frame_pointer " Doug Goldstein
2016-05-22  5:01 ` [PATCH v4 5/6] build: convert perfc{, _arrays} " Doug Goldstein
2016-05-23 13:21   ` Konrad Rzeszutek Wilk
2016-05-22  5:01 ` [PATCH v4 6/6] build: convert lock_profile " Doug Goldstein
2016-05-23 15:53   ` Julien Grall
2016-05-24  2:50     ` Doug Goldstein
2016-05-22 11:33 ` [PATCH v4 0/6] Kconfig debug options Andrew Cooper
2016-05-23 13:23   ` Konrad Rzeszutek Wilk
2016-05-23 13:05 ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5743037C.6050201@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=cardoe@cardoe.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).