From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com,
andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com,
george.dunlap@citrix.com, xen-devel@lists.xen.org,
shannon.zhao@linaro.org
Subject: Re: [for-4.7 2/2] xen/arm: Document the behavior of XENMAPSPACE_dev_mmio
Date: Wed, 25 May 2016 15:43:37 +0100 [thread overview]
Message-ID: <5745BA19.5000604@arm.com> (raw)
In-Reply-To: <5745C16102000078000EEADF@prv-mh.provo.novell.com>
Hi Jan,
On 25/05/16 14:14, Jan Beulich wrote:
>>>> On 25.05.16 at 13:41, <julien.grall@arm.com> wrote:
>> --- a/xen/include/public/memory.h
>> +++ b/xen/include/public/memory.h
>> @@ -220,7 +220,10 @@ DEFINE_XEN_GUEST_HANDLE(xen_machphys_mapping_t);
>> #define XENMAPSPACE_gmfn_range 3 /* GMFN range, XENMEM_add_to_physmap only. */
>> #define XENMAPSPACE_gmfn_foreign 4 /* GMFN from another dom,
>> * XENMEM_add_to_physmap_batch only. */
>> -#define XENMAPSPACE_dev_mmio 5 /* device mmio region */
>> +#define XENMAPSPACE_dev_mmio 5 /* device mmio region
>> + On ARM, the region will be mapped
>> + in stage-2 using the memory attribute
>> + Device_nGnRE. */
>
> Since this is unimplemented on x86, may I suggest to make this "ARM
> only; the region will be ..."?
Sounds good.
>
> Also - is Device_nGnRE a term uniform between ARM32 and ARM64?
Actually it should be Device-nGnRE to match with the spec. This has been
introduced on Armv8. Previously for Armv7, the name was "Device",
although the behavior is exactly the same.
I could say:
"ARM only; the region will be mapped in Stage-2 using the memory
attribute 'Device-nGnRE' (previously named 'Device' on ARMv7)".
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-25 14:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 11:41 [for-4.7 0/2] xen: Julien Grall
2016-05-25 11:41 ` [for-4.7 1/2] xen: XENMEM_add_physmap_batch: Mark 'foreign_id' as reserved for dev_mmio Julien Grall
2016-05-25 13:12 ` Jan Beulich
2016-05-25 14:04 ` Wei Liu
2016-05-25 14:28 ` Julien Grall
2016-05-25 11:41 ` [for-4.7 2/2] xen/arm: Document the behavior of XENMAPSPACE_dev_mmio Julien Grall
2016-05-25 13:14 ` Jan Beulich
2016-05-25 14:43 ` Julien Grall [this message]
2016-05-25 14:53 ` Jan Beulich
2016-05-26 9:18 ` Stefano Stabellini
2016-05-26 9:28 ` Julien Grall
2016-05-25 11:42 ` xen: XENMEM_add_physmap_batch: Mark 'foreign_is' as reserved for dev_mmio (WAS Re: [for-4.7 0/2] xen:) Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5745BA19.5000604@arm.com \
--to=julien.grall@arm.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=shannon.zhao@linaro.org \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).