Re: [PATCH] arm/gic-v3: Fix driver probe fail on GICv4 hardware

[Julien Grall <julien.grall@arm.com>]

Hello Shanker,

Please mention in the title and the commit message that is patch is ACPI 
only.

On 27/05/16 00:59, Shanker Donthineni wrote:
> The current driver probe fails on hardware which has GICv4 version,
> even though it is fully compatible to GICv3. This patch fixes the
> issue by registering the same probe function for GICv4 hardware.
>
> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
> ---
>   xen/arch/arm/gic-v3.c     | 13 +++++++++++++
>   xen/include/asm-arm/gic.h |  1 +
>   2 files changed, 14 insertions(+)
>
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index a095064..594cf6e 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -1604,10 +1604,23 @@ static int __init gicv3_acpi_preinit(const void *data)
>       return 0;
>   }
>
> +static int __init gicv4_acpi_preinit(const void *data)
> +{
> +    gicv3_info.hw_version = GIC_V4;

It will crash Xen as soon as DOM0 is created (see the BUG() in 
arch_domain_create). Please test any patch before sending on the ML.

Anyway, there is no support of GICv4 in Xen. Instead Xen will drive it 
using the GICv3 driver. So the hardware version should be GIC_V3 here.

> +    register_gic_ops(&gicv3_ops);
> +
> +    return 0;
> +}
> +
>   ACPI_DEVICE_START(agicv3, "GICv3", DEVICE_GIC)
>           .class_type = ACPI_MADT_GIC_VERSION_V3,
>           .init = gicv3_acpi_preinit,
>   ACPI_DEVICE_END
> +
> +ACPI_DEVICE_START(agicv4, "GICv4", DEVICE_GIC)
> +        .class_type = ACPI_MADT_GIC_VERSION_V4,
> +        .init = gicv4_acpi_preinit,
> +ACPI_DEVICE_END
>   #endif
>
>   /*
> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
> index cd97bb2..5be814a 100644
> --- a/xen/include/asm-arm/gic.h
> +++ b/xen/include/asm-arm/gic.h
> @@ -218,6 +218,7 @@ struct gic_lr {
>   enum gic_version {
>       GIC_V2,
>       GIC_V3,
> +    GIC_V4,
>   };
>
>   extern enum gic_version gic_hw_version(void);
>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel