* [PATCH] arm/gic-v3: Fix driver probe fail on GICv4 hardware
@ 2016-05-26 23:59 Shanker Donthineni
2016-05-27 12:35 ` Julien Grall
0 siblings, 1 reply; 6+ messages in thread
From: Shanker Donthineni @ 2016-05-26 23:59 UTC (permalink / raw)
To: xen-devel
Cc: Philip Elcan, Julien Grall, Stefano Stabellini,
Shanker Donthineni, Vikram Sethi
The current driver probe fails on hardware which has GICv4 version,
even though it is fully compatible to GICv3. This patch fixes the
issue by registering the same probe function for GICv4 hardware.
Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
---
xen/arch/arm/gic-v3.c | 13 +++++++++++++
xen/include/asm-arm/gic.h | 1 +
2 files changed, 14 insertions(+)
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index a095064..594cf6e 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -1604,10 +1604,23 @@ static int __init gicv3_acpi_preinit(const void *data)
return 0;
}
+static int __init gicv4_acpi_preinit(const void *data)
+{
+ gicv3_info.hw_version = GIC_V4;
+ register_gic_ops(&gicv3_ops);
+
+ return 0;
+}
+
ACPI_DEVICE_START(agicv3, "GICv3", DEVICE_GIC)
.class_type = ACPI_MADT_GIC_VERSION_V3,
.init = gicv3_acpi_preinit,
ACPI_DEVICE_END
+
+ACPI_DEVICE_START(agicv4, "GICv4", DEVICE_GIC)
+ .class_type = ACPI_MADT_GIC_VERSION_V4,
+ .init = gicv4_acpi_preinit,
+ACPI_DEVICE_END
#endif
/*
diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
index cd97bb2..5be814a 100644
--- a/xen/include/asm-arm/gic.h
+++ b/xen/include/asm-arm/gic.h
@@ -218,6 +218,7 @@ struct gic_lr {
enum gic_version {
GIC_V2,
GIC_V3,
+ GIC_V4,
};
extern enum gic_version gic_hw_version(void);
--
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm/gic-v3: Fix driver probe fail on GICv4 hardware
2016-05-26 23:59 [PATCH] arm/gic-v3: Fix driver probe fail on GICv4 hardware Shanker Donthineni
@ 2016-05-27 12:35 ` Julien Grall
2016-05-27 13:48 ` Shanker Donthineni
0 siblings, 1 reply; 6+ messages in thread
From: Julien Grall @ 2016-05-27 12:35 UTC (permalink / raw)
To: Shanker Donthineni, xen-devel
Cc: Philip Elcan, Stefano Stabellini, Vikram Sethi
Hello Shanker,
Please mention in the title and the commit message that is patch is ACPI
only.
On 27/05/16 00:59, Shanker Donthineni wrote:
> The current driver probe fails on hardware which has GICv4 version,
> even though it is fully compatible to GICv3. This patch fixes the
> issue by registering the same probe function for GICv4 hardware.
>
> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
> ---
> xen/arch/arm/gic-v3.c | 13 +++++++++++++
> xen/include/asm-arm/gic.h | 1 +
> 2 files changed, 14 insertions(+)
>
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index a095064..594cf6e 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -1604,10 +1604,23 @@ static int __init gicv3_acpi_preinit(const void *data)
> return 0;
> }
>
> +static int __init gicv4_acpi_preinit(const void *data)
> +{
> + gicv3_info.hw_version = GIC_V4;
It will crash Xen as soon as DOM0 is created (see the BUG() in
arch_domain_create). Please test any patch before sending on the ML.
Anyway, there is no support of GICv4 in Xen. Instead Xen will drive it
using the GICv3 driver. So the hardware version should be GIC_V3 here.
> + register_gic_ops(&gicv3_ops);
> +
> + return 0;
> +}
> +
> ACPI_DEVICE_START(agicv3, "GICv3", DEVICE_GIC)
> .class_type = ACPI_MADT_GIC_VERSION_V3,
> .init = gicv3_acpi_preinit,
> ACPI_DEVICE_END
> +
> +ACPI_DEVICE_START(agicv4, "GICv4", DEVICE_GIC)
> + .class_type = ACPI_MADT_GIC_VERSION_V4,
> + .init = gicv4_acpi_preinit,
> +ACPI_DEVICE_END
> #endif
>
> /*
> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
> index cd97bb2..5be814a 100644
> --- a/xen/include/asm-arm/gic.h
> +++ b/xen/include/asm-arm/gic.h
> @@ -218,6 +218,7 @@ struct gic_lr {
> enum gic_version {
> GIC_V2,
> GIC_V3,
> + GIC_V4,
> };
>
> extern enum gic_version gic_hw_version(void);
>
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm/gic-v3: Fix driver probe fail on GICv4 hardware
2016-05-27 12:35 ` Julien Grall
@ 2016-05-27 13:48 ` Shanker Donthineni
2016-05-27 14:07 ` Julien Grall
0 siblings, 1 reply; 6+ messages in thread
From: Shanker Donthineni @ 2016-05-27 13:48 UTC (permalink / raw)
To: Julien Grall, xen-devel; +Cc: Philip Elcan, Stefano Stabellini, Vikram Sethi
Hi Julien,
On 05/27/2016 07:35 AM, Julien Grall wrote:
> Hello Shanker,
>
> Please mention in the title and the commit message that is patch is ACPI only.
>
I'll change commit text.
> On 27/05/16 00:59, Shanker Donthineni wrote:
>> The current driver probe fails on hardware which has GICv4 version,
>> even though it is fully compatible to GICv3. This patch fixes the
>> issue by registering the same probe function for GICv4 hardware.
>>
>> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
>> ---
>> xen/arch/arm/gic-v3.c | 13 +++++++++++++
>> xen/include/asm-arm/gic.h | 1 +
>> 2 files changed, 14 insertions(+)
>>
>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
>> index a095064..594cf6e 100644
>> --- a/xen/arch/arm/gic-v3.c
>> +++ b/xen/arch/arm/gic-v3.c
>> @@ -1604,10 +1604,23 @@ static int __init gicv3_acpi_preinit(const void *data)
>> return 0;
>> }
>>
>> +static int __init gicv4_acpi_preinit(const void *data)
>> +{
>> + gicv3_info.hw_version = GIC_V4;
>
> It will crash Xen as soon as DOM0 is created (see the BUG() in arch_domain_create). Please test any patch before sending on the ML.
>
> Anyway, there is no support of GICv4 in Xen. Instead Xen will drive it using the GICv3 driver. So the hardware version should be GIC_V3 here.
>
Yes, I know I am going to fix in a separate to fix dom0 boot issue some thing like below.
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 1365b4a..56a47f5 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -571,6 +571,11 @@ int arch_domain_create(struct domain *d, unsigned int domcr_flags,
d->arch.vgic.version = GIC_V3;
break;
+ case GIC_V4:
+ config->gic_version = XEN_DOMCTL_CONFIG_GIC_V3;
+ d->arch.vgic.version = GIC_V3;
+ break;
+
default:
BUG();
}
--
Shanker Donthineni
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm/gic-v3: Fix driver probe fail on GICv4 hardware
2016-05-27 13:48 ` Shanker Donthineni
@ 2016-05-27 14:07 ` Julien Grall
2016-05-27 14:31 ` Shanker Donthineni
0 siblings, 1 reply; 6+ messages in thread
From: Julien Grall @ 2016-05-27 14:07 UTC (permalink / raw)
To: Shanker Donthineni, xen-devel
Cc: Philip Elcan, Stefano Stabellini, Vikram Sethi
On 27/05/16 14:48, Shanker Donthineni wrote:
> Hi Julien,
Hello Shanker,
> On 05/27/2016 07:35 AM, Julien Grall wrote:
>> On 27/05/16 00:59, Shanker Donthineni wrote:
>>> The current driver probe fails on hardware which has GICv4 version,
>>> even though it is fully compatible to GICv3. This patch fixes the
>>> issue by registering the same probe function for GICv4 hardware.
>>>
>>> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
>>> ---
>>> xen/arch/arm/gic-v3.c | 13 +++++++++++++
>>> xen/include/asm-arm/gic.h | 1 +
>>> 2 files changed, 14 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
>>> index a095064..594cf6e 100644
>>> --- a/xen/arch/arm/gic-v3.c
>>> +++ b/xen/arch/arm/gic-v3.c
>>> @@ -1604,10 +1604,23 @@ static int __init gicv3_acpi_preinit(const void *data)
>>> return 0;
>>> }
>>>
>>> +static int __init gicv4_acpi_preinit(const void *data)
>>> +{
>>> + gicv3_info.hw_version = GIC_V4;
>>
>> It will crash Xen as soon as DOM0 is created (see the BUG() in arch_domain_create). Please test any patch before sending on the ML.
>>
>> Anyway, there is no support of GICv4 in Xen. Instead Xen will drive it using the GICv3 driver. So the hardware version should be GIC_V3 here.
>>
> Yes, I know I am going to fix in a separate to fix dom0 boot issue some thing like below.
This should have been in the same patch or before. There is no point to
have a patch adding support for GICv4 with ACPI which will lead to an
obscure crash (a BUG() rather than a panic with a nice message).
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 1365b4a..56a47f5 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -571,6 +571,11 @@ int arch_domain_create(struct domain *d, unsigned int domcr_flags,
> d->arch.vgic.version = GIC_V3;
> break;
>
> + case GIC_V4:
> + config->gic_version = XEN_DOMCTL_CONFIG_GIC_V3;
> + d->arch.vgic.version = GIC_V3;
> + break;
As mentioned in my previous mail, there is no support of GICv4 in Xen.
Although the GICv3 driver is supporting this hardware.So we should not
advertise GIC_V4 outside of the driver until Xen will get enough
knowledge of GICv4 which will require sensible change in the generic code.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm/gic-v3: Fix driver probe fail on GICv4 hardware
2016-05-27 14:07 ` Julien Grall
@ 2016-05-27 14:31 ` Shanker Donthineni
2016-05-27 15:00 ` Julien Grall
0 siblings, 1 reply; 6+ messages in thread
From: Shanker Donthineni @ 2016-05-27 14:31 UTC (permalink / raw)
To: Julien Grall, xen-devel; +Cc: Philip Elcan, Stefano Stabellini, Vikram Sethi
On 05/27/2016 09:07 AM, Julien Grall wrote:
>
>
> On 27/05/16 14:48, Shanker Donthineni wrote:
>> Hi Julien,
>
> Hello Shanker,
>
>> On 05/27/2016 07:35 AM, Julien Grall wrote:
>>> On 27/05/16 00:59, Shanker Donthineni wrote:
>>>> The current driver probe fails on hardware which has GICv4 version,
>>>> even though it is fully compatible to GICv3. This patch fixes the
>>>> issue by registering the same probe function for GICv4 hardware.
>>>>
>>>> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
>>>> ---
>>>> xen/arch/arm/gic-v3.c | 13 +++++++++++++
>>>> xen/include/asm-arm/gic.h | 1 +
>>>> 2 files changed, 14 insertions(+)
>>>>
>>>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
>>>> index a095064..594cf6e 100644
>>>> --- a/xen/arch/arm/gic-v3.c
>>>> +++ b/xen/arch/arm/gic-v3.c
>>>> @@ -1604,10 +1604,23 @@ static int __init gicv3_acpi_preinit(const void *data)
>>>> return 0;
>>>> }
>>>>
>>>> +static int __init gicv4_acpi_preinit(const void *data)
>>>> +{
>>>> + gicv3_info.hw_version = GIC_V4;
>>>
>>> It will crash Xen as soon as DOM0 is created (see the BUG() in arch_domain_create). Please test any patch before sending on the ML.
>>>
>>> Anyway, there is no support of GICv4 in Xen. Instead Xen will drive it using the GICv3 driver. So the hardware version should be GIC_V3 here.
>>>
>> Yes, I know I am going to fix in a separate to fix dom0 boot issue some thing like below.
>
> This should have been in the same patch or before. There is no point to have a patch adding support for GICv4 with ACPI which will lead to an obscure crash (a BUG() rather than a panic with a nice message).
>
Sure, I'll do it in a single patch.
>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>> index 1365b4a..56a47f5 100644
>> --- a/xen/arch/arm/domain.c
>> +++ b/xen/arch/arm/domain.c
>> @@ -571,6 +571,11 @@ int arch_domain_create(struct domain *d, unsigned int domcr_flags,
>> d->arch.vgic.version = GIC_V3;
>> break;
>>
>> + case GIC_V4:
>> + config->gic_version = XEN_DOMCTL_CONFIG_GIC_V3;
>> + d->arch.vgic.version = GIC_V3;
>> + break;
>
> As mentioned in my previous mail, there is no support of GICv4 in Xen. Although the GICv3 driver is supporting this hardware.So we should not advertise GIC_V4 outside of the driver until Xen will get enough knowledge of GICv4 which will require sensible change in the generic code.
>
GICv4 hardware is fully compatible to GICv3 and has an additional feature vLPI. We don't need any special driver or changes to current driver to support GICv4 for SPIs/LPIs in Xen just like Linux kernel.
Confused, you are expecting gic_hw_version() should return GIC version number '3' on on GICv4 hardware, right?
switch ( gic_hw_version () )
{
case GIC_V2:
config->gic_version = XEN_DOMCTL_CONFIG_GIC_V2;
d->arch.vgic.version = GIC_V2;
break;
case GIC_V3:
config->gic_version = XEN_DOMCTL_CONFIG_GIC_V3;
d->arch.vgic.version = GIC_V3;
break;
> Regards,
>
--
Shanker Donthineni
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm/gic-v3: Fix driver probe fail on GICv4 hardware
2016-05-27 14:31 ` Shanker Donthineni
@ 2016-05-27 15:00 ` Julien Grall
0 siblings, 0 replies; 6+ messages in thread
From: Julien Grall @ 2016-05-27 15:00 UTC (permalink / raw)
To: Shanker Donthineni, xen-devel
Cc: Philip Elcan, Stefano Stabellini, Vikram Sethi
Hello Shanker,
On 27/05/16 15:31, Shanker Donthineni wrote:
>>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>>> index 1365b4a..56a47f5 100644
>>> --- a/xen/arch/arm/domain.c
>>> +++ b/xen/arch/arm/domain.c
>>> @@ -571,6 +571,11 @@ int arch_domain_create(struct domain *d, unsigned int domcr_flags,
>>> d->arch.vgic.version = GIC_V3;
>>> break;
>>>
>>> + case GIC_V4:
>>> + config->gic_version = XEN_DOMCTL_CONFIG_GIC_V3;
>>> + d->arch.vgic.version = GIC_V3;
>>> + break;
>>
>> As mentioned in my previous mail, there is no support of GICv4 in Xen. Although the GICv3 driver is supporting this hardware.So we should not advertise GIC_V4 outside of the driver until Xen will get enough knowledge of GICv4 which will require sensible change in the generic code.
>>
> GICv4 hardware is fully compatible to GICv3 and has an additional feature vLPI. We don't need any special driver or changes to current driver to support GICv4 for SPIs/LPIs in Xen just like Linux kernel.
>
> Confused, you are expecting gic_hw_version() should return GIC version number '3' on on GICv4 hardware, right?
Because the function is misnamed. It returns the version of GIC
supported by the driver to find the associated vGIC. Currently we only
support GICv3 and GICv2. If other GIC version are supported, it is only
because they are compatible.
This is a choice of the driver and should not be exposed/spread outside
of the drivers until it is strictly necessary.
Anyway, Stefano may have a different opinion on this.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-27 15:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-26 23:59 [PATCH] arm/gic-v3: Fix driver probe fail on GICv4 hardware Shanker Donthineni
2016-05-27 12:35 ` Julien Grall
2016-05-27 13:48 ` Shanker Donthineni
2016-05-27 14:07 ` Julien Grall
2016-05-27 14:31 ` Shanker Donthineni
2016-05-27 15:00 ` Julien Grall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).