From: Julien Grall <julien.grall@arm.com>
To: Shanker Donthineni <shankerd@codeaurora.org>,
xen-devel <xen-devel@lists.xensource.com>
Cc: Philip Elcan <pelcan@codeaurora.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Vikram Sethi <vikrams@codeaurora.org>
Subject: Re: [PATCH] arm/gic-v3: Fix driver probe fail on GICv4 hardware
Date: Fri, 27 May 2016 16:00:59 +0100 [thread overview]
Message-ID: <5748612B.9090809@arm.com> (raw)
In-Reply-To: <57485A58.60908@codeaurora.org>
Hello Shanker,
On 27/05/16 15:31, Shanker Donthineni wrote:
>>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>>> index 1365b4a..56a47f5 100644
>>> --- a/xen/arch/arm/domain.c
>>> +++ b/xen/arch/arm/domain.c
>>> @@ -571,6 +571,11 @@ int arch_domain_create(struct domain *d, unsigned int domcr_flags,
>>> d->arch.vgic.version = GIC_V3;
>>> break;
>>>
>>> + case GIC_V4:
>>> + config->gic_version = XEN_DOMCTL_CONFIG_GIC_V3;
>>> + d->arch.vgic.version = GIC_V3;
>>> + break;
>>
>> As mentioned in my previous mail, there is no support of GICv4 in Xen. Although the GICv3 driver is supporting this hardware.So we should not advertise GIC_V4 outside of the driver until Xen will get enough knowledge of GICv4 which will require sensible change in the generic code.
>>
> GICv4 hardware is fully compatible to GICv3 and has an additional feature vLPI. We don't need any special driver or changes to current driver to support GICv4 for SPIs/LPIs in Xen just like Linux kernel.
>
> Confused, you are expecting gic_hw_version() should return GIC version number '3' on on GICv4 hardware, right?
Because the function is misnamed. It returns the version of GIC
supported by the driver to find the associated vGIC. Currently we only
support GICv3 and GICv2. If other GIC version are supported, it is only
because they are compatible.
This is a choice of the driver and should not be exposed/spread outside
of the drivers until it is strictly necessary.
Anyway, Stefano may have a different opinion on this.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-05-27 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 23:59 [PATCH] arm/gic-v3: Fix driver probe fail on GICv4 hardware Shanker Donthineni
2016-05-27 12:35 ` Julien Grall
2016-05-27 13:48 ` Shanker Donthineni
2016-05-27 14:07 ` Julien Grall
2016-05-27 14:31 ` Shanker Donthineni
2016-05-27 15:00 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5748612B.9090809@arm.com \
--to=julien.grall@arm.com \
--cc=pelcan@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=vikrams@codeaurora.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).