From: Julien Grall <julien.grall@arm.com>
To: Peng Fan <van.freenix@gmail.com>, sstabellini@kernel.org
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm64: config: correct VMAP_VIRT_END
Date: Tue, 31 May 2016 12:07:58 +0100 [thread overview]
Message-ID: <574D708E.7050208@arm.com> (raw)
In-Reply-To: <1464344590-12093-1-git-send-email-van.freenix@gmail.com>
Hi Peng,
On 27/05/16 11:23, Peng Fan wrote:
> To ARM64, we should use '(VMAP_VIRT_START + GB(1))' as VMAP_VIRT_END,
s/To/For/
> but not '(VMAP_VIRT_START + GB(1) - 1)'.
>
> Seeing 'vm_end[type] = PFN_DOWN(end - start);' in vm_init_type,
> if not correct VMAP_VIRT_END, one page is wasted.
I find difficult to parse the commit message. How about:
"xen/arm64: config: Correctly define VMAP_VIRT_END
The vmap initialization code (vm_init_type) will round down the end of
the region to a page-aligned address.
On ARM64, the default vmap region is located between 1G and 2G. Based on
the initialization code, the end address is excluded of the region.
Therefore the current definition of VMAP_VIRT_END will lead the vmap
code to not use the last 4K of the region.
Fix it by defining VMAP_VIRT_END as "VMAP_VIRT_START + GB(1)".
"
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> ---
>
> I found X86 use '(VMAP_VIRT_START + GB(64))' and ARM32 use XENHEAP_VIRT_START,
> both are aligned address. So, I think ARM64 may also need to use aligned
> address. I am not very sure (:
Correct, this should be aligned to avoid wasting a page.
>
> xen/include/asm-arm/config.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
> index 2d11b62..f92c0a0 100644
> --- a/xen/include/asm-arm/config.h
> +++ b/xen/include/asm-arm/config.h
> @@ -147,7 +147,7 @@
> #define SLOT0_ENTRY_SIZE SLOT0(1)
>
> #define VMAP_VIRT_START GB(1)
> -#define VMAP_VIRT_END (VMAP_VIRT_START + GB(1) - 1)
> +#define VMAP_VIRT_END (VMAP_VIRT_START + GB(1))
>
> #define FRAMETABLE_VIRT_START GB(32)
> #define FRAMETABLE_SIZE GB(32)
>
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-31 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 10:23 [PATCH] xen/arm64: config: correct VMAP_VIRT_END Peng Fan
2016-05-31 11:07 ` Julien Grall [this message]
2016-06-01 7:24 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574D708E.7050208@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=van.freenix@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).