From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Kang, Luwei" <luwei.kang@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "Han, Huaitong" <huaitong.han@intel.com>,
"Wang, Yong Y" <yong.y.wang@intel.com>,
"jbeulich@suse.com" <jbeulich@suse.com>
Subject: Re: [PATCH] x86/cpuid: fix dom0 crash on skylake machine
Date: Wed, 1 Jun 2016 11:57:51 +0100 [thread overview]
Message-ID: <574EBFAF.2020103@citrix.com> (raw)
In-Reply-To: <82D7661F83C1A047AF7DC287873BF1E136ABAA08@SHSMSX101.ccr.corp.intel.com>
On 01/06/16 11:54, Kang, Luwei wrote:
> Thank you Andrew Cooper, this patch indeed resolve my issue and two point need modify.
>
> The code need move ahead of "break;"
> @@ -1101,6 +1101,9 @@ void pv_cpuid(struct cpu_user_regs *regs)
> if ( !is_control_domain(currd) && !is_hardware_domain(currd) )
> cpuid_count(leaf, subleaf, &tmp, &b, &tmp, &tmp);
> break;
> +
> + a &= (uint32_t)pv_xfeature_mask;
> + d &= (uint32_t)(pv_xfeature_mask >> 32);
> }
Ah of course. That is quite a silly mistake on my behalf.
>
> extraneous space after "&".
> - sanitise_featureset(hvm_featureset);
> + sanitise_featureset(hvm_featureset, & hvm_xfeature_mask);
I had already spotted and fixed this.
I will collect all feedback and post a formal patch to the list.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-01 10:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 4:58 [PATCH] x86/cpuid: fix dom0 crash on skylake machine Luwei Kang
2016-06-01 5:54 ` Han, Huaitong
2016-06-01 8:49 ` Jan Beulich
2016-06-01 9:00 ` Han, Huaitong
2016-06-01 9:03 ` Andrew Cooper
2016-06-01 9:17 ` Jan Beulich
2016-06-01 9:34 ` Andrew Cooper
2016-06-01 9:43 ` Jan Beulich
2016-06-01 11:27 ` Andrew Cooper
2016-06-01 11:38 ` Jan Beulich
2016-06-01 11:45 ` Andrew Cooper
2016-06-01 12:01 ` Jan Beulich
2016-06-01 13:03 ` Andrew Cooper
2016-06-01 13:28 ` Jan Beulich
2016-06-02 11:12 ` Andrew Cooper
2016-06-02 11:34 ` Jan Beulich
2016-06-02 11:44 ` Andrew Cooper
2016-06-02 12:15 ` Jan Beulich
2016-06-01 9:21 ` Han, Huaitong
2016-06-01 9:30 ` Wei Liu
2016-06-01 9:45 ` Andrew Cooper
2016-06-01 10:54 ` Kang, Luwei
2016-06-01 10:57 ` Andrew Cooper [this message]
2016-06-01 9:04 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574EBFAF.2020103@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=huaitong.han@intel.com \
--cc=jbeulich@suse.com \
--cc=luwei.kang@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).