From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: andre.przywara@arm.com, wei.chen@linaro.org, wei.liu2@citrix.com,
steve.capper@arm.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 10/15] xen/arm: Detect silicon revision and set cap bits accordingly
Date: Thu, 2 Jun 2016 12:43:38 +0100 [thread overview]
Message-ID: <57501BEA.20902@arm.com> (raw)
In-Reply-To: <574ED95F.8010105@arm.com>
On 01/06/16 13:47, Julien Grall wrote:
>>>>>>> diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c
>>>>>>> index 7a1b56b..088625b 100644
>>>>>>> --- a/xen/arch/arm/cpufeature.c
>>>>>>> +++ b/xen/arch/arm/cpufeature.c
>>>>>>> @@ -24,6 +24,22 @@
>>>>>>>
>>>>>>> DECLARE_BITMAP(cpu_hwcaps, ARM_NCAPS);
>>>>>>>
>>>>>>> +void update_cpu_capabilities(const struct arm_cpu_capabilities
>>>>>>> *caps,
>>>>>>> + const char *info)
>>>>>>
>>>>>> The info parameter is unnecessary.
>>>>>
>>>>> It is used in the printk below:
>>>>>
>>>>> printk(XENLOG_INFO "%s: %s\n", info, caps[i].desc);
>>>>
>>>> I know. Couldn't you just write the message directly below? It doesn't
>>>> look like that passing around that string is adding much value to the
>>>> code.
>>>
>>> Because we will gain soon support of ARMv8.1 features which will use
>>> the same
>>> function to update the capabilities.
>>
>> In that case I'd say make this patch sane, then add a paramter when
>> ARMv8.1 features are introduced.
>
> I am not in favor of that. cpufeature.c is supposed to be an abstraction
> to be used by both the features framework and the errata framework.
>
> It sounds weird to have a message "errata:" in a file cpufeature.c.
I thought a bit more, I will move the function to cpuerrata.c for the
time being.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-02 11:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 14:17 [PATCH v2 00/15] xen/arm: Introduce alternative runtime patching for ARM64 Julien Grall
2016-05-23 14:17 ` [PATCH v2 01/15] xen/arm: Makefile: Sort the entries alphabetically Julien Grall
2016-05-23 14:17 ` [PATCH v2 02/15] xen/arm: Include the header asm-arm/system.h in asm-arm/page.h Julien Grall
2016-05-23 14:17 ` [PATCH v2 03/15] xen/arm: Add macros to handle the MIDR Julien Grall
2016-05-23 14:17 ` [PATCH v2 04/15] xen/arm: Add cpu_hwcap bitmap Julien Grall
2016-05-30 14:19 ` Stefano Stabellini
2016-05-23 14:17 ` [PATCH v2 05/15] xen/arm64: Add an helper to invalidate all instruction caches Julien Grall
2016-05-23 14:17 ` [PATCH v2 06/15] xen/arm: arm64: Move the define BRK_BUG_FRAME into a separate header Julien Grall
2016-05-23 14:17 ` [PATCH v2 07/15] xen/arm: arm64: Reserve a brk immediate to fault on purpose Julien Grall
2016-05-23 14:17 ` [PATCH v2 08/15] xen/arm: arm64: Add helpers to decode and encode branch instructions Julien Grall
2016-05-30 14:29 ` Stefano Stabellini
2016-05-23 14:17 ` [PATCH v2 09/15] xen/arm: Introduce alternative runtime patching Julien Grall
2016-05-23 14:17 ` [PATCH v2 10/15] xen/arm: Detect silicon revision and set cap bits accordingly Julien Grall
2016-05-30 15:02 ` Stefano Stabellini
2016-05-30 16:37 ` Julien Grall
2016-05-31 9:27 ` Stefano Stabellini
2016-05-31 10:36 ` Julien Grall
2016-06-01 9:46 ` Stefano Stabellini
2016-06-01 12:47 ` Julien Grall
2016-06-02 11:43 ` Julien Grall [this message]
2016-06-02 11:45 ` Julien Grall
2016-05-23 14:17 ` [PATCH v2 11/15] xen/arm: Document the errata implemented in Xen Julien Grall
2016-05-23 14:38 ` Andrew Cooper
2016-05-24 9:13 ` Julien Grall
2016-05-30 15:08 ` Stefano Stabellini
2016-05-23 14:17 ` [PATCH v2 12/15] xen/arm: arm64: Add Cortex-A53 cache errata workaround Julien Grall
2016-05-24 2:46 ` Chenxiao Zhao
2016-05-24 8:56 ` Julien Grall
2016-05-23 14:17 ` [PATCH v2 13/15] xen/arm: arm64: Add cortex-A57 erratum 832075 workaround Julien Grall
2016-05-23 14:17 ` [PATCH v2 14/15] xen/arm: traps: Don't inject a fault if the translation VA -> IPA fails Julien Grall
2016-05-30 14:50 ` Stefano Stabellini
2016-05-23 14:17 ` [PATCH v2 15/15] xen/arm: arm64: Document Cortex-A57 erratum 834220 Julien Grall
2016-05-30 15:11 ` Stefano Stabellini
2016-05-30 16:15 ` Julien Grall
2016-05-30 16:19 ` Stefano Stabellini
2016-05-30 16:33 ` Julien Grall
2016-05-31 9:34 ` Stefano Stabellini
2016-05-31 10:39 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57501BEA.20902@arm.com \
--to=julien.grall@arm.com \
--cc=andre.przywara@arm.com \
--cc=sstabellini@kernel.org \
--cc=steve.capper@arm.com \
--cc=wei.chen@linaro.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).