From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
Martin Pohlack <mpohlack@amazon.de>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 for 4.7] xen: Rename of xSplice to livepatch.
Date: Thu, 2 Jun 2016 15:58:37 +0100 [thread overview]
Message-ID: <5750499D.2020404@citrix.com> (raw)
In-Reply-To: <575063DB02000078000F1297@prv-mh.provo.novell.com>
On 02/06/16 15:50, Jan Beulich wrote:
>
>> --- a/xen/arch/arm/xsplice.c
>> +++ b/xen/arch/arm/livepatch.c
>> @@ -4,67 +4,67 @@
>> #include <xen/errno.h>
>> #include <xen/init.h>
>> #include <xen/lib.h>
>> -#include <xen/xsplice_elf.h>
>> -#include <xen/xsplice.h>
>> +#include <xen/livepatch_elf.h>
>> +#include <xen/livepatch.h>
>>
>> -void arch_xsplice_patching_enter(void)
>> +void arch_livepatching_enter(void)
> Still "patching"?
This function came from one of my additions to the series. It half of a
pair of calls around the critical region which is writing new code/data,
where CR0.WP needs tweaking.
As such, 'patching' was logically distinct from the name 'livepatch' as
the general namespace of these functions, and referred to the critical
region of actually changing live memory.
I am at a loss to suggest a better alternative.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-02 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 14:05 [PATCH v2 for 4.7] xen: Rename of xSplice to livepatch Konrad Rzeszutek Wilk
2016-06-02 14:50 ` Jan Beulich
2016-06-02 14:58 ` Andrew Cooper [this message]
2016-06-02 15:18 ` Konrad Rzeszutek Wilk
2016-06-02 15:25 ` Jan Beulich
2016-06-02 15:38 ` Konrad Rzeszutek Wilk
2016-06-02 15:50 ` Wei Liu
2016-06-02 15:16 ` Konrad Rzeszutek Wilk
2016-06-03 8:08 ` Ross Lagerwall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5750499D.2020404@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=mpohlack@amazon.de \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).