xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>,
	sstabellini@kernel.org, Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v2 2/8] xen/mm: Introduce a bunch of helpers for the typesafes mfn and gfn
Date: Mon, 20 Jun 2016 15:26:28 +0100	[thread overview]
Message-ID: <5767FD14.3090607@arm.com> (raw)
In-Reply-To: <576818EC02000078000F6E47@prv-mh.provo.novell.com>



On 20/06/16 15:25, Jan Beulich wrote:
>>>> On 20.06.16 at 15:37, <julien.grall@arm.com> wrote:
>> Those helpers will be useful to do common operations without having to
>> unbox/box manually the GFNs/MFNs.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> But - since iirc Andrew asked for it during v1 review - any particular
> reason you made these macros rather than inline functions?

No. I just forgot to address Andrew's comment. Sorry for that.

I will resend a new version of this patch.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-20 14:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 13:37 [PATCH v2 0/8] xen/arm: Use the typesafes gfn and mfn Julien Grall
2016-06-20 13:37 ` [PATCH v2 1/8] xen/arm: Rename gmfn_to_mfn to gfn_to_mfn and use gfn/mfn typesafe Julien Grall
2016-06-20 13:37 ` [PATCH v2 2/8] xen/mm: Introduce a bunch of helpers for the typesafes mfn and gfn Julien Grall
2016-06-20 14:25   ` Jan Beulich
2016-06-20 14:26     ` Julien Grall [this message]
2016-06-20 13:37 ` [PATCH v2 3/8] xen: Use typesafe gfn/mfn in guest_physmap_* helpers Julien Grall
2016-06-20 14:33   ` Jan Beulich
2016-06-20 13:37 ` [PATCH v2 4/8] xen: Use typesafe gfn in xenmem_add_to_physmap_one Julien Grall
2016-06-20 14:35   ` Jan Beulich
2016-06-20 13:37 ` [PATCH v2 5/8] xen/arm: Rename grant_table_gfpn into grant_table_gfn and use the typesafe gfn Julien Grall
2016-06-20 13:37 ` [PATCH v2 6/8] xen: Use the typesafe mfn and gfn in map_mmio_regions Julien Grall
2016-06-20 14:37   ` Julien Grall
2016-06-20 15:04   ` Jan Beulich
2016-06-20 13:37 ` [PATCH v2 7/8] xen/arm: Rework the interface of p2m_lookup and use typesafe gfn and mfn Julien Grall
2016-06-20 13:37 ` [PATCH v2 8/8] xen/arm: p2m_cache_flush: Use the correct terminology and typesafe gfn Julien Grall
2016-06-20 14:53   ` Andrew Cooper
2016-06-20 15:03     ` Julien Grall
2016-06-20 15:36       ` Andrew Cooper
2016-06-20 15:37         ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5767FD14.3090607@arm.com \
    --to=julien.grall@arm.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).