From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: map_dev_mmio_region: The iomem permission check should be done on MFN Date: Fri, 24 Jun 2016 11:29:30 +0100 Message-ID: <576D0B8A.3020007@arm.com> References: <1465905026-12887-1-git-send-email-julien.grall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1465905026-12887-1-git-send-email-julien.grall@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xen.org Cc: sstabellini@kernel.org, Shannon Zhao List-Id: xen-devel@lists.xenproject.org SGksCgpQaW5nPwoKQ2hlZXJzLAoKT24gMTQvMDYvMTYgMTI6NTAsIEp1bGllbiBHcmFsbCB3cm90 ZToKPiBUaGUgaGVscGVyIGlvbWVtX2FjY2Vzc19wZXJtaXR0ZWQgZXhwZWN0cyBNRk5zIGluIHBh cmFtZXRlcnMgYW5kIG5vdAo+IEdORnMuIFRoYW5rZnVsbHkgb25seSB0aGUgaGFyZHdhcmUgZG9t YWluIGNhbiBjYWxsIHRoaXMgZnVuY3Rpb24gYW5kCj4gaXQgd2lsbCBhbHdheXMgYmUgd2l0aCBH Rk5TID09IE1GTnMgZm9yIG5vdy4KPgo+IEFsc28sIGZpeCB0aGUgcHJpbnRmIHRvIHVzZSB0aGUg TUZOIHJhbmdlIGFuZCBub3QgdGhlIEdGTiBvbmUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKdWxpZW4g R3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgo+IENjOiBTaGFubm9uIFpoYW8gPHNoYW5ub24u emhhb0BsaW5hcm8ub3JnPgo+Cj4gLS0tCj4gICAgICBUaGlzIHBhdGNoIGlzIGEgZ29vZCBjYW5k aWRhdGUgdG8gYmFja3BvcnQgdG8gWGVuIDQuNy4gV2l0aG91dAo+ICAgICAgaXQsIHRoZSBoYXJk d2FyZSBkb21haW4gY2FuIG1hcCBhbnkgTU1JTyBiZWNhdXNlIHRoZSBwZXJtaXNzaW9uCj4gICAg ICBjaGVjayBpcyBkb25lIG9uIHRoZSBHUEZOcyBhbmQgbm90IHRoZSBNTkZzLgo+IC0tLQo+ICAg eGVuL2FyY2gvYXJtL3AybS5jIHwgNCArKy0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wMm0u YyBiL3hlbi9hcmNoL2FybS9wMm0uYwo+IGluZGV4IDZhMTljNTcuLjRjNjU0N2QgMTAwNjQ0Cj4g LS0tIGEveGVuL2FyY2gvYXJtL3AybS5jCj4gKysrIGIveGVuL2FyY2gvYXJtL3AybS5jCj4gQEAg LTEyNzUsMTQgKzEyNzUsMTQgQEAgaW50IG1hcF9kZXZfbW1pb19yZWdpb24oc3RydWN0IGRvbWFp biAqZCwKPiAgIHsKPiAgICAgICBpbnQgcmVzOwo+Cj4gLSAgICBpZiAoICEobnIgJiYgaW9tZW1f YWNjZXNzX3Blcm1pdHRlZChkLCBzdGFydF9nZm4sIHN0YXJ0X2dmbiArIG5yIC0gMSkpICkKPiAr ICAgIGlmICggIShuciAmJiBpb21lbV9hY2Nlc3NfcGVybWl0dGVkKGQsIG1mbiwgbWZuICsgbnIg LSAxKSkgKQo+ICAgICAgICAgICByZXR1cm4gMDsKPgo+ICAgICAgIHJlcyA9IG1hcF9tbWlvX3Jl Z2lvbnMoZCwgc3RhcnRfZ2ZuLCBuciwgbWZuKTsKPiAgICAgICBpZiAoIHJlcyA8IDAgKQo+ICAg ICAgIHsKPiAgICAgICAgICAgcHJpbnRrKFhFTkxPR19HX0VSUiAiVW5hYmxlIHRvIG1hcCBbJSNs eCAtICUjbHhdIGluIERvbSVkXG4iLAo+IC0gICAgICAgICAgICAgICBzdGFydF9nZm4sIHN0YXJ0 X2dmbiArIG5yIC0gMSwgZC0+ZG9tYWluX2lkKTsKPiArICAgICAgICAgICAgICAgbWZuLCBtZm4g KyBuciAtIDEsIGQtPmRvbWFpbl9pZCk7Cj4gICAgICAgICAgIHJldHVybiByZXM7Cj4gICAgICAg fQo+Cj4KCi0tIApKdWxpZW4gR3JhbGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhl bi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==