Re: [PATCH V2 10/10] arm/vgic: Change fixed number of mmio handlers to variable number

[Shanker Donthineni <shankerd@codeaurora.org>]

On 06/27/2016 08:35 AM, Julien Grall wrote:
> Hi Shanker,
>
> On 26/06/16 18:48, Shanker Donthineni wrote:
>> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
>> index 29346c6..b205461 100644
>> --- a/xen/include/asm-arm/domain.h
>> +++ b/xen/include/asm-arm/domain.h
>> @@ -111,6 +111,7 @@ struct arch_domain
>>           int nr_regions;                     /* Number of rdist regions
> */
>>           uint32_t rdist_stride;              /* Re-Distributor stride
> */
>>   #endif
>> +        uint32_t mmio_count;                /* Number of mmio handlers
> */
>
> Is it necessary to have this value part of the arch_domain? I.e Do we 
> need this value after the initialization? If not, then it might be 
> better to add a parameter to domain_vgic_register uint32_t *pointer.
>
Absolutely, we don't need this variable after the domain build process. 
I have taken this approach to avoid too many code changes. Your 
suggestion requires changes to functions vgic_v2/v3_init() prototype for 
adding a new parameter.

>>       } vgic;
>>
>>       struct vuart {
>> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
>> index fbb763a..1ce441c 100644
>> --- a/xen/include/asm-arm/vgic.h
>> +++ b/xen/include/asm-arm/vgic.h
>> @@ -307,6 +307,7 @@ extern void register_vgic_ops(struct domain *d,
> const struct vgic_ops *ops);
>>   int vgic_v2_init(struct domain *d);
>>   int vgic_v3_init(struct domain *d);
>>
>> +extern int domain_vgic_register(struct domain *d);
>>   extern int vcpu_vgic_free(struct vcpu *v);
>>   extern int vgic_to_sgi(struct vcpu *v, register_t sgir,
>>                          enum gic_sgi_mode irqmode, int virq,
>>
>
> Regards,
>

-- 
Shanker Donthineni
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel