From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shanker Donthineni Subject: Re: [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function Date: Mon, 27 Jun 2016 10:40:26 -0500 Message-ID: <577148EA.1080102@codeaurora.org> References: <1466963303-10850-1-git-send-email-shankerd@codeaurora.org> <1466963303-10850-4-git-send-email-shankerd@codeaurora.org> <57710D83.6090001@arm.com> Reply-To: shankerd@codeaurora.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <57710D83.6090001@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Julien Grall , xen-devel , Stefano Stabellini Cc: Philip Elcan , Vikram Sethi List-Id: xen-devel@lists.xenproject.org CgpPbiAwNi8yNy8yMDE2IDA2OjI2IEFNLCBKdWxpZW4gR3JhbGwgd3JvdGU6Cj4gSGkgU2hhbmtl ciwKPgo+IFRpdGxlOiBJIHRoaW5rIHlvdSB3YW50IHRvIHNheSAiTW92ZSBHSUNSLi4uIiByYXRo ZXIgdGhhbiAiRm9sZCBHSUNSLi4uIi4KPgo+IE9uIDI2LzA2LzE2IDE4OjQ4LCBTaGFua2VyIERv bnRoaW5lbmkgd3JvdGU6Cj4+IEFkZCBhIG5ldyBmdW5jdGlvbiBmb3IgcGFyc2luZyBHSUNSIHN1 YnRhYmxlIGFuZCBtb3ZlIHRoZSBjb2RlCj4KPiBBZGQgYSBuZXcgZnVuY3Rpb24gdG8gcGFyc2Ug R0lDUi4uLgo+Cj4+IHRoYXQgaXMgc3BlY2lmaWMgdG8gR0lDUiB0YWJsZSB0byBuZXcgZnVuY3Rp b24gd2l0aG91dCBjaGFuZ2luZwo+Cj4gdG8gYSBuZXcgZnVuY3Rpb24KPgo+PiB0aGUgZnVuY3Rp b24gZ2ljdjNfYWNwaV9pbml0KCkgYmVoYXZpb3IuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFNoYW5r ZXIgRG9udGhpbmVuaSA8c2hhbmtlcmRAY29kZWF1cm9yYS5vcmc+Cj4+IC0tLQo+PiBDaGFuZ2Vz IHNpbmNlIHYxOgo+PiAgICBSZW1vdmVkIHRoZSB1bm5lY2Vzc2FyeSBHSUNSIGlvcmVtYXAgb3Bl cmF0aW9uIGluc2lkZSBHSUNSIHRhYmxlCj4gcGFyc2UgY29kZS4KPj4KPj4gICB4ZW4vYXJjaC9h cm0vZ2ljLXYzLmMgfCA2MQo+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAzOSBpbnNlcnRpb25zKCspLCAyMiBk ZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9naWMtdjMuYyBiL3hl bi9hcmNoL2FybS9naWMtdjMuYwo+PiBpbmRleCA1NDJjNGYzLi4wNDcxZmVhIDEwMDY0NAo+PiAt LS0gYS94ZW4vYXJjaC9hcm0vZ2ljLXYzLmMKPj4gKysrIGIveGVuL2FyY2gvYXJtL2dpYy12My5j Cj4+IEBAIC0xMjgyLDYgKzEyODIsMTQgQEAgc3RhdGljIGludCBnaWN2M19pb21lbV9kZW55X2Fj Y2Vzcyhjb25zdCBzdHJ1Y3QKPiBkb21haW4gKmQpCj4+ICAgfQo+Pgo+PiAgICNpZmRlZiBDT05G SUdfQUNQSQo+PiArc3RhdGljIHZvaWQgX19pbml0IGdpY19hY3BpX2FkZF9yZGlzdF9yZWdpb24o dTY0IGJhc2VfYWRkciwgdTMyIHNpemUpCj4KPiBQbGVhc2UgdXNlIHBhZGRyX3QgZm9yIGJvdGgg cGFyYW1ldGVyLiBBbHNvIHRoZSBzdWZmaXggX2FkZHIgaXMgCj4gcG9pbnRsZXNzLgo+Cj4+ICt7 Cj4+ICsgICAgdW5zaWduZWQgaW50IGlkeCA9IGdpY3YzLnJkaXN0X2NvdW50Kys7Cj4+ICsKPj4g KyAgICBnaWN2My5yZGlzdF9yZWdpb25zW2lkeF0uYmFzZSA9IGJhc2VfYWRkcjsKPj4gKyAgICBn aWN2My5yZGlzdF9yZWdpb25zW2lkeF0uc2l6ZSA9IHNpemU7Cj4+ICt9Cj4+ICsKPj4gICBzdGF0 aWMgaW50IGdpY3YzX21ha2VfaHdkb21fbWFkdChjb25zdCBzdHJ1Y3QgZG9tYWluICpkLCB1MzIg b2Zmc2V0KQo+PiAgIHsKPj4gICAgICAgc3RydWN0IGFjcGlfc3VidGFibGVfaGVhZGVyICpoZWFk ZXI7Cj4+IEBAIC0xMzg3LDYgKzEzOTUsMjUgQEAgZ2ljX2FjcGlfcGFyc2VfbWFkdF9kaXN0cmli dXRvcihzdHJ1Y3QKPiBhY3BpX3N1YnRhYmxlX2hlYWRlciAqaGVhZGVyLAo+Pgo+PiAgICAgICBy ZXR1cm4gMDsKPj4gICB9Cj4+ICsKPj4gK3N0YXRpYyBpbnQgX19pbml0Cj4+ICtnaWNfYWNwaV9w YXJzZV9tYWR0X3JlZGlzdHJpYnV0b3Ioc3RydWN0IGFjcGlfc3VidGFibGVfaGVhZGVyICpoZWFk ZXIsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgdW5zaWduZWQg bG9uZyBlbmQpCj4+ICt7Cj4+ICsgICAgc3RydWN0IGFjcGlfbWFkdF9nZW5lcmljX3JlZGlzdHJp YnV0b3IgKnJkaXN0Owo+PiArCj4+ICsgICAgcmRpc3QgPSAoc3RydWN0IGFjcGlfbWFkdF9nZW5l cmljX3JlZGlzdHJpYnV0b3IgKiloZWFkZXI7Cj4+ICsgICAgaWYgKCBCQURfTUFEVF9FTlRSWShy ZGlzdCwgZW5kKSApCj4+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOwo+PiArCj4+ICsgICAgaWYg KCAhcmRpc3QtPmJhc2VfYWRkcmVzcyB8fCAhcmRpc3QtPmxlbmd0aCApCj4+ICsgICAgICAgIHJl dHVybiAtRUlOVkFMOwo+Cj4gSW4gdGhlIGNvbW1pdCBtZXNzYWdlIHlvdSBzYWlkIHRoYXQgdGhl IGJlaGF2aW9yIGlzIHVuY2hhbmdlZCwgaG93ZXZlciAKPiB0aGlzIGNoZWNrIGlzIG5vdCBwYXJ0 IG9mIHRoZSBwcmV2aW91cyBjb2RlLgo+Cj4gQW55d2F5LCBJIGRvbid0IHRoaW5rIHRoaXMgY2hl Y2sgaXMgbmVjZXNzYXJ5Lgo+Cj4+ICsKPj4gKyAgICBnaWNfYWNwaV9hZGRfcmRpc3RfcmVnaW9u KHJkaXN0LT5iYXNlX2FkZHJlc3MsIHJkaXN0LT5sZW5ndGgpOwo+PiArCj4+ICsgICAgcmV0dXJu IDA7Cj4+ICt9Cj4+ICsKPj4gICBzdGF0aWMgaW50IF9faW5pdAo+PiAgIGdpY19hY3BpX2dldF9t YWR0X3JlZGlzdHJpYnV0b3JfbnVtKHN0cnVjdCBhY3BpX3N1YnRhYmxlX2hlYWRlcgo+ICpoZWFk ZXIsCj4+IGNvbnN0IHVuc2lnbmVkIGxvbmcgZW5kKQo+PiBAQCAtMTQwMiw3ICsxNDI5LDcgQEAg c3RhdGljIHZvaWQgX19pbml0IGdpY3YzX2FjcGlfaW5pdCh2b2lkKQo+PiAgICAgICBzdHJ1Y3Qg YWNwaV90YWJsZV9oZWFkZXIgKnRhYmxlOwo+PiAgICAgICBzdHJ1Y3QgcmRpc3RfcmVnaW9uICpy ZGlzdF9yZWdzOwo+PiAgICAgICBhY3BpX3N0YXR1cyBzdGF0dXM7Cj4+IC0gICAgaW50IGNvdW50 LCBpOwo+PiArICAgIGludCBjb3VudDsKPj4KPj4gICAgICAgc3RhdHVzID0gYWNwaV9nZXRfdGFi bGUoQUNQSV9TSUdfTUFEVCwgMCwgJnRhYmxlKTsKPj4KPj4gQEAgLTE0MzMsMzcgKzE0NjAsMjcg QEAgc3RhdGljIHZvaWQgX19pbml0IGdpY3YzX2FjcGlfaW5pdCh2b2lkKQo+PiAgICAgICBpZiAo IGNvdW50IDw9IDAgKQo+PiAgICAgICAgICAgcGFuaWMoIkdJQ3YzOiBObyB2YWxpZCBHSUNSIGVu dHJpZXMgZXhpc3RzIik7Cj4+Cj4+IC0gICAgZ2ljdjMucmRpc3RfY291bnQgPSBjb3VudDsKPj4g LQo+PiAtICAgIGlmICggZ2ljdjMucmRpc3RfY291bnQgPiBNQVhfUkRJU1RfQ09VTlQgKQo+PiAr ICAgIGlmICggY291bnQgPiBNQVhfUkRJU1RfQ09VTlQgKQo+PiAgICAgICAgICAgcGFuaWMoIkdJ Q3YzOiBOdW1iZXIgb2YgcmVkaXN0cmlidXRvciByZWdpb25zIGlzIG1vcmUgdGhhbiIKPj4gICAg ICAgICAgICAgICAgICIlZCAoSW5jcmVhc2UgTUFYX1JESVNUX0NPVU5UISEpXG4iLCBNQVhfUkRJ U1RfQ09VTlQpOwo+Pgo+PiAtICAgIHJkaXN0X3JlZ3MgPSB4emFsbG9jX2FycmF5KHN0cnVjdCBy ZGlzdF9yZWdpb24sIGdpY3YzLnJkaXN0X2NvdW50KTsKPj4gKyAgICByZGlzdF9yZWdzID0geHph bGxvY19hcnJheShzdHJ1Y3QgcmRpc3RfcmVnaW9uLCBjb3VudCk7Cj4+ICAgICAgIGlmICggIXJk aXN0X3JlZ3MgKQo+PiAgICAgICAgICAgcGFuaWMoIkdJQ3YzOiBGYWlsZWQgdG8gYWxsb2NhdGUg bWVtb3J5IGZvciByZGlzdCByZWdpb25zXG4iKTsKPj4KPj4gLSAgICBmb3IgKCBpID0gMDsgaSA8 IGdpY3YzLnJkaXN0X2NvdW50OyBpKysgKQo+PiAtICAgIHsKPj4gLSAgICAgICAgc3RydWN0IGFj cGlfc3VidGFibGVfaGVhZGVyICpoZWFkZXI7Cj4+IC0gICAgICAgIHN0cnVjdCBhY3BpX21hZHRf Z2VuZXJpY19yZWRpc3RyaWJ1dG9yICpnaWNfcmRpc3Q7Cj4+IC0KPj4gLSAgICAgICAgaGVhZGVy ID0KPiBhY3BpX3RhYmxlX2dldF9lbnRyeV9tYWR0KEFDUElfTUFEVF9UWVBFX0dFTkVSSUNfUkVE SVNUUklCVVRPUiwKPj4gLSBpKTsKPj4gLSAgICAgICAgaWYgKCAhaGVhZGVyICkKPj4gLSAgICAg ICAgICAgIHBhbmljKCJHSUN2MzogQ2FuJ3QgZ2V0IEdJQ1IgZW50cnkiKTsKPj4gLQo+PiAtICAg ICAgICBnaWNfcmRpc3QgPQo+PiAtICAgICAgICAgICBjb250YWluZXJfb2YoaGVhZGVyLCBzdHJ1 Y3QgYWNwaV9tYWR0X2dlbmVyaWNfcmVkaXN0cmlidXRvciwKPiBoZWFkZXIpOwo+PiAtICAgICAg ICByZGlzdF9yZWdzW2ldLmJhc2UgPSBnaWNfcmRpc3QtPmJhc2VfYWRkcmVzczsKPj4gLSAgICAg ICAgcmRpc3RfcmVnc1tpXS5zaXplID0gZ2ljX3JkaXN0LT5sZW5ndGg7Cj4+IC0gICAgfQo+PiAr ICAgIGdpY3YzLnJkaXN0X3JlZ2lvbnMgPSByZGlzdF9yZWdzOwo+PiArCj4+ICsgICAgLyogUGFy c2UgYWx3YXlzLW9uIHBvd2VyIGRvbWFpbiBSZS1kaXN0cmlidXRvciBlbnRyaWVzICovCj4+ICsg ICAgY291bnQgPSBhY3BpX3BhcnNlX2VudHJpZXMoQUNQSV9TSUdfTUFEVCwKPj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBzaXplb2Yoc3RydWN0IGFjcGlfdGFibGVfbWFkdCksCj4+ ICsgZ2ljX2FjcGlfcGFyc2VfbWFkdF9yZWRpc3RyaWJ1dG9yLAo+IHRhYmxlLAo+PiArIEFDUElf TUFEVF9UWVBFX0dFTkVSSUNfUkVESVNUUklCVVRPUiwKPiBjb3VudCk7Cj4KPiBQbGVhc2UgdXNl IGFjcGlfdGFibGVfcGFyc2VfbWFkdCBoZXJlLgo+CgpIb3cgZG8gd2UgcGFzcyBNQURUIHRhYmxl IHBvaW50ZXIgdGhhdCB3ZSBhcmUgdXNpbmcgdG8gYSBmdW5jdGlvbiAKYWNwaV90YWJsZV9wYXJz ZV9tYWR0KCk/ICBXZSBoYXZlIGFscmVhZHkgb2J0YWluZWQgIHRoZSBNQURUIHRhYmxlIAphZGRy ZXNzIGJ5IGNhbGxpbmcgIGFjcGlfZ2V0X3RhYmxlKCkgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUg ZnVuY3Rpb24gCmdpY3YzX2FjcGlfaW5pdCgpLgoKCj4+ICsgICAgaWYgKCBjb3VudCA8PSAwICkK Pj4gKyAgICAgICAgcGFuaWMoIkdJQ3YzOiBDYW4ndCBnZXQgUmVkaXN0cmlidXRvciBlbnRyeSIp Owo+Pgo+PiAgICAgICAvKiBUaGUgdkdJQyBjb2RlIHJlcXVpcmVzIHRoZSByZWdpb24gdG8gYmUg c29ydGVkICovCj4+ICAgICAgIHNvcnQocmRpc3RfcmVncywgZ2ljdjMucmRpc3RfY291bnQsIHNp emVvZigqcmRpc3RfcmVncyksCj4gY21wX3JkaXN0LCBOVUxMKTsKPj4KPj4gLSAgICBnaWN2My5y ZGlzdF9yZWdpb25zPSByZGlzdF9yZWdzOwo+PiAtCj4+ICAgICAgIC8qIENvbGxlY3QgQ1BVIGJh c2UgYWRkcmVzc2VzICovCj4+ICAgICAgIGNvdW50ID0gYWNwaV9wYXJzZV9lbnRyaWVzKEFDUElf U0lHX01BRFQsIHNpemVvZihzdHJ1Y3QKPiBhY3BpX3RhYmxlX21hZHQpLAo+PiBnaWNfYWNwaV9w YXJzZV9tYWR0X2NwdSwgdGFibGUsCj4+Cj4KPiBSZWdhcmRzLAo+CgotLSAKU2hhbmtlciBEb250 aGluZW5pClF1YWxjb21tIFRlY2hub2xvZ2llcywgSW5jLiBvbiBiZWhhbGYgb2YgUXVhbGNvbW0g SW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4KUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4g aXMgYSBtZW1iZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sIGEgTGludXggRm91bmRhdGlvbiBDb2xs YWJvcmF0aXZlIFByb2plY3QKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3Jn Cmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=