xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Jim Fehlig <jfehlig@suse.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>,
	"Daniel P. Berrange" <berrange@redhat.com>
Cc: LibVirt Development List <libvir-list@redhat.com>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: [libvirt] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?
Date: Mon, 27 Jun 2016 10:35:05 -0600	[thread overview]
Message-ID: <577155B9.40404@suse.com> (raw)
In-Reply-To: <22385.20612.270821.529150@mariner.uk.xensource.com>

On 06/27/2016 10:12 AM, Ian Jackson wrote:
> Daniel P. Berrange writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"):
>> On Mon, Jun 27, 2016 at 04:54:35PM +0100, Ian Jackson wrote:
>>> Created the following branch refs on xenbits in the toplevel
>>> libvirt.git:
>>>
>>>   osstest/frozen/xen-4.3-testing 9a0c7f5f834185db9017c34aabc03ad99cf37bed
>>>   osstest/frozen/xen-4.4-testing 33fb8ff185846a7b4974105d2c9400690a6f95cf
>>>   osstest/frozen/xen-4.5-testing cda1cc170f07b45911b3dad03e42c8ebfc210fa1
>>>   osstest/frozen/xen-4.6-testing eac167e2610d3e59b32f7ec7ba78cbc8c420a425
>>>   osstest/frozen/xen-4.7-testing 1a41ed5af5e1704dd9b0bdca40df5c9cacbdabfc
>> How did you pick those hashes ? Would it make more sense to pick the
>> nearest libvirt release tag ? eg v1.3.2 instead of 33fb8ff18584 ?
>>
>>> These were those tested by the following `tolerable' osstest push gate
>>> flights for the corresponding Xen tree:
>>>
>>>   xen-4.3-testing 9a0c7f5f8341 86673
>>>   xen-4.4-testing 33fb8ff18584 85031
>>>   xen-4.5-testing cda1cc170f07 83135
>>>   xen-4.6-testing eac167e2610d 96031
>>>   xen-4.7-testing 1a41ed5af5e1 95728
> I picked them by searching my mail archives for osstest `tolerable'
> push gate flights - ie, passes in our CI system.
>
> That minimises the risk that the selected versions are themselves
> troublesome for some reason, needing another round of adjustment.
>
> It might indeed be better to convert them to nearby release tags.
> However:
>
> mariner:libvirt> git-describe 9a0c7f5f834185db9017c34aabc03ad99cf37bed
> v1.3.2-202-g9a0c7f5
> mariner:libvirt> git-describe 33fb8ff185846a7b4974105d2c9400690a6f95cf
> v1.3.2-rc2-1-g33fb8ff
> mariner:libvirt> git-describe cda1cc170f07b45911b3dad03e42c8ebfc210fa1
> v1.3.1-262-gcda1cc1

It seems odd that Xen 4.5 would use an older libvirt release than Xen 4.3.

> mariner:libvirt> git-describe eac167e2610d3e59b32f7ec7ba78cbc8c420a425
> v1.3.5-318-geac167e
> mariner:libvirt> git-describe 1a41ed5af5e1704dd9b0bdca40df5c9cacbdabfc
> v1.3.5-129-g1a41ed5
> mariner:libvirt>
>
> So in most cases these hashes are well away from a release tag.
>
> Does libvirt have stable release branches ?  One approach would be to
> have osstest track a suitable libvirt stable release branche for each
> Xen stable release branch.

I see Daniel already answered this question.

>
> That would involve setting up a push gate for each of the chosen
> libvirt stable branches.  That would be worthwhile if we expect those
> stable branches to acquire commits which break Xen, and which we could
> like to be told about.  But I'm not sure that's the case.

I occasionally backport Xen bug fixes to -maint branches. Cole has also grabbed 
some Xen bug fixes when making a stable release of a -maint branch. But such 
backports should be trivial and obvious bug fixes that shouldn't cause build or 
runtime breakage with Xen.

Regards,
Jim


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-06-27 16:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160405113936.GA18120@citrix.com>
2016-04-12 21:31 ` Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION? Jim Fehlig
     [not found] ` <570D6942.8020106@suse.com>
2016-04-12 22:06   ` Wei Liu
2016-04-13  9:09   ` George Dunlap
2016-04-13  9:26     ` [libvirt] " Daniel P. Berrange
     [not found]     ` <20160413092654.GE8847@redhat.com>
2016-04-13  9:50       ` George Dunlap
2016-04-13 13:28       ` Wei Liu
2016-04-13 23:44       ` Jim Fehlig
     [not found]       ` <570ED9DF.5070606@suse.com>
2016-06-27 15:33         ` Ian Jackson
2016-06-27 15:54           ` Ian Jackson
2016-06-27 16:03             ` Daniel P. Berrange
2016-06-27 16:12               ` Ian Jackson
2016-06-27 16:17                 ` Daniel P. Berrange
2016-06-27 16:35                 ` Jim Fehlig [this message]
2016-06-27 16:54                   ` Ian Jackson
2016-06-28  7:01                     ` Jan Beulich
2016-06-28 10:42                       ` Ian Jackson
2016-04-13 23:31     ` Jim Fehlig
     [not found]     ` <570ED6B4.3060102@suse.com>
2016-04-14  7:40       ` Dario Faggioli
     [not found]       ` <1460619652.13871.130.camel@citrix.com>
2016-04-14 17:59         ` Ian Jackson
2016-04-14 18:05           ` Dario Faggioli
2016-04-15  9:14           ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577155B9.40404@suse.com \
    --to=jfehlig@suse.com \
    --cc=JBeulich@suse.com \
    --cc=berrange@redhat.com \
    --cc=george.dunlap@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=libvir-list@redhat.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).