Re: [PATCH v3 00/17] Xen ARM DomU ACPI support

[Julien Grall <julien.grall@arm.com>]

Hi Shannon,

On 05/07/16 04:12, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> Note: while there are still two points (user configuration name and
> where to load the ACPI blob) which we don't reach an agreement and need
> other maintainer's opinions, but I'd like to send the updated series out
> since we could move forward and once we reach an agreement I can make
> changes.

It would have been nice to summarize the problems in the concerned 
patches to avoid having looking through all the patches in the previous 
version understanding what are the disagreements. Note that as the 
contributor of this series, I would expect you to drive the discussion 
(e.g gentle ping...).

You also did not address my concern related to require iasl even on 
platform when ACPI will not be used (such as arm32).

> This series can be fetched from:
> https://git.linaro.org/people/shannon.zhao/xen.git  domu_acpi_v3

It would have been nice to specify the dependencies and mention that
Boris's series has not yet been sent to the ML.

>
> Changes since v2:
> * return error for 32bit domain with acpi enabled
> * include actypes.h to reuse the definitions
> * rename libxl_arm_acpi.h to libxl_arm.h
> * use ACPI_MADT_ENABLED
> * rebased on top of Boris's ACPI branch to reuse mk_dsdt.c
>
> Changes since v1:
> * move ACPI tables generation codes to a new file
> * use static asl file to generate DSDT table and include processor
>    device objects
> * assign a non-RAM map for ACPI blob
> * use existing ACPI table definitions under xen/include/acpi/
> * add a configuration for user to enable/disable ACPI generation
> * calculate the ACPI table checksum
>
> Shannon Zhao (17):
>    libxl/arm: Factor out codes for generating DTB
>    libxc: Add placeholders for ACPI tables blob and size
>    libxl/arm: Add a configuration option for ARM DomU ACPI
>    libxl/arm: prepare for constructing ACPI tables
>    libxl/arm: Generate static ACPI DSDT table
>    libxl/arm: Estimate the size of ACPI tables
>    libxl/arm: Construct ACPI RSDP table
>    libxl/arm: Construct ACPI XSDT table
>    libxl/arm: Construct ACPI GTDT table
>    libxl/arm: Factor MPIDR computing codes out as a helper
>    libxl/arm: Construct ACPI MADT table
>    libxl/arm: Construct ACPI FADT table
>    libxl/arm: Construct ACPI DSDT table
>    libxl/arm: Factor finalise_one_memory_node as a gerneric function
>    libxl/arm: Add ACPI module
>    libxc/xc_dom_core: Copy ACPI tables to guest space
>    libxl/arm: Initialize domain param HVM_PARAM_CALLBACK_IRQ
>
>   docs/misc/arm/device-tree/acpi.txt |  24 +++
>   tools/libacpi/Makefile             |  15 +-
>   tools/libacpi/mk_dsdt.c            |  51 ++++--
>   tools/libxc/include/xc_dom.h       |   2 +
>   tools/libxc/xc_dom_core.c          |  51 ++++++
>   tools/libxl/Makefile               |   7 +
>   tools/libxl/libxl.h                |   5 +
>   tools/libxl/libxl_arm.c            |  86 +++++++--
>   tools/libxl/libxl_arm.h            |  44 +++++
>   tools/libxl/libxl_arm_acpi.c       | 354 +++++++++++++++++++++++++++++++++++++
>   tools/libxl/libxl_types.idl        |   1 +
>   tools/libxl/xl_cmdimpl.c           |   4 +
>   xen/include/public/arch-arm.h      |   7 +
>   13 files changed, 620 insertions(+), 31 deletions(-)
>   create mode 100644 docs/misc/arm/device-tree/acpi.txt
>   create mode 100644 tools/libxl/libxl_arm.h
>   create mode 100644 tools/libxl/libxl_arm_acpi.c
>

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel