From: Julien Grall <julien.grall@arm.com>
To: shankerd@codeaurora.org,
xen-devel <xen-devel@lists.xensource.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Philip Elcan <pelcan@codeaurora.org>,
Vikram Sethi <vikrams@codeaurora.org>,
Steve Capper <Steve.Capper@arm.com>
Subject: Re: [PATCH V3 04/10] arm/gic-v3: Parse per-cpu redistributor entry in GICC subtable
Date: Wed, 6 Jul 2016 12:30:37 +0100 [thread overview]
Message-ID: <577CEBDD.4040608@arm.com> (raw)
In-Reply-To: <57728AC5.5020700@codeaurora.org>
Hi Shanker,
On 28/06/16 15:33, Shanker Donthineni wrote:
>
>
> On 06/28/2016 08:51 AM, Shanker Donthineni wrote:
>> Hi Julien,
>>
>>
>> On 06/28/2016 05:40 AM, Julien Grall wrote:
>>> Hello Shanker,
>>>
>>> On 27/06/16 21:33, Shanker Donthineni wrote:
>>>> @@ -1397,6 +1408,36 @@ gic_acpi_parse_madt_distributor(struct
>>> acpi_subtable_header *header,
>>>> }
>>>>
>>>> static int __init
>>>> +gic_acpi_parse_cpu_redistributor(struct acpi_subtable_header *header,
>>>> + const unsigned long end)
>>>> +{
>>>> + struct acpi_madt_generic_interrupt *processor;
>>>> + u32 size;
>>>> +
>>>> + processor = (struct acpi_madt_generic_interrupt *)header;
>>>> + if ( !(processor->flags & ACPI_MADT_ENABLED) )
>>>> + return 0;
>>>
>>> You did not answer to my question on previous version of this patch.
>>> You said that "Disabled GICC entries should be skipped because its
>>> Redistributor region is not always-on power domain." However from my
>>> understanding, an usable CPU may have his Redistributor in the not
>>> always-on power domain. So the issue would the same, correct?
>>>
>>
>> The gicv3_populate_rdist() is not supposed to read GICR registers if
>> the the associated hardware GICR block is in power-off state. The CPU
>> accesses to disabled GICR region leads to either a system hang or an
>> unexpected behavior.
>>
>>
> The description of flag ACPI_MADT_ENABLED in ACPI-6.1 says "If zero,
> this processor in unusable, and the operating system support will not
> attempt to use it".
Ok. The patch looks good to me then.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-06 11:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 20:33 [PATCH V3 01/10] arm/gic-v3: Use acpi_table_parse_madt() to parse MADT subtables Shanker Donthineni
2016-06-27 20:33 ` [PATCH V3 02/10] arm/gic-v3: Do early GICD ioremap and clean up Shanker Donthineni
2016-06-27 20:33 ` [PATCH V3 03/10] arm/gic-v3: Move GICR subtable parsing into a new function Shanker Donthineni
2016-06-28 10:36 ` Julien Grall
2016-06-27 20:33 ` [PATCH V3 04/10] arm/gic-v3: Parse per-cpu redistributor entry in GICC subtable Shanker Donthineni
2016-06-28 10:40 ` Julien Grall
2016-06-28 13:51 ` Shanker Donthineni
2016-06-28 14:33 ` Shanker Donthineni
2016-07-06 11:30 ` Julien Grall [this message]
2016-07-14 14:01 ` Julien Grall
2016-06-27 20:33 ` [PATCH V3 05/10] xen/arm: vgic: Use dynamic memory allocation for vgic_rdist_region Shanker Donthineni
2016-06-28 10:42 ` Julien Grall
2016-06-27 20:33 ` [PATCH v3 06/10] arm/gic-v3: Remove an unused macro MAX_RDIST_COUNT Shanker Donthineni
2016-06-27 20:33 ` [PATCH V3 07/10] arm: vgic: Split vgic_domain_init() functionality into two functions Shanker Donthineni
2016-06-28 10:44 ` Julien Grall
2016-06-27 20:33 ` [PATCH V3 08/10] arm/io: Use separate memory allocation for mmio handlers Shanker Donthineni
2016-06-27 20:33 ` [PATCH V3 09/10] xen/arm: io: Use binary search for mmio handler lookup Shanker Donthineni
2016-06-28 10:13 ` Julien Grall
2016-06-28 10:49 ` Julien Grall
2016-06-28 13:19 ` Shanker Donthineni
2016-06-28 13:29 ` Julien Grall
2016-06-27 20:33 ` [PATCH V3 10/10] arm/vgic: Change fixed number of mmio handlers to variable number Shanker Donthineni
2016-06-28 10:30 ` [PATCH V3 01/10] arm/gic-v3: Use acpi_table_parse_madt() to parse MADT subtables Julien Grall
2016-07-14 14:18 ` Stefano Stabellini
2016-07-14 15:30 ` Shanker Donthineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577CEBDD.4040608@arm.com \
--to=julien.grall@arm.com \
--cc=Steve.Capper@arm.com \
--cc=pelcan@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=vikrams@codeaurora.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).