From: Julien Grall <julien.grall@arm.com>
To: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v5 06/14] xen: Move the hvm_start_info C representation from libxc to public/xen.h
Date: Fri, 8 Jul 2016 10:53:34 +0100 [thread overview]
Message-ID: <577F781E.1030000@arm.com> (raw)
In-Reply-To: <20160707152805.GT416@citrix.com>
Hi Wei,
On 07/07/16 16:28, Wei Liu wrote:
> On Thu, Jul 07, 2016 at 09:07:59AM -0600, Jan Beulich wrote:
>>>>> On 07.07.16 at 16:55, <wei.liu2@citrix.com> wrote:
>>> Cc HV maintainers
>>>
>>> I'm of course fine with moving this structure somewhere else.
>>>
>>> On Wed, Jun 22, 2016 at 06:15:37PM +0100, Anthony PERARD wrote:
>>>
>>>> diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h
>>>
>>>
>>> I suspect it would make more sense to move it to public/arch-x86/xen.h.
>>
>> The question is whether we really mean this to remain x86 specific:
>> The way it's now there's nothing inherently x86-ish there. But if
>> that's the plan (which the conditional around it supports) then the
>> suggested alternative resting place seems appropriate to me.
>>
>
> For one, ARM doesn't distinguish PV vs HVM vs PVH (yet). Calling it HVM
> for ARM would be wrong IMHO.
Correct, if you would have to do a comparison with x86 it would be PVH.
However, this structure looks useful only if we lack a way to describe
those parameters in the firmware. This is not the case for ARM as this
could be described easily by the device tree with the generic bindings.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-08 9:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 17:15 [PATCH v5 00/14] Load BIOS via toolstack instead of been embedded in hvmloader Anthony PERARD
2016-06-22 17:15 ` [PATCH v5 01/14] libxc: Rework extra module initialisation Anthony PERARD
2016-07-07 14:55 ` Wei Liu
2016-07-08 10:52 ` Anthony PERARD
2016-07-08 11:29 ` Wei Liu
2016-07-08 13:26 ` Anthony PERARD
2016-06-22 17:15 ` [PATCH v5 02/14] libxc: Prepare a start info structure for hvmloader Anthony PERARD
2016-06-23 14:44 ` Boris Ostrovsky
2016-06-23 16:52 ` Anthony PERARD
2016-07-07 14:55 ` Wei Liu
2016-07-08 10:55 ` Anthony PERARD
2016-06-22 17:15 ` [PATCH v5 03/14] configure: #define SEABIOS_PATH and OVMF_PATH Anthony PERARD
2016-06-22 17:15 ` [PATCH v5 04/14] firmware/makefile: install BIOS blob Anthony PERARD
2016-07-07 14:55 ` Wei Liu
2016-06-22 17:15 ` [PATCH v5 05/14] libxl: Load guest BIOS from file Anthony PERARD
2016-06-24 7:23 ` Jan Beulich
2016-06-24 14:20 ` Anthony PERARD
2016-07-07 14:55 ` Wei Liu
2016-06-22 17:15 ` [PATCH v5 06/14] xen: Move the hvm_start_info C representation from libxc to public/xen.h Anthony PERARD
2016-07-07 14:55 ` Wei Liu
2016-07-07 15:07 ` Jan Beulich
2016-07-07 15:28 ` Wei Liu
2016-07-08 9:53 ` Julien Grall [this message]
2016-07-07 15:02 ` Andrew Cooper
2016-07-07 15:09 ` Jan Beulich
2016-07-07 15:12 ` Andrew Cooper
2016-06-22 17:15 ` [PATCH v5 07/14] hvmloader: Grab the hvm_start_info pointer Anthony PERARD
2016-06-22 17:15 ` [PATCH v5 08/14] hvmloader: Locate the BIOS blob Anthony PERARD
2016-06-24 7:33 ` Jan Beulich
2016-06-24 17:02 ` Anthony PERARD
2016-06-27 7:13 ` Jan Beulich
2016-06-30 15:04 ` Anthony PERARD
2016-07-01 6:40 ` Jan Beulich
2016-06-22 17:15 ` [PATCH v5 09/14] hvmloader: Check modules whereabouts in perform_tests Anthony PERARD
2016-06-24 7:44 ` Jan Beulich
2016-06-24 17:14 ` Anthony PERARD
2016-06-27 7:20 ` Jan Beulich
2016-06-22 17:15 ` [PATCH v5 10/14] hvmloader: Load SeaBIOS from hvm_start_info modules Anthony PERARD
2016-06-24 7:46 ` Jan Beulich
2016-06-22 17:15 ` [PATCH v5 11/14] hvmloader: Load OVMF from modules Anthony PERARD
2016-06-22 17:15 ` [PATCH v5 12/14] hvmloader: bios->bios_load() now needs to be defined Anthony PERARD
2016-06-22 17:15 ` [PATCH v5 13/14] hvmloader: Always build-in SeaBIOS and OVMF loader Anthony PERARD
2016-06-22 17:15 ` [PATCH v5 14/14] configure: do not depend on SEABIOS_PATH or OVMF_PATH Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577F781E.1030000@arm.com \
--to=julien.grall@arm.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).