Re: [PATCH v3 05/17] libxl/arm: Generate static ACPI DSDT table

[Shannon Zhao <shannon.zhao@linaro.org>]

On 2016年07月12日 19:38, Wei Liu wrote:
> On Tue, Jul 12, 2016 at 11:50:32AM +0800, Shannon Zhao wrote:
>> > 
>> > 
>> > On 2016/7/7 23:52, Wei Liu wrote:
>>> > > On Tue, Jul 05, 2016 at 11:12:35AM +0800, Shannon Zhao wrote:
>>>>> > >> > From: Shannon Zhao <shannon.zhao@linaro.org>
>>>>> > >> > 
>>>>> > >> > It uses static DSDT table like the way x86 uses. Currently the DSDT
>>>>> > >> > table only contains processor device objects and it generates the
>>>>> > >> > maximal objects which so far is 128.
>>>>> > >> > 
>>>>> > >> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>>>>> > >> > ---
>>>>> > >> >  tools/libacpi/Makefile        | 15 ++++++++++++-
>>>>> > >> >  tools/libacpi/mk_dsdt.c       | 51 ++++++++++++++++++++++++++++++++-----------
>>>>> > >> >  tools/libxl/Makefile          |  5 ++++-
>>>>> > >> >  tools/libxl/libxl_arm_acpi.c  |  5 +++++
>>>>> > >> >  xen/include/public/arch-arm.h |  3 +++
>>>>> > >> >  5 files changed, 64 insertions(+), 15 deletions(-)
>>>>> > >> > 
>>>>> > >> > diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile
>>>>> > >> > index 4068d9a..0401810 100644
>>>>> > >> > --- a/tools/libacpi/Makefile
>>>>> > >> > +++ b/tools/libacpi/Makefile
>>>>> > >> > @@ -22,6 +22,7 @@ MK_DSDT = $(ACPI_BUILD_DIR)/mk_dsdt
>>>>> > >> >  # Sources to be generated
>>>>> > >> >  C_SRC = $(ACPI_BUILD_DIR)/dsdt_anycpu.c $(ACPI_BUILD_DIR)/dsdt_15cpu.c 
>>>>> > >> >  C_SRC += $(ACPI_BUILD_DIR)/dsdt_anycpu_qemu_xen.c $(ACPI_BUILD_DIR)/dsdt_pvh.c
>>>>> > >> > +C_SRC += $(ACPI_BUILD_DIR)/dsdt_anycpu_arm.c
>>>>> > >> >  H_SRC = $(ACPI_BUILD_DIR)/ssdt_s3.h $(ACPI_BUILD_DIR)/ssdt_s4.h $(ACPI_BUILD_DIR)/ssdt_pm.h $(ACPI_BUILD_DIR)/ssdt_tpm.h
>>>>> > >> >  
>>>>> > >> >  vpath iasl $(PATH)
>>>>> > >> > @@ -35,7 +36,7 @@ $(H_SRC): $(ACPI_BUILD_DIR)/%.h: %.asl iasl
>>>>> > >> >  	cd $(CURDIR)
>>>>> > >> >  
>>>>> > >> >  $(MK_DSDT): mk_dsdt.c
>>>>> > >> > -	$(HOSTCC) $(HOSTCFLAGS) $(CFLAGS_xeninclude) -o $@ mk_dsdt.c
>>>>> > >> > +	$(HOSTCC) $(HOSTCFLAGS) $(CFLAGS_xeninclude) -D__XEN_TOOLS__ -o $@ mk_dsdt.c
>>> > > Why is this needed? Which unstable hypervisor interface you need in
>>> > > order to build this?
>> > It needs GUEST_MAX_VCPUS in mk_dsdt.c while the GUEST_MAX_VCPUS is
>> > defined under #if defined(__XEN__) || defined(__XEN_TOOLS__) in
>> > xen/include/public/arch-arm.h
>> > 
> OK. Let me elaborate a bit on this.
> 
> The two macros basically imply everything enclosed in them is subject to
> change. I guess I can live with this because this is not a public facing
> interface for library users.
> 
> Can you ack or nack my assessment?
Yeah, the mk_dsdt is just a middle result of compilation which is used
to generate DSDT table.

Thanks,
-- 
Shannon

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel