From: Julien Grall <julien.grall@arm.com>
To: Corneliu ZUZU <czuzu@bitdefender.com>, xen-devel@lists.xen.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v3 7/8] arm/atomic.h: remove '__' prefix for __atomic_add_unless()
Date: Thu, 14 Jul 2016 11:00:10 +0100 [thread overview]
Message-ID: <578762AA.9050800@arm.com> (raw)
In-Reply-To: <1468487659-12660-1-git-send-email-czuzu@bitdefender.com>
Hi Corneliu,
On 14/07/16 10:14, Corneliu ZUZU wrote:
> The built-in leading underscores ('__') don't serve any purpose, so rename
> __atomic_add_unless() -> atomic_add_unless().
The leading underscores are from the Linux code. We decided to keep
those files unmodified to help syncing atomic code.
So I am not in favor of dropping the '__'. If you want to use these
functions in the common code, then a wrapper in "asm-arm/atomic.h"
should be introduced.
Regards,
>
> Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>
> ---
> xen/include/asm-arm/arm32/atomic.h | 2 +-
> xen/include/asm-arm/arm64/atomic.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/include/asm-arm/arm32/atomic.h b/xen/include/asm-arm/arm32/atomic.h
> index 78de60f..dc95518 100644
> --- a/xen/include/asm-arm/arm32/atomic.h
> +++ b/xen/include/asm-arm/arm32/atomic.h
> @@ -121,7 +121,7 @@ static inline int atomic_cmpxchg(atomic_t *ptr, int old, int new)
> return oldval;
> }
>
> -static inline int __atomic_add_unless(atomic_t *v, int a, int u)
> +static inline int atomic_add_unless(atomic_t *v, int a, int u)
> {
> int oldval, newval;
> unsigned long tmp;
> diff --git a/xen/include/asm-arm/arm64/atomic.h b/xen/include/asm-arm/arm64/atomic.h
> index d640bef..f0e83be 100644
> --- a/xen/include/asm-arm/arm64/atomic.h
> +++ b/xen/include/asm-arm/arm64/atomic.h
> @@ -114,7 +114,7 @@ static inline int atomic_cmpxchg(atomic_t *ptr, int old, int new)
> return oldval;
> }
>
> -static inline int __atomic_add_unless(atomic_t *v, int a, int u)
> +static inline int atomic_add_unless(atomic_t *v, int a, int u)
> {
> int c, old;
>
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-14 10:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 9:09 [PATCH v3 0/8] <asm/atomic.h> adjustments Corneliu ZUZU
2016-07-14 9:09 ` [PATCH v3 1/8] asm-arm/atomic.h: fix arm32|arm64 macros duplication Corneliu ZUZU
2016-07-14 9:10 ` [PATCH v3 2/8] asm-x86/atomic.h: minor: proper atomic_inc_and_test() placement Corneliu ZUZU
2016-07-14 9:27 ` Andrew Cooper
2016-07-14 9:11 ` [PATCH v3 3/8] asm-arm/atomic.h: reorder macros to match x86-side Corneliu ZUZU
2016-07-14 9:12 ` [PATCH v3 4/8] asm/atomic.h: common prototyping (add xen/atomic.h) Corneliu ZUZU
2016-07-14 10:52 ` Stefano Stabellini
2016-07-14 9:13 ` [PATCH v3 5/8] fix: make atomic_read() param const Corneliu ZUZU
2016-07-14 9:26 ` Andrew Cooper
2016-07-14 9:31 ` Corneliu ZUZU
2016-07-14 9:33 ` Corneliu ZUZU
2016-07-14 9:13 ` [PATCH v3 6/8] asm-arm/atomic.h: atomic_{inc, dec}_return: macros to inline functions Corneliu ZUZU
2016-07-14 10:50 ` Stefano Stabellini
2016-07-14 9:14 ` [PATCH v3 7/8] arm/atomic.h: remove '__' prefix for __atomic_add_unless() Corneliu ZUZU
2016-07-14 10:00 ` Julien Grall [this message]
2016-07-14 10:03 ` Corneliu ZUZU
2016-07-14 10:50 ` Stefano Stabellini
2016-07-14 9:14 ` [PATCH v3 8/8] asm-x86/atomic.h: implement missing, add common prototypes Corneliu ZUZU
2016-07-14 9:29 ` Andrew Cooper
2016-07-14 9:39 ` Corneliu ZUZU
2016-07-14 9:44 ` Andrew Cooper
2016-07-14 9:48 ` Corneliu ZUZU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578762AA.9050800@arm.com \
--to=julien.grall@arm.com \
--cc=czuzu@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).