From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: andre.przywara@arm.com, wei.chen@linaro.org,
steve.capper@arm.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 8/9] xen/arm: traps: Avoid unnecessary VA -> IPA translation in abort handlers
Date: Thu, 14 Jul 2016 16:31:06 +0100 [thread overview]
Message-ID: <5787B03A.8080301@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1607141626150.22290@sstabellini-ThinkPad-X260>
On 14/07/16 16:27, Stefano Stabellini wrote:
> On Wed, 22 Jun 2016, Julien Grall wrote:
>> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
>> index 591de3c..0edc2cc 100644
>> --- a/xen/arch/arm/traps.c
>> +++ b/xen/arch/arm/traps.c
>> @@ -2383,13 +2383,28 @@ static inline paddr_t get_faulting_ipa(vaddr_t gva)
[..]
>> static void do_trap_instr_abort_guest(struct cpu_user_regs *regs,
>> const union hsr hsr)
>> {
>> int rc;
>> register_t gva = READ_SYSREG(FAR_EL2);
>> + uint8_t fsc = hsr.iabt.ifsc & ~FSC_LL_MASK;
>>
>> - switch ( hsr.iabt.ifsc & ~FSC_LL_MASK )
>> + switch ( fsc )
>> {
>> case FSC_FLT_PERM:
>> {
>> @@ -2400,7 +2415,7 @@ static void do_trap_instr_abort_guest(struct cpu_user_regs *regs,
>> .kind = hsr.iabt.s1ptw ? npfec_kind_in_gpt : npfec_kind_with_gla
>> };
>>
>> - if ( hsr.iabt.s1ptw )
>> + if ( hpfar_is_valid(hsr.iabt.s1ptw, fsc) )
>> gpa = get_faulting_ipa(gva);
>> else
>> {
>> @@ -2435,6 +2450,7 @@ static void do_trap_data_abort_guest(struct cpu_user_regs *regs,
>> const struct hsr_dabt dabt = hsr.dabt;
>> int rc;
>> mmio_info_t info;
>> + uint8_t fsc = hsr.dabt.dfsc & ~FSC_LL_MASK;
>
> You should be able to modify the switch in this case too, right?
Correct. I am thinking to pull the changes in patch #4 to avoid
extra-changes in this patch.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-14 15:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 13:21 [PATCH 0/9] xen/arm: Simplify do_trap_*_abort_guest Julien Grall
2016-06-22 13:21 ` [PATCH 1/9] xen/arm: Simply the definition of PAGE_SIZE by using the macro _AC Julien Grall
2016-07-14 11:02 ` Stefano Stabellini
2016-06-22 13:21 ` [PATCH 2/9] xen/arm: traps: Second attempt to correctly use the content of HPFAR_EL2 Julien Grall
2016-07-14 11:05 ` Stefano Stabellini
2016-06-22 13:21 ` [PATCH 3/9] xen/arm: traps: Data Abort are always unconditional Julien Grall
2016-07-14 11:06 ` Stefano Stabellini
2016-06-22 13:21 ` [PATCH 4/9] xen/arm: traps: Simplify the switch in do_trap_*_abort_guest Julien Grall
2016-07-14 11:12 ` Stefano Stabellini
2016-07-14 11:17 ` Julien Grall
2016-07-14 13:43 ` Stefano Stabellini
2016-06-22 13:21 ` [PATCH 5/9] xen/arm: Provide macros to help creating workaround helpers Julien Grall
2016-07-14 13:57 ` Stefano Stabellini
2016-07-20 12:43 ` Julien Grall
2016-07-22 15:05 ` Konrad Rzeszutek Wilk
2016-06-22 13:21 ` [PATCH 6/9] xen/arm: Use check_workaround to handle the erratum 766422 Julien Grall
2016-07-14 14:34 ` Stefano Stabellini
2016-07-14 14:39 ` Julien Grall
2016-06-22 13:21 ` [PATCH 7/9] xen/arm: traps: MMIO should only be emulated for fault translation Julien Grall
2016-07-14 15:06 ` Stefano Stabellini
2016-07-14 15:23 ` Julien Grall
2016-07-14 15:28 ` Stefano Stabellini
2016-07-14 15:29 ` Julien Grall
2016-06-22 13:21 ` [PATCH 8/9] xen/arm: traps: Avoid unnecessary VA -> IPA translation in abort handlers Julien Grall
2016-07-14 15:27 ` Stefano Stabellini
2016-07-14 15:31 ` Julien Grall [this message]
2016-07-14 15:35 ` Stefano Stabellini
2016-06-22 13:21 ` [PATCH 9/9] xen/arm: arm64: Add Cortex-A57 erratum 834220 workaround Julien Grall
2016-07-14 15:31 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5787B03A.8080301@arm.com \
--to=julien.grall@arm.com \
--cc=andre.przywara@arm.com \
--cc=sstabellini@kernel.org \
--cc=steve.capper@arm.com \
--cc=wei.chen@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).