From: Julien Grall <julien.grall@arm.com>
To: Corneliu ZUZU <czuzu@bitdefender.com>, xen-devel@lists.xen.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v2 1/5] asm-arm/atomic.h: fix arm32|arm64 macros duplication
Date: Thu, 14 Jul 2016 18:24:12 +0100 [thread overview]
Message-ID: <5787CABC.5000505@arm.com> (raw)
In-Reply-To: <05c8e335-56ce-a2c6-16d8-83a1e5a5cd5a@bitdefender.com>
On 14/07/16 17:40, Corneliu ZUZU wrote:
> On 7/14/2016 1:14 PM, Julien Grall wrote:
>>
>>
>> On 14/07/16 11:11, Corneliu ZUZU wrote:
>>> On 7/14/2016 12:26 PM, Julien Grall wrote:
>>>>
>>>>
>>>> On 14/07/16 06:11, Corneliu ZUZU wrote:
>>>>> On 7/13/2016 10:12 PM, Julien Grall wrote:
>>>>>> Hi Corneliu,
>>>>>>
>>>>>> On 13/07/2016 15:18, Corneliu ZUZU wrote:
>>>>>>> Move duplicate macros between asm-arm/arm32/atomic.h and
>>>>>>> asm-arm/arm64/atomic.h
>>>>>>> to asm-arm/atomic.h.
>>>>>>
>>>>>> asm-arm/arm*/atomic.h were a copy from Linux. I don't mind if we
>>>>>> diverge, however the file xen/arch/arm/README.primitives needs to be
>>>>>> update to mention the divergence with Linux.
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>
>>>>> Julien,
>>>>>
>>>>> AFAICT the README.LinuxPrimitives file specifies the Linux kernel
>>>>> version from which the arm{32,64}/atomic.h files were imported as well
>>>>> as the respective commit in the -Linux kernel- tree. I suppose that
>>>>> information needn't be updated.
>>>>> Could you be more specific on how I should modify that file?
>>>>
>>>> To specify which helpers has been taken from Linux in those files.
>>>> Until now, it was quite easy to figure out that we took all atomic_*
>>>> helpers.
>>>>
>>>> Regards,
>>>
>>>
>>> Ok, will look into that.
>>>
>>> I suppose also adding:
>>>
>>> diff -u linux/arch/arm64/include/asm/atomic.h
>>> xen/include/asm-arm/arm64/atomic.h
>>> diff -u linux/arch/arm/include/asm/atomic.h
>>> xen/include/asm-arm/arm32/atomic.h
>>>
>>> as it's done for the others helps?
>>
>> No, the other files are a verbatim copy of the Linux headers. It is
>> not the case here.
>>
>> Something like:
>>
>> "Only the following functions were taken from Linux:
>> - ...
>> - ...
>> - ...
>> "
>>
>> Regards,
>>
>
> Well, weren't they all taken from Linux?..I just turned some of the
> macros into inline functions and implemented some missing (no
> additional) ones on the X86-side.
Yes, but you don't know why you have not taken the rest (the macros are
not in atomic.h anymore...). The goal of this file is to keep track of
the difference between Linux and Xen of file taken from the former.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-14 17:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 14:18 [PATCH v2 0/5] <asm/atomic.h> adjustments Corneliu ZUZU
2016-07-13 14:18 ` [PATCH v2 1/5] asm-arm/atomic.h: fix arm32|arm64 macros duplication Corneliu ZUZU
2016-07-13 18:46 ` Stefano Stabellini
2016-07-13 19:12 ` Julien Grall
2016-07-13 19:36 ` Corneliu ZUZU
2016-07-14 5:11 ` Corneliu ZUZU
2016-07-14 9:26 ` Julien Grall
2016-07-14 10:11 ` Corneliu ZUZU
2016-07-14 10:14 ` Julien Grall
2016-07-14 16:40 ` Corneliu ZUZU
2016-07-14 17:24 ` Julien Grall [this message]
2016-07-13 14:18 ` [PATCH v2 2/5] asm-x86/atomic.h: minor: proper atomic_inc_and_test() placement Corneliu ZUZU
2016-07-13 18:47 ` Stefano Stabellini
2016-07-13 14:20 ` [PATCH v2 3/5] asm-arm/atomic.h: reorder macros to match x86-side Corneliu ZUZU
2016-07-13 18:49 ` Stefano Stabellini
2016-07-13 14:21 ` [PATCH v2 4/5] asm/atomic.h: common prototyping (add xen/atomic.h) Corneliu ZUZU
2016-07-13 19:01 ` Stefano Stabellini
2016-07-13 19:33 ` Corneliu ZUZU
2016-07-13 19:49 ` Andrew Cooper
2016-07-13 20:28 ` Corneliu ZUZU
2016-07-13 14:22 ` [PATCH v2 5/5] fix: make atomic_read() param const Corneliu ZUZU
2016-07-13 18:50 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5787CABC.5000505@arm.com \
--to=julien.grall@arm.com \
--cc=czuzu@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).