From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shanker Donthineni Subject: Re: [PATCH v2 5/6] xen/arm: traps: Avoid unnecessary VA -> IPA translation in abort handlers Date: Tue, 16 Aug 2016 21:19:14 -0500 Message-ID: <57B3C9A2.50707@codeaurora.org> References: <1469639378-9244-1-git-send-email-julien.grall@arm.com> <1469639378-9244-6-git-send-email-julien.grall@arm.com> Reply-To: shankerd@codeaurora.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1469639378-9244-6-git-send-email-julien.grall@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Julien Grall , xen-devel@lists.xen.org Cc: andre.przywara@arm.com, sstabellini@kernel.org, wei.chen@linaro.org, steve.capper@arm.com List-Id: xen-devel@lists.xenproject.org SGkgSnVsaWVuLAoKT24gMDcvMjcvMjAxNiAxMjowOSBQTSwgSnVsaWVuIEdyYWxsIHdyb3RlOgo+ IFRyYW5zbGF0aW5nIGEgVkEgdG8gYSBJUEEgaXMgZXhwZW5zaXZlLiBDdXJyZW50bHksIFhlbiBp cyBhc3N1bWluZyB0aGF0Cj4gSFBGQVJfRUwyIGlzIG9ubHkgdmFsaWQgd2hlbiB0aGUgc3RhZ2Ut MiBkYXRhL2luc3RydWN0aW9uIGFib3J0IGhhcHBlbmVkCj4gZHVyaW5nIGEgdHJhbnNsYXRpb24g dGFibGUgd2FsayBvZiBhIGZpcnN0IHN0YWdlIHRyYW5zbGF0aW9uIChpLmUgUzFQVFcKPiBpcyBz ZXQpLgo+Cj4gSG93ZXZlciwgYmFzZWQgb24gdGhlIEFSTSBBUk0gKEQ3LjIuMzQgaW4gRERJIDA0 ODdBLmopLCB0aGUgcmVnaXN0ZXIgaXMKPiBhbHNvIHZhbGlkIHdoZW4gdGhlIGRhdGEvaW5zdHJ1 Y3Rpb24gYWJvcnQgb2NjdXJlZCBmb3IgYSB0cmFuc2xhdGlvbgo+IGZhdWx0Lgo+Cj4gV2l0aCB0 aGlzIGNoYW5nZSwgdGhlIFZBIC0+IElQQSB0cmFuc2xhdGlvbiB3aWxsIG9ubHkgaGFwcGVuIGZv cgo+IHBlcm1pc3Npb24gZmF1bHRzIHRoYXQgYXJlIG5vdCByZWxhdGVkIHRvIGEgdHJhbnNsYXRp b24gdGFibGUgb2YgYQo+IGZpcnN0IHN0YWdlIHRyYW5zbGF0aW9uLgo+Cj4gU2lnbmVkLW9mZi1i eTogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPgo+IC0tLQo+ICAgICAgQ2hh bmdlcyBpbiB2MjoKPiAgICAgICAgICAtIFVzZSBmc2MgaW4gdGhlIHN3aXRjaCBpbiBkb190cmFw X2RhdGFfYWJvcnRfZ3Vlc3QKPiAtLS0KPiAgIHhlbi9hcmNoL2FybS90cmFwcy5jIHwgMjQgKysr KysrKysrKysrKysrKysrKystLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygr KSwgNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vdHJhcHMuYyBi L3hlbi9hcmNoL2FybS90cmFwcy5jCj4gaW5kZXggZWExMDVmMi4uODNhMzBmYSAxMDA2NDQKPiAt LS0gYS94ZW4vYXJjaC9hcm0vdHJhcHMuYwo+ICsrKyBiL3hlbi9hcmNoL2FybS90cmFwcy5jCj4g QEAgLTIzODIsMTMgKzIzODIsMjggQEAgc3RhdGljIGlubGluZSBwYWRkcl90IGdldF9mYXVsdGlu Z19pcGEodmFkZHJfdCBndmEpCj4gICAgICAgcmV0dXJuIGlwYTsKPiAgIH0KPgo+ICtzdGF0aWMg aW5saW5lIGJvb2wgaHBmYXJfaXNfdmFsaWQoYm9vbCBzMXB0dywgdWludDhfdCBmc2MpCj4gK3sK PiArICAgIC8qCj4gKyAgICAgKiBIUEZBUiBpcyB2YWxpZCBpZiBvbmUgb2YgdGhlIGZvbGxvd2lu ZyBjYXNlcyBhcmUgdHJ1ZToKPiArICAgICAqICAxLiB0aGUgc3RhZ2UgMiBmYXVsdCBoYXBwZW4g ZHVyaW5nIGEgc3RhZ2UgMSBwYWdlIHRhYmxlIHdhbGsKPiArICAgICAqICAodGhlIGJpdCBFU1Jf RUwyLlMxUFRXIGlzIHNldCkKPiArICAgICAqICAyLiB0aGUgZmF1bHQgd2FzIGR1ZSB0byBhIHRy YW5zbGF0aW9uIGZhdWx0Cj4gKyAgICAgKgo+ICsgICAgICogTm90ZSB0aGF0IHRlY2huaWNhbGx5 IEhQRkFSIGlzIHZhbGlkIGZvciBvdGhlciBjYXNlcywgYnV0IHRoZXkKPiArICAgICAqIGFyZSBj dXJyZW50bHkgbm90IHN1cHBvcnRlZCBieSBYZW4uCj4gKyAgICAgKi8KPiArICAgIHJldHVybiBz MXB0dyB8fCAoZnNjID09IEZTQ19GTFRfVFJBTlMpOwoKWWVzLCBYRU4gaXMgbm90IHN1cHBvcnRp bmcgdGhlIHN0YWdlIDIgYWNjZXNzIGZsYWcgYnV0IHdlIHNob3VsZCBoYW5kbGUgCmEgc3RhZ2Ug MiBhZGRyZXNzIHNpemUgZmF1bHQuCkkgdGhpbmsgd2Ugc2hvdWxkIGRvIHNvbWUgdGhpbmcgbGlr ZSB0byBiZWxvdyB0byBtYXRjaCBBUk0gQVJNLgoKcmV0dXJuIHMxcHR3IHx8IChmc2MgIT0gRlND X0ZMVF9QRVJNKTsKCgo+ICt9Cj4gKwo+ICAgc3RhdGljIHZvaWQgZG9fdHJhcF9pbnN0cl9hYm9y dF9ndWVzdChzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncywKPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgY29uc3QgdW5pb24gaHNyIGhzcikKPiAgIHsKPiAgICAgICBp bnQgcmM7Cj4gICAgICAgcmVnaXN0ZXJfdCBndmEgPSBSRUFEX1NZU1JFRyhGQVJfRUwyKTsKPiAr ICAgIHVpbnQ4X3QgZnNjID0gaHNyLmlhYnQuaWZzYyAmIH5GU0NfTExfTUFTSzsKPgo+IC0gICAg c3dpdGNoICggaHNyLmlhYnQuaWZzYyAmIH5GU0NfTExfTUFTSyApCj4gKyAgICBzd2l0Y2ggKCBm c2MgKQo+ICAgICAgIHsKPiAgICAgICBjYXNlIEZTQ19GTFRfUEVSTToKPiAgICAgICB7Cj4gQEAg LTIzOTksNyArMjQxNCw3IEBAIHN0YXRpYyB2b2lkIGRvX3RyYXBfaW5zdHJfYWJvcnRfZ3Vlc3Qo c3RydWN0Cj4gY3B1X3VzZXJfcmVncyAqcmVncywKPiAgICAgICAgICAgICAgIC5raW5kID0gaHNy LmlhYnQuczFwdHcgPyBucGZlY19raW5kX2luX2dwdCA6Cj4gbnBmZWNfa2luZF93aXRoX2dsYQo+ ICAgICAgICAgICB9Owo+Cj4gLSAgICAgICAgaWYgKCBoc3IuaWFidC5zMXB0dyApCj4gKyAgICAg ICAgaWYgKCBocGZhcl9pc192YWxpZChoc3IuaWFidC5zMXB0dywgZnNjKSApCj4gICAgICAgICAg ICAgICBncGEgPSBnZXRfZmF1bHRpbmdfaXBhKGd2YSk7Cj4gICAgICAgICAgIGVsc2UKPiAgICAg ICAgICAgewo+IEBAIC0yNDM0LDYgKzI0NDksNyBAQCBzdGF0aWMgdm9pZCBkb190cmFwX2RhdGFf YWJvcnRfZ3Vlc3Qoc3RydWN0Cj4gY3B1X3VzZXJfcmVncyAqcmVncywKPiAgICAgICBjb25zdCBz dHJ1Y3QgaHNyX2RhYnQgZGFidCA9IGhzci5kYWJ0Owo+ICAgICAgIGludCByYzsKPiAgICAgICBt bWlvX2luZm9fdCBpbmZvOwo+ICsgICAgdWludDhfdCBmc2MgPSBoc3IuZGFidC5kZnNjICYgfkZT Q19MTF9NQVNLOwo+Cj4gICAgICAgaW5mby5kYWJ0ID0gZGFidDsKPiAgICNpZmRlZiBDT05GSUdf QVJNXzMyCj4gQEAgLTI0NDIsNyArMjQ1OCw3IEBAIHN0YXRpYyB2b2lkIGRvX3RyYXBfZGF0YV9h Ym9ydF9ndWVzdChzdHJ1Y3QKPiBjcHVfdXNlcl9yZWdzICpyZWdzLAo+ICAgICAgIGluZm8uZ3Zh ID0gUkVBRF9TWVNSRUc2NChGQVJfRUwyKTsKPiAgICNlbmRpZgo+Cj4gLSAgICBpZiAoIGRhYnQu czFwdHcgKQo+ICsgICAgaWYgKCBocGZhcl9pc192YWxpZChoc3IuaWFidC5zMXB0dywgZnNjKSAp Cj4gICAgICAgICAgIGluZm8uZ3BhID0gZ2V0X2ZhdWx0aW5nX2lwYShpbmZvLmd2YSk7Cj4gICAg ICAgZWxzZQo+ICAgICAgIHsKPiBAQCAtMjQ1MSw3ICsyNDY3LDcgQEAgc3RhdGljIHZvaWQgZG9f dHJhcF9kYXRhX2Fib3J0X2d1ZXN0KHN0cnVjdAo+IGNwdV91c2VyX3JlZ3MgKnJlZ3MsCj4gICAg ICAgICAgICAgICByZXR1cm47IC8qIFRyeSBhZ2FpbiAqLwo+ICAgICAgIH0KPgo+IC0gICAgc3dp dGNoICggZGFidC5kZnNjICYgfkZTQ19MTF9NQVNLICkKPiArICAgIHN3aXRjaCAoIGZzYyApCj4g ICAgICAgewo+ICAgICAgIGNhc2UgRlNDX0ZMVF9QRVJNOgo+ICAgICAgIHsKCi0tIApTaGFua2Vy IERvbnRoaW5lbmkKUXVhbGNvbW0gRGF0YWNlbnRlciBUZWNobm9sb2dpZXMsIEluYy4gYXMgYW4g YWZmaWxpYXRlIG9mIFF1YWxjb21tIFRlY2hub2xvZ2llcywgSW5jLgpRdWFsY29tbSBUZWNobm9s b2dpZXMsIEluYy4gaXMgYSBtZW1iZXIgb2YgdGhlIENvZGUgQXVyb3JhIEZvcnVtLCBhIExpbnV4 IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0LgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRl dmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=