From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
Andrew Cooper <andrew.cooper3@citrix.com>,
ian.jackson@eu.citrix.com, peter.huangpeng@huawei.com,
xen-devel@lists.xen.org, julien.grall@arm.com,
shannon.zhao@linaro.org, boris.ostrovsky@oracle.com
Subject: Re: [PATCH v5 14/16] public/hvm/params.h: Add macros for HVM_PARAM_CALLBACK_TYPE_PPI
Date: Fri, 2 Sep 2016 15:23:19 +0800 [thread overview]
Message-ID: <57C928E7.2000205@huawei.com> (raw)
In-Reply-To: <57C935C8020000780010B0C8@prv-mh.provo.novell.com>
On 2016/9/2 14:18, Jan Beulich wrote:
>>>> On 02.09.16 at 04:55, <zhaoshenglong@huawei.com> wrote:
>> --- a/xen/include/public/hvm/params.h
>> +++ b/xen/include/public/hvm/params.h
>> @@ -30,6 +30,7 @@
>> */
>>
>> #define HVM_PARAM_CALLBACK_IRQ 0
>> +#define HVM_PARAM_CALLBACK_IRQ_TYPE_SHIFT 56
>
> This covering the top 8 bits, just the shift value might indeed be
> enough.
>
>> @@ -66,6 +67,8 @@
>> * This is only used by ARM/ARM64 and masking/eoi the interrupt associated to
>> * the notification is handled by the interrupt controller.
>> */
>> +#define HVM_PARAM_CALLBACK_TYPE_PPI_FLAG_SHIFT 8
>> +#define HVM_PARAM_CALLBACK_TYPE_PPI_FLAG_LOW_LEVEL 2
>
> Here, however, I don't see how the shift value alone can be of
> use when wanting to extract the relevant bits. I think this (and
> for consistency also the other) value should be specified as a
> mask, with users expected to have mechanisms like our
> MASK_EXTR() / MASK_INSR() available.
>
Ok, will add the mask. Thanks.
--
Shannon
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-02 7:23 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 2:55 [PATCH v5 00/16] Xen ARM DomU ACPI support Shannon Zhao
2016-09-02 2:55 ` [PATCH v5 01/16] tools/libxl: Add an unified configuration option for ACPI Shannon Zhao
2016-09-02 14:29 ` Wei Liu
2016-09-02 2:55 ` [PATCH v5 02/16] libxl/arm: prepare for constructing ACPI tables Shannon Zhao
2016-09-02 14:29 ` Wei Liu
2016-09-12 14:41 ` Julien Grall
2016-09-02 2:55 ` [PATCH v5 03/16] libxl/arm: Generate static ACPI DSDT table Shannon Zhao
2016-09-02 14:29 ` Wei Liu
2016-09-12 14:44 ` Julien Grall
2016-09-02 2:55 ` [PATCH v5 04/16] libxl/arm: Estimate the size of ACPI tables Shannon Zhao
2016-09-02 2:55 ` [PATCH v5 05/16] libxl/arm: Construct ACPI RSDP table Shannon Zhao
2016-09-12 14:58 ` Julien Grall
2016-09-02 2:55 ` [PATCH v5 06/16] libxl/arm: Construct ACPI XSDT table Shannon Zhao
2016-09-12 15:05 ` Julien Grall
2016-09-02 2:55 ` [PATCH v5 07/16] libxl/arm: Construct ACPI GTDT table Shannon Zhao
2016-09-12 15:08 ` Julien Grall
2016-09-02 2:55 ` [PATCH v5 08/16] libxl/arm: Factor MPIDR computing codes out as a helper Shannon Zhao
2016-09-02 2:55 ` [PATCH v5 09/16] libxl/arm: Construct ACPI MADT table Shannon Zhao
2016-09-12 15:09 ` Julien Grall
2016-09-02 2:55 ` [PATCH v5 10/16] libxl/arm: Construct ACPI FADT table Shannon Zhao
2016-09-12 15:10 ` Julien Grall
2016-09-02 2:55 ` [PATCH v5 11/16] libxl/arm: Construct ACPI DSDT table Shannon Zhao
2016-09-12 15:13 ` Julien Grall
2016-09-02 2:55 ` [PATCH v5 12/16] libxl/arm: Factor finalise_one_memory_node as a gerneric function Shannon Zhao
2016-09-02 2:55 ` [PATCH v5 13/16] libxl/arm: Add ACPI module Shannon Zhao
2016-09-02 2:55 ` [PATCH v5 14/16] public/hvm/params.h: Add macros for HVM_PARAM_CALLBACK_TYPE_PPI Shannon Zhao
2016-09-02 6:18 ` Jan Beulich
2016-09-02 7:23 ` Shannon Zhao [this message]
2016-09-02 8:17 ` Jan Beulich
2016-09-02 2:55 ` [PATCH v5 15/16] libxl/arm: Initialize domain param HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-09-12 15:14 ` Julien Grall
2016-09-02 2:55 ` [PATCH v5 16/16] libxl/arm: Add the size of ACPI tables to maxmem Shannon Zhao
2016-09-12 15:18 ` Julien Grall
2016-09-13 7:03 ` Shannon Zhao
2016-09-13 10:38 ` Julien Grall
2016-09-15 10:46 ` Wei Liu
2016-09-19 14:53 ` Ian Jackson
2016-09-02 14:31 ` [PATCH v5 00/16] Xen ARM DomU ACPI support Wei Liu
2016-09-12 15:22 ` Julien Grall
2016-09-13 6:30 ` Shannon Zhao
2016-09-13 11:56 ` Julien Grall
2016-09-13 13:06 ` Shannon Zhao
2016-09-13 15:17 ` Julien Grall
2016-09-13 15:18 ` Julien Grall
2016-09-14 0:56 ` Shannon Zhao
2016-09-14 1:06 ` Stefano Stabellini
2016-09-14 7:14 ` Julien Grall
2016-09-14 7:32 ` Shannon Zhao
2016-09-14 7:40 ` Julien Grall
2016-09-14 8:01 ` Shannon Zhao
2016-09-14 20:48 ` Stefano Stabellini
2016-09-14 21:26 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C928E7.2000205@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=peter.huangpeng@huawei.com \
--cc=shannon.zhao@linaro.org \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).